Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

From: Haakon Bugge <haakon.bugge@oracle.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Doug Ledford <dledford@redhat.com>,
	OFED mailing list <linux-rdma@vger.kernel.org>,
	Parav Pandit <parav@nvidia.com>,
	Linux-Net <netdev@vger.kernel.org>,
	"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS
Date: Tue, 13 Apr 2021 11:13:38 +0000	[thread overview]
Message-ID: <F450613D-9A52-4D21-A2D5-E27FA4EBDBBE@oracle.com> (raw)
In-Reply-To: <YHU6VXP6kZABXIYA@unreal>

> On 13 Apr 2021, at 08:29, Leon Romanovsky <leon@kernel.org> wrote:
> 
> On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote:
>> On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote:
>>> ib_modify_qp() is an expensive operation on some HCAs running
>>> virtualized. This series removes two ib_modify_qp() calls from RDS.
>>> 
>>> I am sending this as a v3, even though it is the first sent to
>>> net. This because the IB Core commit has reach v3.
>>> 
>>> Håkon Bugge (2):
>>>  IB/cma: Introduce rdma_set_min_rnr_timer()
>>>  rds: ib: Remove two ib_modify_qp() calls
>> 
>> Applied to rdma for-next, thanks
> 
> Jason,
> 
> It should be 
> +	WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_TGT);

With no return you will arm the setting of the timer and subsequently get an error from the modify_qp later.

Håkon

> 
> and not
> +	if (WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_TGT))
> +		return -EINVAL;
> 
> Thanks
> 
>> 
>> Jason