All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lin, Mengdong" <mengdong.lin@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Yang, Libin" <libin.yang@intel.com>,
	"anssi.hannula@iki.fi" <anssi.hannula@iki.fi>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	David Henningsson <david.henningsson@canonical.com>
Subject: Re: [PATCH] ALSA: hda - using POS_FIX_LPIB on Broadwell HDMI Audio
Date: Tue, 13 May 2014 09:00:56 +0000	[thread overview]
Message-ID: <F46914AEC2663F4A9BB62374E5EEF8F82B415DFC@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <s5hwqdqqh6h.wl%tiwai@suse.de>

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Tuesday, May 13, 2014 3:20 PM

> It can be just simple like the patch below.  This is rather a tentative
> workaround.  If the hardware (or the corresponding part in the graphics driver)
> is fixed, we can get rid of it easily.  So, just keep the change as small and
> simple as possible.
> 
> 
> Takashi
> 
> ---
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index
> b540ad71eb0d..2c54629d62d1 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1367,6 +1367,12 @@ static int azx_first_init(struct azx *chip)
>  	/* initialize streams */
>  	azx_init_stream(chip);
> 
> +	/* workaround for Broadwell HDMI: the first stream is broken,
> +	 * so mask it by keeping it as if opened
> +	 */
> +	if (pci->vendor == 0x8086 && pci->device == 0x160c)
> +		chip->azx_dev[0].opened = 1;
> +
>  	/* initialize chip */
>  	azx_init_pci(chip);
>  	azx_init_chip(chip, (probe_only[dev] & 2) == 0);


Hi Takashi,

I revised the patch as you suggested. Hope we'll have a better solution for Broadwell soon.

Thanks
Mengdong

  reply	other threads:[~2014-05-13  9:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 18:03 [PATCH] ALSA: hda - using POS_FIX_LPIB on Broadwell HDMI Audio libin.yang
2014-05-08  5:09 ` Takashi Iwai
2014-05-08  5:48   ` Yang, Libin
2014-05-08  5:51     ` Takashi Iwai
2014-05-08  6:13       ` Yang, Libin
2014-05-08  6:19         ` Takashi Iwai
2014-05-08  6:28           ` Yang, Libin
2014-05-08  6:39             ` Takashi Iwai
2014-05-08  7:58               ` Yang, Libin
2014-05-08 16:06                 ` David Henningsson
2014-05-09 10:08                   ` Lin, Mengdong
2014-05-09 10:20                     ` Takashi Iwai
2014-05-12  8:22                       ` Lin, Mengdong
2014-05-12  8:31                         ` Takashi Iwai
2014-05-12  9:46                           ` Lin, Mengdong
2014-05-12  9:51                             ` Takashi Iwai
2014-05-13  4:37                               ` Lin, Mengdong
2014-05-13  7:19                                 ` Takashi Iwai
2014-05-13  9:00                                   ` Lin, Mengdong [this message]
2014-05-09 14:58                     ` Pierre-Louis Bossart
2014-05-08  9:37               ` Lin, Mengdong
2014-05-08  9:42                 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F46914AEC2663F4A9BB62374E5EEF8F82B415DFC@SHSMSX101.ccr.corp.intel.com \
    --to=mengdong.lin@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anssi.hannula@iki.fi \
    --cc=david.henningsson@canonical.com \
    --cc=libin.yang@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.