From: Salil Mehta <salil.mehta@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
"lipeng (Y)" <lipeng321@huawei.com>,
"mehta.salil@opnsrc.net" <mehta.salil@opnsrc.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
"wangxi (M)" <wangxi11@huawei.com>
Subject: RE: [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam
Date: Mon, 4 Jun 2018 15:39:45 +0000 [thread overview]
Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93BD9C174@FRAEML521-MBX.china.huawei.com> (raw)
In-Reply-To: <20180604.113552.1136710379930167373.davem@davemloft.net>
Hi Dave,
Thanks for pointing out. Will fix them.
Best regards
Salil
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Monday, June 04, 2018 4:36 PM
> To: Salil Mehta <salil.mehta@huawei.com>
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@huawei.com>; lipeng (Y)
> <lipeng321@huawei.com>; mehta.salil@opnsrc.net; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Linuxarm <linuxarm@huawei.com>; wangxi
> (M) <wangxi11@huawei.com>
> Subject: Re: [PATCH net] net: hns: Fix the process of adding broadcast
> addresses to tcam
>
> From: Salil Mehta <salil.mehta@huawei.com>
> Date: Fri, 1 Jun 2018 18:00:11 +0100
>
> > + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> > + mc_mask, mac_entry->addr);
>
> Please indent things properly when arguments span multiple lines.
>
> The second line here should be precisely after the opennning
> parenthesis
> of the previous line.
>
> > + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> > + mc_mask, mac_entry->addr);
>
> Likewise.
prev parent reply other threads:[~2018-06-04 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 17:00 [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam Salil Mehta
2018-06-04 15:35 ` David Miller
2018-06-04 15:39 ` Salil Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F4CC6FACFEB3C54C9141D49AD221F7F93BD9C174@FRAEML521-MBX.china.huawei.com \
--to=salil.mehta@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil@opnsrc.net \
--cc=netdev@vger.kernel.org \
--cc=wangxi11@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.