From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ouyang, Changchun" Subject: Re: [PATCH] ixgbe: Fix an unnecessary check in vf rss Date: Wed, 28 Jan 2015 01:35:00 +0000 Message-ID: References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> <1561845.4QtzaTeLCI@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <1561845.4QtzaTeLCI@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Tuesday, January 27, 2015 8:13 PM > To: Ouyang, Changchun > Cc: dev-VfR2kkLFssw@public.gmane.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss >=20 > > To follow up the comments from Wodkowski, PawelX, remove this > > unnecessary check, as check_mq_mode has already check the queue > number > > in device configure stage, if the queue number of vf is not correct, > > it will return error code and exit, so it doesn't need check again > > here in device start stage(note: pf_host_configure is called in device = start > stage). > > > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > > > Signed-off-by: Changchun Ouyang >=20 > Suggested-by: Pawel Wodkowski > Fixes: 42d2f78abcb77 ("configure VF RSS") >=20 > Applied >=20 Thanks very much for the applying! > Changchun, as you are working on ixgbe, maybe you would like to review > some ixgbe patches from others? >=20 No problem, I will try to do it when my bandwidth allows me to do it, :-) Thanks Changchun