From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ouyang, Changchun" Subject: Re: [PATCH] examples/vhost: use library routines instead of local copies Date: Thu, 26 Mar 2015 03:32:46 +0000 Message-ID: References: <1427309006-26590-1-git-send-email-zoltan.kiss@linaro.org> <2601191342CEEE43887BDE71AB97725821407936@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Ananyev, Konstantin" , Zoltan Kiss , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB97725821407936-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, March 26, 2015 9:21 AM > To: Zoltan Kiss; dev-VfR2kkLFssw@public.gmane.org > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: use library routines > instead of local copies >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Zoltan Kiss > > Sent: Wednesday, March 25, 2015 6:43 PM > > To: dev-VfR2kkLFssw@public.gmane.org > > Cc: Zoltan Kiss > > Subject: [dpdk-dev] [PATCH] examples/vhost: use library routines > > instead of local copies > > > > This macro and function were copies from the mbuf library, no reason > > to keep them. >=20 > NACK > You can't use RTE_MBUF_INDIRECT macro here. > If you'll look at vhost code carefully, you'll realise that we don't use = standard > rte_pktmbuf_attach() here. > As we attach mbuf not to another mbuf but to external memory buffer, > passed to us by virtio device. > Look at attach_rxmbuf_zcp(). > Though I suppose, we can replace pktmbuf_detach_zcp() , with > rte_pktmbuf_detach() - they are doing identical things. > BTW, I wonder did you ever test your patch? > My guess it would cause vhost with '--zero-copy' to crash or corrupt the > packets straightway. >=20 > Konstantin >=20 > > > > Signed-off-by: Zoltan Kiss NACK this patch, Same reason with Konstantin. Changchun