From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
Subject: Re: [PATCH 4/5] virtio: free queue memory in
	virtio_dev_close()
Date: Wed, 15 Jul 2015 08:36:49 +0000
Message-ID: <F52918179C57134FAEC9EA62FA2F962511BFE649@shsmsx102.ccr.corp.intel.com>
References: <PATCH>
 <1436879459-18400-1-git-send-email-bernard.iremonger@intel.com>
 <1436879459-18400-5-git-send-email-bernard.iremonger@intel.com>
 <F52918179C57134FAEC9EA62FA2F962511BFDDBC@shsmsx102.ccr.corp.intel.com>
 <8CEF83825BEC744B83065625E567D7C204A48FD6@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 80993DE4
 for <dev@dpdk.org>; Wed, 15 Jul 2015 10:38:49 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A48FD6@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Bernard

> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Wednesday, July 15, 2015 4:02 PM
> To: Ouyang, Changchun; dev@dpdk.org
> Cc: Xu, Qian Q; stephen@networkplumber.org
> Subject: RE: [PATCH 4/5] virtio: free queue memory in virtio_dev_close()
>=20
> Hi  Ouyang,
>=20
> <snip>
>=20
> > > --- a/drivers/net/virtio/virtio_ethdev.c
> > > +++ b/drivers/net/virtio/virtio_ethdev.c
> > > @@ -438,6 +438,24 @@ virtio_dev_cq_queue_setup(struct rte_eth_dev
> > > *dev, uint16_t vtpci_queue_idx,  }
> > >
> > >  static void
> > > +virtio_free_queues(struct rte_eth_dev *dev) {
> > > +	unsigned int i;
> > > +
> > > +	for (i =3D 0; i < dev->data->nb_rx_queues; i++) {
> > > +		virtio_dev_rx_queue_release(dev->data->rx_queues[i]);
> > > +		dev->data->rx_queues[i] =3D NULL;
> > > +	}
> > > +	dev->data->nb_rx_queues =3D 0;
> > > +
> > > +	for (i =3D 0; i < dev->data->nb_tx_queues; i++) {
> > > +		virtio_dev_tx_queue_release(dev->data->tx_queues[i]);
> > > +		dev->data->tx_queues[i] =3D NULL;
> > > +	}
> > > +	dev->data->nb_tx_queues =3D 0;
> > > +}
> > > +
> > > +static void
> > >  virtio_dev_close(struct rte_eth_dev *dev)  {
> > >  	struct virtio_hw *hw =3D dev->data->dev_private; @@ -451,6 +469,7
> > @@
> > > virtio_dev_close(struct rte_eth_dev *dev)
> > >  	vtpci_reset(hw);
> > >  	hw->started =3D 0;
> > >  	virtio_dev_free_mbufs(dev);
> > > +	virtio_free_queues(dev);
> >
> > Validate it with vhost sample or not for this change?
>=20
> I have tested this change with testpmd on a Fedora VM.

I think we should make sure it will not break any current test case for vir=
tio,
So before applying it, it needs use vhost sample on host and test the virti=
o driver on guest.

Thanks
Changchun
  =20