HI Bart, Missing msg ids need to be updated on qla_dbg.c file. Here is an updated patch. diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 25ded57..9520b1f 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -1084,14 +1084,6 @@ qla84xx_mgmt_cmd(struct fc_bsg_job *bsg_job) return -EINVAL; } - ql84_mgmt = (struct qla_bsg_a84_mgmt *)((char *)bsg_job->request + - sizeof(struct fc_bsg_request)); - if (!ql84_mgmt) { - ql_log(ql_log_warn, vha, 0x703b, - "MGMT header not provided, exiting.\n"); - return -EINVAL; - } - mn = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL, &mn_dma); if (!mn) { ql_log(ql_log_warn, vha, 0x703c, @@ -1102,7 +1094,7 @@ qla84xx_mgmt_cmd(struct fc_bsg_job *bsg_job) memset(mn, 0, sizeof(struct access_chip_84xx)); mn->entry_type = ACCESS_CHIP_IOCB_TYPE; mn->entry_count = 1; - + ql84_mgmt = (void *)bsg_job->request + sizeof(struct fc_bsg_request); switch (ql84_mgmt->mgmt.cmd) { case QLA84_MGMT_READ_MEM: case QLA84_MGMT_GET_INFO: diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index 980dcbc..1c1972b 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.c +++ b/drivers/scsi/qla2xxx/qla_dbg.c @@ -36,7 +36,7 @@ * | | | 0x70a8,0x70ab, | * | | | 0x70ad-0x70ae, | * | | | 0x70d1-0x70da, | - * | | | 0x7047 | + * | | | 0x7047,0x703b | * | Task Management | 0x803c | 0x8025-0x8026 | * | | | 0x800b,0x8039 | * | AER/EEH | 0x9011 | | Thanks, ~Saurav >Remove dead code, simplify a pointer computation and move the >ql84_mgmt assignment to just before its first use. > >Signed-off-by: Bart Van Assche >Cc: Chad Dupuis >Cc: Saurav Kashyap >--- > drivers/scsi/qla2xxx/qla_bsg.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_bsg.c >b/drivers/scsi/qla2xxx/qla_bsg.c >index 7221521..cf07491 100644 >--- a/drivers/scsi/qla2xxx/qla_bsg.c >+++ b/drivers/scsi/qla2xxx/qla_bsg.c >@@ -1084,14 +1084,6 @@ qla84xx_mgmt_cmd(struct fc_bsg_job *bsg_job) > return -EINVAL; > } > >- ql84_mgmt = (struct qla_bsg_a84_mgmt *)((char *)bsg_job->request + >- sizeof(struct fc_bsg_request)); >- if (!ql84_mgmt) { >- ql_log(ql_log_warn, vha, 0x703b, >- "MGMT header not provided, exiting.\n"); >- return -EINVAL; >- } >- > mn = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL, &mn_dma); > if (!mn) { > ql_log(ql_log_warn, vha, 0x703c, >@@ -1103,6 +1095,7 @@ qla84xx_mgmt_cmd(struct fc_bsg_job *bsg_job) > mn->entry_type = ACCESS_CHIP_IOCB_TYPE; > mn->entry_count = 1; > >+ ql84_mgmt = (void *)bsg_job->request + sizeof(struct fc_bsg_request); > switch (ql84_mgmt->mgmt.cmd) { > case QLA84_MGMT_READ_MEM: > case QLA84_MGMT_GET_INFO: >-- >1.7.10.4 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html