Hi Bart, I removed the success message also and updated the qla_dbg.c file. diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index 1c1972b..dc227fa 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.c +++ b/drivers/scsi/qla2xxx/qla_dbg.c @@ -15,6 +15,7 @@ * | Mailbox commands | 0x117a | 0x111a-0x111b | * | | | 0x1155-0x1158 | * | Device Discovery | 0x2095 | 0x2020-0x2022, | + * | | | 0x2011-0x2012, | * | | | 0x2016 | * | Queue Command and IO tracing | 0x3058 | 0x3006-0x300b | * | | | 0x3027-0x3028 | diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 8c7a123..c4fc8a2 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2320,14 +2320,6 @@ qla2x00_configure_hba(scsi_qla_host_t *vha) "Topology - %s, Host Loop address 0x%x.\n", connect_type, vha->loop_id); - if (rval) { - ql_log(ql_log_warn, vha, 0x2011, - "%s FAILED\n", __func__); - } else { - ql_dbg(ql_dbg_disc, vha, 0x2012, - "%s success\n", __func__); - } - return(rval); } Thanks, ~Saurav >At the end of qla2x00_configure_hba() we know that rval == QLA_SUCCESS. >Hence remove the code that depends on rval != QLA_SUCCESS. > >Signed-off-by: Bart Van Assche >Cc: Chad Dupuis >Cc: Saurav Kashyap >--- > drivers/scsi/qla2xxx/qla_init.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_init.c >b/drivers/scsi/qla2xxx/qla_init.c >index 3565dfd..c68bb01 100644 >--- a/drivers/scsi/qla2xxx/qla_init.c >+++ b/drivers/scsi/qla2xxx/qla_init.c >@@ -2309,13 +2309,7 @@ qla2x00_configure_hba(scsi_qla_host_t *vha) > "Topology - %s, Host Loop address 0x%x.\n", > connect_type, vha->loop_id); > >- if (rval) { >- ql_log(ql_log_warn, vha, 0x2011, >- "%s FAILED\n", __func__); >- } else { >- ql_dbg(ql_dbg_disc, vha, 0x2012, >- "%s success\n", __func__); >- } >+ ql_dbg(ql_dbg_disc, vha, 0x2012, "%s success\n", __func__); > > return(rval); > } >-- >1.7.10.4 >