From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saurav Kashyap Subject: Re: [PATCH 03/10] qla2xxx: Remove dead code in qla2x00_configure_hba() Date: Wed, 12 Jun 2013 08:08:00 +0000 Message-ID: References: <51AF375C.3000902@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_F5D084D6342F9B479C34599BB0A03E4D35390FEBAVMB1qlogicorg_" Return-path: Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:41440 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754833Ab3FLIIF (ORCPT ); Wed, 12 Jun 2013 04:08:05 -0400 Received: from mail28-ch1 (localhost [127.0.0.1]) by mail28-ch1-R.bigfish.com (Postfix) with ESMTP id C2C4122011D for ; Wed, 12 Jun 2013 08:08:04 +0000 (UTC) Received: from CH1EHSMHS004.bigfish.com (snatpool3.int.messaging.microsoft.com [10.43.68.225]) by mail28-ch1.bigfish.com (Postfix) with ESMTP id 9E01B1A0083 for ; Wed, 12 Jun 2013 08:08:02 +0000 (UTC) In-Reply-To: <51AF375C.3000902@acm.org> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche , linux-scsi Cc: Chad Dupuis --_000_F5D084D6342F9B479C34599BB0A03E4D35390FEBAVMB1qlogicorg_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Hi Bart, I removed the success message also and updated the qla_dbg.c file. diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index 1c1972b..dc227fa 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.c +++ b/drivers/scsi/qla2xxx/qla_dbg.c @@ -15,6 +15,7 @@ * | Mailbox commands | 0x117a | 0x111a-0x111b | * | | | 0x1155-0x1158 | * | Device Discovery | 0x2095 | 0x2020-0x2022, | + * | | | 0x2011-0x2012, | * | | | 0x2016 | * | Queue Command and IO tracing | 0x3058 | 0x3006-0x300b | * | | | 0x3027-0x3028 | diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 8c7a123..c4fc8a2 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2320,14 +2320,6 @@ qla2x00_configure_hba(scsi_qla_host_t *vha) "Topology - %s, Host Loop address 0x%x.\n", connect_type, vha->loop_id); =20 - if (rval) { - ql_log(ql_log_warn, vha, 0x2011, - "%s FAILED\n", __func__); - } else { - ql_dbg(ql_dbg_disc, vha, 0x2012, - "%s success\n", __func__); - } - return(rval); } Thanks, ~Saurav >At the end of qla2x00_configure_hba() we know that rval =3D=3D QLA_SUCCESS= . >Hence remove the code that depends on rval !=3D QLA_SUCCESS. > >Signed-off-by: Bart Van Assche >Cc: Chad Dupuis >Cc: Saurav Kashyap >--- > drivers/scsi/qla2xxx/qla_init.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_init.c >b/drivers/scsi/qla2xxx/qla_init.c >index 3565dfd..c68bb01 100644 >--- a/drivers/scsi/qla2xxx/qla_init.c >+++ b/drivers/scsi/qla2xxx/qla_init.c >@@ -2309,13 +2309,7 @@ qla2x00_configure_hba(scsi_qla_host_t *vha) > "Topology - %s, Host Loop address 0x%x.\n", > connect_type, vha->loop_id); >=20 >- if (rval) { >- ql_log(ql_log_warn, vha, 0x2011, >- "%s FAILED\n", __func__); >- } else { >- ql_dbg(ql_dbg_disc, vha, 0x2012, >- "%s success\n", __func__); >- } >+ ql_dbg(ql_dbg_disc, vha, 0x2012, "%s success\n", __func__); >=20 > return(rval); > } >--=20 >1.7.10.4 > --_000_F5D084D6342F9B479C34599BB0A03E4D35390FEBAVMB1qlogicorg_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IgZuAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAADEyRDgxMkQ0 OEY4REZBNEU5MTFGOTUyQkFDN0FGN0IyAGQHAQ2ABAACAAAAAgACAAEFgAMADgAAAN0HBgAMAAgA CAAAAAMACQEBIIADAA4AAADdBwYADAAIAAgAAAADAAkBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAEcAAABSZTogW1BBVENIIDAzLzEwXSBxbGEyeHh4OiBSZW1vdmUgZGVh ZCBjb2RlIGluIHFsYTJ4MDBfY29uZmlndXJlX2hiYSgpANAWAQOQBgA4EQAAMwAAAAIBfwABAAAA PAAAADxGNUQwODRENjM0MkY5QjQ3OUMzNDU5OUJCMEEwM0U0RDM1MzkwRkVCQEFWTUIxLnFsb2dp Yy5vcmc+AAsAHw4BAAAAAgEJEAEAAACOBQAAigUAAAMNAABMWkZ1IsdqEWEACmZiaWQEAABjY8Bw ZzEyNTIA/gND8HRleHQB9wKkA+MCAARjaArAc2V0MCDvB20CgwBQEU0yCoAGtAKAln0KgAjIOwli MTkOwL8JwxZyCjIWcQKAFWIqCbBzCfAEkGF0BbIOUANgc6JvAYAgRXgRwW4YMF0GUnYEkBe2AhBy AMB0fQhQbhoxECAFwAWgG2RkmiADUiAQIheyXHYIkOR3awuAZDUdUwTwB0ANF3AwCnEX8mJrbWsG cwGQACAgQk1fQuBFR0lOfQr8AfEL8RggSGkfsB+BLFxs5QuAZQqASSAJcARgGjAJHGB0aBngc3Vj Y+cHkAQgB4FzYRnRB0AZIMMkYB3AIHVwZBiAIwUCcQtgX2RiZy5j8xxwAxBlLiIlJrwN4AEgICAt LWdpBUBhL2ZkBRAaMXMvBPAAkC95JcEyeCngKZIl9CIlYh8ozynfIlIdsRAwIDFjAxZwAcBiLi5k YzIwMjdmYS3gHqA2NHY0IiUoUC0orywvIjQrnTKAICsvMS8iQ0BAKEBAMTUsNiArNXE3BiA1MCIl ICAqIHy7BdALcGwG4C3QBaBtA4EeZAQgOBo28DgUMHgxHDE3LuA4hjliMWEt/TpTYjjBNks8Hzgv PP85UyQ1NTqzNTg7LkRlvx1gI6BBIAQABaAaMXk9L/M5JAHQOTU5yQHQAdA6sflEkTIsOzcyoDvv Pk9HD/9EJzmARNMOkEVIO89L/0svb0kaNaBChzZLUQpQClAgZwhQN7Mks0lPHMAYcGPlC4BnONkz MEASOedS0P8vIDqxU8E7H1VvTG9WT1Kj+y6wVAMyQCkoDzMvJcILgJ9aoCqfW19cbS2UOGM5oKUO kDMuYGM0EbA4M9D/Lv9az15fMh9iv2PPNTJggPEB0CwxNDWwZ9M1oDUxWzOzHqBfG+EmYGcIcGWg X2hiYShlsl8lwpJoGRB0XwVAKnYR0AYpNkdsPyAiVG9wTQjxZ0IgYjAlc0VASLFrASBMb22AJGBk ZTATI7I5YCV4JqBcbiJfIhZsX1ZxG+EYUGNrIXnMcGVFQGtxLT4JAG2A+VxwZCkWIDZVYaZWdQaQ 7CAoGiAHQCkDMAAAdCwrVnYlwF9tsSh3NF93/QrAbnKTRUBJhCIWdj5tIwFuICBGQUlMRUQBb9Mg X19mdW5jh3vgc3d0hlx9IGUkgP8Z4HWvdrkmAXeSJgEl8EGx/3haRTB+H3pMI3V7j3yeYabrcC0J cHQIcG51NHOIhebdIiVUGaEfUCIWfgYQCHDMYXYmvyJSPkEFQCMyvwnwHGAZMGj/agR1gHcZ4Phr bm8H4CMwGIAioHVRCCA9PVBQTEFfU0BVQ0NFU1Mmpj7+SAnwQXEitCMjBaABAI803wEAcnA34gIg j4Qhj/+ME02L5lNpwBhQZC0ZMGaQLWJ5OiHDIFYDkU5BBBARwBngPGJ1UG5KYZeDQADQbS4FsGdp lWdDY5bAQxHQHGBE3SUAdQQAl9ARwWQucJpD/kAlwG3ADlAmMANwmRuKpEQgS5gwaHlhbuA88yQg isIua51km2+MMWIRv4vmkvBlT2ZbONRAICtiEbujQqA3MSZTG9AZo2RFQC+kQAuAEgAAIGkCICgr PilFQDYAAQAecKWycyi+LWumlWdaL6EPZo8+ZR8Hqe+L9S2UMzU2NWTDBXBgoTY4YmJJsGE8/5/y qM+sb4vmZN+xX6q5Z5T7Q7BoEDNoQrZBNgKNP2oP/2sfoKAMhAGgbR9uL28/ui//ca9yv75Vn5a6 03UPwia60/93P3hPw556r4Qfwhh9f8Ps/3+/gM/G74M/yP/KB7KXy+//zP9KMs+f0K/BuLqDh1++ VYfSN7BRi+YxLjcuHpAeLq+3iwwVQt0gAAAfAEIAAQAAAB4AAABTAGEAdQByAGEAdgAgAEsAYQBz AGgAeQBhAHAAAAAAAB8AZQABAAAANAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEA bABvAGcAaQBjAC4AYwBvAG0AAAAfAGQAAQAAAAoAAABTAE0AVABQAAAAAAACAUEAAQAAAHQAAAAA AAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAABTAE0A VABQAAAAcwBhAHUAcgBhAHYALgBrAGEAcwBoAHkAYQBwAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAA AB8AAl0BAAAANAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4A YwBvAG0AAAAfAOVfAQAAADwAAABzAGkAcAA6AHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABA AHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfABoMAQAAAB4AAABTAGEAdQByAGEAdgAgAEsAYQBzAGgA eQBhAHAAAAAAAB8AHwwBAAAANAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABv AGcAaQBjAC4AYwBvAG0AAAAfAB4MAQAAAAoAAABTAE0AVABQAAAAAAACARkMAQAAAHQAAAAAAAAA gSsfpL6jEBmdbgDdAQ9UAgAAAIBTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAABTAE0AVABQ AAAAcwBhAHUAcgBhAHYALgBrAGEAcwBoAHkAYQBwAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8A AV0BAAAANAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBv AG0AAAAfAPg/AQAAAB4AAABTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAAAAAB8AI0ABAAAA NAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAf ACJAAQAAAAoAAABTAE0AVABQAAAAAAACAfk/AQAAAHQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAA AIBTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAABTAE0AVABQAAAAcwBhAHUAcgBhAHYALgBr AGEAcwBoAHkAYQBwAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8ACV0BAAAANAAAAHMAYQB1AHIA YQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAALAEA6AQAAAB8AGgAB AAAAEgAAAEkAUABNAC4ATgBvAHQAZQAAAAAAAwDxPwkEAAALAEA6AQAAAAMA/T/kBAAAAgELMAEA AAAQAAAAEtgS1I+N+k6RH5UrrHr3sgMAFwABAAAAQAA5AADwVPRDZ84BQAAIMJ5qcvRDZ84BCwAA gAggBgAAAAAAwAAAAAAAAEYAAAAAFIUAAAEAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAeAAAA YQBjAGMAZQBwAHQAbABhAG4AZwB1AGEAZwBlAAAAAAABAAAADAAAAGUAbgAtAFUAUwAAAAsAAIAI IAYAAAAAAMAAAAAAAABGAAAAAAaFAAAAAAAAHwA3AAEAAACOAAAAUgBlADoAIABbAFAAQQBUAEMA SAAgADAAMwAvADEAMABdACAAcQBsAGEAMgB4AHgAeAA6ACAAUgBlAG0AbwB2AGUAIABkAGUAYQBk ACAAYwBvAGQAZQAgAGkAbgAgAHEAbABhADIAeAAwADAAXwBjAG8AbgBmAGkAZwB1AHIAZQBfAGgA YgBhACgAKQAAAAAAHwA9AAEAAAAKAAAAUgBlADoAIAAAAAAAAwA2AAAAAAAfAEIQAQAAADYAAAA8 ADUAMQBBAEYAMwA3ADUAQwAuADMAMAAwADAAOQAwADIAQABhAGMAbQAuAG8AcgBnAD4AAAAAAAIB cQABAAAAGwAAAAEBzmHtSNajJMNQp3RHgDBx6ZHYy+KZMpWVAAAfAHAAAQAAAIYAAABbAFAAQQBU AEMASAAgADAAMwAvADEAMABdACAAcQBsAGEAMgB4AHgAeAA6ACAAUgBlAG0AbwB2AGUAIABkAGUA YQBkACAAYwBvAGQAZQAgAGkAbgAgAHEAbABhADIAeAAwADAAXwBjAG8AbgBmAGkAZwB1AHIAZQBf AGgAYgBhACgAKQAAAAAAHwA1EAEAAAB4AAAAPABGADUARAAwADgANABEADYAMwA0ADIARgA5AEIA NAA3ADkAQwAzADQANQA5ADkAQgBCADAAQQAwADMARQA0AEQAMwA1ADMAOQAwAEYARQBCAEAAQQBW AE0AQgAxAC4AcQBsAG8AZwBpAGMALgBvAHIAZwA+AAAAAwDeP59OAABAAAcw3qdt9ENnzgEDACYA AAAAAAIBRwABAAAALgAAAGM9VVM7YT0gO3A9UUxvZ2ljO2w9QVZNQjEtMTMwNjEyMDgwODAwWi0z Mzc4OAAAAB8AFRABAAAAWAAAAEMANgBBADAANQA4ADIANgAzADMAOQAyAEMARgA0ADEAOQA2AEYA MgA4ADAAMAAwADUAMwAxAEYAMQA2ADUAMABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAACARQwAQAA AAwAAACrAAAAqoGwnkgAAAAfAPo/AQAAAB4AAABTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAA AAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAABYAAAB1AHMAZQByAC0AYQBnAGUAbgB0AAAAAAAB AAAASAAAAE0AaQBjAHIAbwBzAG8AZgB0AC0ATQBhAGMATwB1AHQAbABvAG8AawAvADEANAAuADEA MAAuADAALgAxADEAMAAzADEAMAAAAB8AAIAfpOszqHouQr57eeGpjlSzAQAAADgAAABDAG8AbgB2 AGUAcgBzAGEAdABpAG8AbgBJAG4AZABlAHgAVAByAGEAYwBrAGkAbgBnAEUAeAAAAAEAAAAGAQAA SQBJAD0AMAAxADAAMQBDAEUANgA3ADQAMwBGADQAMwAwADYAQwBDADkANgBFAEYAQQAwADkANQBB ADQANQA4ADAAQgAzAEEAMQBGAEUAOQBDAEYAOAA2ADgANQBEADsAUwBCAE0ASQBEAD0AMgA7AFMA MQA9ADwANQAxAEEARgAzADcANQBDAC4AMwAwADAAMAA5ADAAMgBAAGEAYwBtAC4AbwByAGcAPgA7 AFYAZQByAHMAaQBvAG4APQBWAGUAcgBzAGkAbwBuACAAMQA0AC4AMgAgACgAQgB1AGkAbABkACAA MwAxADgALgAwACkALAAgAFMAdABhAGcAZQA9AEgAMgAAAAAAAwANNP0/AAAfAACAhgMCAAAAAADA AAAAAAAARgEAAAAgAAAAeAAtAG0AcwAtAGgAYQBzAC0AYQB0AHQAYQBjAGgAAAABAAAAAgAAAAAA AAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAiAAAAeAAtAG8AcgBpAGcAaQBuAGEAdABpAG4AZwAt AGkAcAAAAAAAAQAAABoAAABbADEAMAAuADMANQAuADcALgA0ADUAXQAAAAAAHwAAgIYDAgAAAAAA wAAAAAAAAEYBAAAAFgAAAGQAaQBzAGMAbABhAGkAbQBlAHIAAAAAAAEAAAAOAAAAYgB5AHAAYQBz AHMAAAAAAKnC --_000_F5D084D6342F9B479C34599BB0A03E4D35390FEBAVMB1qlogicorg_--