From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saurav Kashyap Subject: Re: [PATCH 05/10] qla2xxx: Remove a dead assignment in qla24xx_build_scsi_crc_2_iocbs() Date: Wed, 12 Jun 2013 08:08:42 +0000 Message-ID: References: <51AF37C7.3080808@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_F5D084D6342F9B479C34599BB0A03E4D35391011AVMB1qlogicorg_" Return-path: Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:54767 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754179Ab3FLIIr (ORCPT ); Wed, 12 Jun 2013 04:08:47 -0400 Received: from mail22-ch1 (localhost [127.0.0.1]) by mail22-ch1-R.bigfish.com (Postfix) with ESMTP id C92F5C017B for ; Wed, 12 Jun 2013 08:08:46 +0000 (UTC) Received: from CH1EHSMHS022.bigfish.com (snatpool2.int.messaging.microsoft.com [10.43.68.231]) by mail22-ch1.bigfish.com (Postfix) with ESMTP id 90EAB4C0083 for ; Wed, 12 Jun 2013 08:08:44 +0000 (UTC) In-Reply-To: <51AF37C7.3080808@acm.org> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche , linux-scsi Cc: Chad Dupuis --_000_F5D084D6342F9B479C34599BB0A03E4D35391011AVMB1qlogicorg_ Content-Type: text/plain; charset="us-ascii" Content-ID: <6430D6766C43EF499878375FDDF12A4B@qlogic.com> Content-Transfer-Encoding: quoted-printable Acked-by: Saurav Kashyap >Since the value of cur_seg is not used and since scsi_prot_sglist() >has no side effects it is safe to remove the statement >"cur_seg =3D scsi_prot_sglist(cmd)". Detected by Coverity. > >Signed-off-by: Bart Van Assche >Cc: Chad Dupuis >Cc: Saurav Kashyap >--- > drivers/scsi/qla2xxx/qla_iocb.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_iocb.c >b/drivers/scsi/qla2xxx/qla_iocb.c >index 15e4080..b589d24 100644 >--- a/drivers/scsi/qla2xxx/qla_iocb.c >+++ b/drivers/scsi/qla2xxx/qla_iocb.c >@@ -1189,7 +1189,6 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct >cmd_type_crc_2 *cmd_pkt, > uint32_t *cur_dsd, *fcp_dl; > scsi_qla_host_t *vha; > struct scsi_cmnd *cmd; >- struct scatterlist *cur_seg; > int sgc; > uint32_t total_bytes =3D 0; > uint32_t data_bytes; >@@ -1396,7 +1395,6 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct >cmd_type_crc_2 *cmd_pkt, >=20 > if (bundling && tot_prot_dsds) { > /* Walks dif segments */ >- cur_seg =3D scsi_prot_sglist(cmd); > cmd_pkt->control_flags |=3D > __constant_cpu_to_le16(CF_DIF_SEG_DESCR_ENABLE); > cur_dsd =3D (uint32_t *) &crc_ctx_pkt->u.bundling.dif_address; >--=20 >1.7.10.4 > > --_000_F5D084D6342F9B479C34599BB0A03E4D35391011AVMB1qlogicorg_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IoBhAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAEM1M0I5MkE3 NzZBRDBDNDk4RjJCRTFFRjc0NzQ0RjlFAGMHAQ2ABAACAAAAAgACAAEFgAMADgAAAN0HBgAMAAgA CAAqAAMAMwEBIIADAA4AAADdBwYADAAIAAgAKgADADMBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAFgAAABSZTogW1BBVENIIDA1LzEwXSBxbGEyeHh4OiBSZW1vdmUgYSBk ZWFkIGFzc2lnbm1lbnQgaW4gcWxhMjR4eF9idWlsZF9zY3NpX2NyY18yX2lvY2JzKCkAqR0BA5AG AFQQAAAzAAAAAgF/AAEAAAA8AAAAPEY1RDA4NEQ2MzQyRjlCNDc5QzM0NTk5QkIwQTAzRTREMzUz OTEwMTFAQVZNQjEucWxvZ2ljLm9yZz4ACwAfDgEAAAACAQkQAQAAAGkEAABlBAAA7gcAAExaRnWu 71XgYQAKZmJpZAQAAGNjwHBnMTI1MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBzZXQwIO8HbQKDAFAR TTIKgAa0AoCWfQqACMg7CWIxOQ7AvwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQFsg5QA2Bzom8BgCBF eBHBbhgwXQZSdgSQF7YCEHIAwHR9CFBuGjEQIAXABaAbZGSaIANSIBAiF7JcdgiQ5HdrC4BkNR1T BPAHQA0XcDAKcRfyYmttawZzAZAAICBCTV9C4EVHSU59CvwB8QvxECBBY2sJgC1ieQY6BgEIcGF2 IEthAHNoeWFwIDxzSSJTLmsixEBxCQBnhQ5QLgWgbT5cbAuATmUKgST/Jgg+UwuAY2kZ4HRoGeB2 B0AKUCCXGTAb0AhwXxIAZyAEAOggbm8FQHUSABxgAHCfHGAAkCdCBPAAkF9wA2CadCiAZyXQH2Ao KSambxHQKOIpwQEAIAERBZB0/QQgaQVAKNEjQCywHMAsIP8JcARgGjAncx9hECAHgAIwFSamIihW PSovKGNtwGQpIi4gRBIQLME7HFEiACAIUBoxLRB5LrsmpiaoZxhQIeAZMGYh8+pCH4JWA5FBBBAR wBngtDxiJ8BuIsA10kAA0JRtLgWwZzOnQ2MiIIZDEdAcYER1cHUo0eI8EcFkLmQ4gyQvN7U3Ik8j XznuLT5AJqYgZFMFEBoxcy8wYi89EGEMMnhAED/CX2lvYyJiJJAgfCBBETIgPT5ZMRxwAxAZ4BmU ZCw3QUEBAB5wdECQAIAoLX8rRyamDeABIEFhJGAFQGHuLz8PQBwmpmJFz0bfJsQHHbEQMEIQNWU0 MDgAMC4uYjU4OWSMMjRCEB6gNjQ0Pcn3Ra9JTyamK0/wMmBNf06PSSbEQEBBYDExS+AsyDcgK1MD NiBSwVEikjRAEF9iOKBsZCiAYypCBQBjXzJAg0PAc4hyYl8FQCpzcEMAeR9gcnUs0CamMXFWQHkc cGVVRFZgV6Jwa3SeLD53DIIpMAuAdDNVkJ8vIAyTWdFYkChhZHNC8foqEbBwW1AWEVk7MGNAUu5o GRAqsFp5dhHQXC5W0/8wVDFwHcBaxTGAXCc+YF+L/xiAG6Eq8lrIKJFcLVoRWoZ5XMRnY1wtWg8Y kAGQbN1UkHkQIAQgMEAwZl9aLT5kGIBAcGizXCdSwzM59jZTQ2zANVPPVN9V71b/71gPWRlkXCgw KG5QHcAl0TkosCYmaEIqdFthcykPAzAAAGlqaeMvKiBXfwdAH1A+8HRBKJEu8gQgKv4vYWtp4y/P MNxcLHnEcmReLXFAAiEDYGiQZgtgZ9kEIHw9fB9p419u8EOhnwGQAjBu8DiQb/BvXx5xgDYoQ0Zf REmBoAZTIACBsEVTQ1JfwEVOQUJMRXv/eeW7W2F6gShqNnAQdhAmbwL3LNBuMH1zdUuwdJU5MAaQ fl84QFBQB5Br2E0xJqYx6C43Lh6QLkyXMz0lxQMVQovQAAAAHwBCAAEAAAAeAAAAUwBhAHUAcgBh AHYAIABLAGEAcwBoAHkAYQBwAAAAAAAfAGUAAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgA eQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwBkAAEAAAAKAAAAUwBNAFQAUAAAAAAAAgFB AAEAAAB0AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkA YQBwAAAAUwBNAFQAUAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBj AC4AYwBvAG0AAAAfAAJdAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwA bwBnAGkAYwAuAGMAbwBtAAAAHwDlXwEAAAA8AAAAcwBpAHAAOgBzAGEAdQByAGEAdgAuAGsAYQBz AGgAeQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAaDAEAAAAeAAAAUwBhAHUAcgBhAHYA IABLAGEAcwBoAHkAYQBwAAAAAAAfAB8MAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBh AHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAeDAEAAAAKAAAAUwBNAFQAUAAAAAAAAgEZDAEA AAB0AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkAYQBw AAAAUwBNAFQAUAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4A YwBvAG0AAAAfAAFdAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwAbwBn AGkAYwAuAGMAbwBtAAAAHwD4PwEAAAAeAAAAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkAYQBwAAAA AAAfACNAAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwAbwBnAGkAYwAu AGMAbwBtAAAAHwAiQAEAAAAKAAAAUwBNAFQAUAAAAAAAAgH5PwEAAAB0AAAAAAAAAIErH6S+oxAZ nW4A3QEPVAIAAACAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkAYQBwAAAAUwBNAFQAUAAAAHMAYQB1 AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfAAldAQAAADQA AABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAACwBA OgEAAAAfABoAAQAAABIAAABJAFAATQAuAE4AbwB0AGUAAAAAAAMA8T8JBAAACwBAOgEAAAADAP0/ 5AQAAAIBCzABAAAAEAAAAMU7kqd2rQxJjyvh73R0T54DABcAAQAAAEAAOQAAoV0NRGfOAUAACDD+ XKwNRGfOAQsAAIAIIAYAAAAAAMAAAAAAAABGAAAAABSFAAABAAAAHwAAgIYDAgAAAAAAwAAAAAAA AEYBAAAAHgAAAGEAYwBjAGUAcAB0AGwAYQBuAGcAdQBhAGcAZQAAAAAAAQAAAAwAAABlAG4ALQBV AFMAAAALAACACCAGAAAAAADAAAAAAAAARgAAAAAGhQAAAAAAAB8ANwABAAAAsAAAAFIAZQA6ACAA WwBQAEEAVABDAEgAIAAwADUALwAxADAAXQAgAHEAbABhADIAeAB4AHgAOgAgAFIAZQBtAG8AdgBl ACAAYQAgAGQAZQBhAGQAIABhAHMAcwBpAGcAbgBtAGUAbgB0ACAAaQBuACAAcQBsAGEAMgA0AHgA eABfAGIAdQBpAGwAZABfAHMAYwBzAGkAXwBjAHIAYwBfADIAXwBpAG8AYwBiAHMAKAApAAAAHwA9 AAEAAAAKAAAAUgBlADoAIAAAAAAAAwA2AAAAAAAfAEIQAQAAADYAAAA8ADUAMQBBAEYAMwA3AEMA NwAuADMAMAA4ADAAOAAwADgAQABhAGMAbQAuAG8AcgBnAD4AAAAAAAIBcQABAAAAGwAAAAEBzmHt eL+TFG4lefZBjtENKlGxKm2ZMpXJAAAfAHAAAQAAAKgAAABbAFAAQQBUAEMASAAgADAANQAvADEA MABdACAAcQBsAGEAMgB4AHgAeAA6ACAAUgBlAG0AbwB2AGUAIABhACAAZABlAGEAZAAgAGEAcwBz AGkAZwBuAG0AZQBuAHQAIABpAG4AIABxAGwAYQAyADQAeAB4AF8AYgB1AGkAbABkAF8AcwBjAHMA aQBfAGMAcgBjAF8AMgBfAGkAbwBjAGIAcwAoACkAAAAfADUQAQAAAHgAAAA8AEYANQBEADAAOAA0 AEQANgAzADQAMgBGADkAQgA0ADcAOQBDADMANAA1ADkAOQBCAEIAMABBADAAMwBFADQARAAzADUA MwA5ADEAMAAxADEAQABBAFYATQBCADEALgBxAGwAbwBnAGkAYwAuAG8AcgBnAD4AAAADAN4/n04A AEAABzA+mqcNRGfOAQMAJgAAAAAAAgFHAAEAAAAuAAAAYz1VUzthPSA7cD1RTG9naWM7bD1BVk1C MS0xMzA2MTIwODA4NDJaLTMzNzkwAAAAHwAVEAEAAABYAAAANgA0ADMAMABEADYANwA2ADYAQwA0 ADMARQBGADQAOQA5ADgANwA4ADMANwA1AEYARABEAEYAMQAyAEEANABCAEAAcQBsAG8AZwBpAGMA LgBjAG8AbQAAAAIBFDABAAAADAAAAGQAAADFrCoSQQAAAB8A+j8BAAAAHgAAAFMAYQB1AHIAYQB2 ACAASwBhAHMAaAB5AGEAcAAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAFgAAAHUAcwBlAHIA LQBhAGcAZQBuAHQAAAAAAAEAAABIAAAATQBpAGMAcgBvAHMAbwBmAHQALQBNAGEAYwBPAHUAdABs AG8AbwBrAC8AMQA0AC4AMQAwAC4AMAAuADEAMQAwADMAMQAwAAAAHwAAgB+k6zOoei5Cvnt54amO VLMBAAAAOAAAAEMAbwBuAHYAZQByAHMAYQB0AGkAbwBuAEkAbgBkAGUAeABUAHIAYQBjAGsAaQBu AGcARQB4AAAAAQAAAAYBAABJAEkAPQAwADEAMAAxAEMARQA2ADcANAA0ADAARAAxAEMANwAwAEIA NwA2AEQARQAzADMANABDAEMANABDAEEARABDADUANwA2ADUAOQA2ADcARABBAEIANAAzAEQAOwBT AEIATQBJAEQAPQAyADsAUwAxAD0APAA1ADEAQQBGADMANwBDADcALgAzADAAOAAwADgAMAA4AEAA YQBjAG0ALgBvAHIAZwA+ADsAVgBlAHIAcwBpAG8AbgA9AFYAZQByAHMAaQBvAG4AIAAxADQALgAy ACAAKABCAHUAaQBsAGQAIAAzADEAOAAuADAAKQAsACAAUwB0AGEAZwBlAD0ASAAyAAAAAAADAA00 /T8AAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACAAAAB4AC0AbQBzAC0AaABhAHMALQBhAHQAdABh AGMAaAAAAAEAAAACAAAAAAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACIAAAB4AC0AbwByAGkA ZwBpAG4AYQB0AGkAbgBnAC0AaQBwAAAAAAABAAAAGgAAAFsAMQAwAC4AMwA1AC4ANwAuADQANQBd AAAAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAWAAAAZABpAHMAYwBsAGEAaQBtAGUAcgAAAAAA AQAAAA4AAABiAHkAcABhAHMAcwAAAAAAAUU= --_000_F5D084D6342F9B479C34599BB0A03E4D35391011AVMB1qlogicorg_--