From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saurav Kashyap Subject: Re: [PATCH 06/10] qla2xxx: Remove redundant assignments Date: Wed, 12 Jun 2013 08:09:44 +0000 Message-ID: References: <51AF37EF.8020606@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_F5D084D6342F9B479C34599BB0A03E4D35391030AVMB1qlogicorg_" Return-path: Received: from mail-db8lp0184.outbound.messaging.microsoft.com ([213.199.154.184]:29851 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754179Ab3FLIJ7 (ORCPT ); Wed, 12 Jun 2013 04:09:59 -0400 Received: from mail105-db8 (localhost [127.0.0.1]) by mail105-db8-R.bigfish.com (Postfix) with ESMTP id D9D617E0090 for ; Wed, 12 Jun 2013 08:09:57 +0000 (UTC) Received: from DB8EHSMHS010.bigfish.com (unknown [10.174.8.231]) by mail105-db8.bigfish.com (Postfix) with ESMTP id 0F8C6C80046 for ; Wed, 12 Jun 2013 08:09:55 +0000 (UTC) In-Reply-To: <51AF37EF.8020606@acm.org> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche , linux-scsi Cc: Chad Dupuis --_000_F5D084D6342F9B479C34599BB0A03E4D35391030AVMB1qlogicorg_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Acked-by: Saurav Kashyap >The value of the pointer called "nxt" is not used after the >"nxt =3D qla24xx_copy_eft(ha, nxt)" statement. Hence keep the function >call but remove the assignment. > >Signed-off-by: Bart Van Assche >Cc: Chad Dupuis >Cc: Saurav Kashyap >--- > drivers/scsi/qla2xxx/qla_dbg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_dbg.c >b/drivers/scsi/qla2xxx/qla_dbg.c >index cfa2a20..c612785 100644 >--- a/drivers/scsi/qla2xxx/qla_dbg.c >+++ b/drivers/scsi/qla2xxx/qla_dbg.c >@@ -1468,7 +1468,7 @@ qla25xx_fw_dump(scsi_qla_host_t *vha, int >hardware_locked) >=20 > nxt =3D qla2xxx_copy_queues(ha, nxt); >=20 >- nxt =3D qla24xx_copy_eft(ha, nxt); >+ qla24xx_copy_eft(ha, nxt); >=20 > /* Chain entries -- started with MQ. */ > nxt_chain =3D qla25xx_copy_fce(ha, nxt_chain, &last_chain); >@@ -1787,7 +1787,7 @@ qla81xx_fw_dump(scsi_qla_host_t *vha, int >hardware_locked) >=20 > nxt =3D qla2xxx_copy_queues(ha, nxt); >=20 >- nxt =3D qla24xx_copy_eft(ha, nxt); >+ qla24xx_copy_eft(ha, nxt); >=20 > /* Chain entries -- started with MQ. */ > nxt_chain =3D qla25xx_copy_fce(ha, nxt_chain, &last_chain); >@@ -2289,7 +2289,7 @@ qla83xx_fw_dump(scsi_qla_host_t *vha, int >hardware_locked) > copy_queue: > nxt =3D qla2xxx_copy_queues(ha, nxt); >=20 >- nxt =3D qla24xx_copy_eft(ha, nxt); >+ qla24xx_copy_eft(ha, nxt); >=20 > /* Chain entries -- started with MQ. */ > nxt_chain =3D qla25xx_copy_fce(ha, nxt_chain, &last_chain); >--=20 >1.7.10.4 > > --_000_F5D084D6342F9B479C34599BB0A03E4D35391030AVMB1qlogicorg_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IplDAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAADg3MkIxQURC QzYzMDIwNENBNEYzMDk2Q0ZCRDRBMDk2AEAHAQ2ABAACAAAAAgACAAEFgAMADgAAAN0HBgAMAAgA CQAsAAMANgEBIIADAA4AAADdBwYADAAIAAkALAADADYBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABADgAAABSZTogW1BBVENIIDA2LzEwXSBxbGEyeHh4OiBSZW1vdmUgcmVk dW5kYW50IGFzc2lnbm1lbnRzAMASAQOQBgBgDwAAMwAAAAIBfwABAAAAPAAAADxGNUQwODRENjM0 MkY5QjQ3OUMzNDU5OUJCMEEwM0U0RDM1MzkxMDMwQEFWTUIxLnFsb2dpYy5vcmc+AAsAHw4BAAAA AgEJEAEAAAD1AwAA8QMAAAoJAABMWkZ1zUkQZGEACmZiaWQEAABjY8BwZzEyNTIA/gND8HRleHQB 9wKkA+MCAARjaArAc2V0MCDvB20CgwBQEU0yCoAGtAKAln0KgAjIOwliMTkOwL8JwxZyCjIWcQKA FWIqCbBzCfAEkGF0BbIOUANgc6JvAYAgRXgRwW4YMF0GUnYEkBe2AhByAMB0fQhQbhoxECAFwAWg G2RkmiADUiAQIheyXHYIkOR3awuAZDUdUwTwB0ANF3AwCnEX8mJrbWsGcwGQACAgQk1fQuBFR0lO fQr8AfEL8RAgQWNrCYAtYnkGOgYBCHBhdiBLYQBzaHlhcCA8c0kiUy5rIsRAcQkAZ4UOUC4FoG0+ XGwLgI5lCoEk/yWRPlRoGeB2dgdAClAgGTAcwCbBcD5vC4AbowdAHnAcYCJuiRBAIiAEACBubwVA 9nUSABxgYQGAG7EngSY2ESiyID0gJDBhMjSIeHhfBaBweV8BcdooEdAsKTAQQCko8B9hRxAgB4AC MC4gSAnwY5sZ4CHAZSMQJ4JmdS3QHHRpAiAmNihCIGJ1fwVACXAEYBowJ3MiwACQZ+5uLVMmNiY2 UzERIdEZMKpmIfNCH4JWA5FBBBDTEcAZ4DxiJvBuMOE0QVJAANBtLgWwZzIHQxpjIiBDEdAcYER1 cIp1KRE8EcFkLmQ2498kLzYVIk8jXzhOLTygJjbMIGQFEBoxcy8E8ACQFi8rUiugeD4iX2RiImck kCB8ID9hNiD2Kz/APKoxHHADEBngGZR6ZCyAMykAAIAbgS7xc3goKylBkgEAHnBCJC3uKTGeDeAB ICA8oCRgBUDcYS89bz57JjZiRW9Gf28mYx2xEDAb0GYrcCtwMIouJJA2DpA3ODVAoPEeoDY0NDwp RU9I3yZFnz/BL+BM/04PJmNAQETgwDE0NjgsNz+wUmVLUiErUjUroWZ3PuB1qG1wKFBCXz6yaBkQ 5HRfBUAqdixiJ+EmNskR0WR3CsBlXwkAIbL/Q5cDMFenAZEskislPnErxP5xClAKUEJgLGYWIFeu PMD3WMwrn1rrK1izXQ9eH1gd7C8qNnILgCAtYQiBBCC/TLEfYxxRA/AngAXQUS2Q/CovWC9f8GLT XORTwmAD3RGwZSxWZhQsgCYLYFUx72YjYQhSI0uAN1KjakRTVPw4MVPfVO9V/1cPWB9ZL/9aP1tP XF9f715/dN9172Gvf2K/Y89k32XvZv9oD2kfLXAyMjg5UqKCBWslM79rr2y/bc9u3xvRcdY6fN// cQ9yH3MvdD93z3ZfjW+LD/95j3qfe698v33Pft9/74D7Q0yxJjYxLjcuHpAuH0wXMZ0lVRVCnZAA AAAfAEIAAQAAAB4AAABTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAAAAAB8AZQABAAAANAAA AHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfAGQA AQAAAAoAAABTAE0AVABQAAAAAAACAUEAAQAAAHQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBT AGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAABTAE0AVABQAAAAcwBhAHUAcgBhAHYALgBrAGEA cwBoAHkAYQBwAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AAl0BAAAANAAAAHMAYQB1AHIAYQB2 AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfAOVfAQAAADwAAABzAGkA cAA6AHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAf ABoMAQAAAB4AAABTAGEAdQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAAAAAB8AHwwBAAAANAAAAHMA YQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfAB4MAQAA AAoAAABTAE0AVABQAAAAAAACARkMAQAAAHQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBTAGEA dQByAGEAdgAgAEsAYQBzAGgAeQBhAHAAAABTAE0AVABQAAAAcwBhAHUAcgBhAHYALgBrAGEAcwBo AHkAYQBwAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AAV0BAAAANAAAAHMAYQB1AHIAYQB2AC4A awBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfAPg/AQAAAB4AAABTAGEAdQBy AGEAdgAgAEsAYQBzAGgAeQBhAHAAAAAAAB8AI0ABAAAANAAAAHMAYQB1AHIAYQB2AC4AawBhAHMA aAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfACJAAQAAAAoAAABTAE0AVABQAAAAAAAC Afk/AQAAAHQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBTAGEAdQByAGEAdgAgAEsAYQBzAGgA eQBhAHAAAABTAE0AVABQAAAAcwBhAHUAcgBhAHYALgBrAGEAcwBoAHkAYQBwAEAAcQBsAG8AZwBp AGMALgBjAG8AbQAAAB8ACV0BAAAANAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEA bABvAGcAaQBjAC4AYwBvAG0AAAALAEA6AQAAAB8AGgABAAAAEgAAAEkAUABNAC4ATgBvAHQAZQAA AAAAAwDxPwkEAAALAEA6AQAAAAMA/T/kBAAAAgELMAEAAAAQAAAAhysa28YwIEyk8wls+9SglgMA FwABAAAAQAA5AAAUUjJEZ84BQAAIMP7CtzJEZ84BCwAAgAggBgAAAAAAwAAAAAAAAEYAAAAAFIUA AAEAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAeAAAAYQBjAGMAZQBwAHQAbABhAG4AZwB1AGEA ZwBlAAAAAAABAAAADAAAAGUAbgAtAFUAUwAAAAsAAIAIIAYAAAAAAMAAAAAAAABGAAAAAAaFAAAA AAAAHwA3AAEAAABwAAAAUgBlADoAIABbAFAAQQBUAEMASAAgADAANgAvADEAMABdACAAcQBsAGEA MgB4AHgAeAA6ACAAUgBlAG0AbwB2AGUAIAByAGUAZAB1AG4AZABhAG4AdAAgAGEAcwBzAGkAZwBu AG0AZQBuAHQAcwAAAB8APQABAAAACgAAAFIAZQA6ACAAAAAAAAMANgAAAAAAHwBCEAEAAAA2AAAA PAA1ADEAQQBGADMANwBFAEYALgA4ADAAMgAwADYAMAA2AEAAYQBjAG0ALgBvAHIAZwA+AAAAAAAC AXEAAQAAABsAAAABAc5h7ZBsowjXrpEPRaP1L4M0BH4DmTKWEAAAHwBwAAEAAABoAAAAWwBQAEEA VABDAEgAIAAwADYALwAxADAAXQAgAHEAbABhADIAeAB4AHgAOgAgAFIAZQBtAG8AdgBlACAAcgBl AGQAdQBuAGQAYQBuAHQAIABhAHMAcwBpAGcAbgBtAGUAbgB0AHMAAAAfADUQAQAAAHgAAAA8AEYA NQBEADAAOAA0AEQANgAzADQAMgBGADkAQgA0ADcAOQBDADMANAA1ADkAOQBCAEIAMABBADAAMwBF ADQARAAzADUAMwA5ADEAMAAzADAAQABBAFYATQBCADEALgBxAGwAbwBnAGkAYwAuAG8AcgBnAD4A AAADAN4/n04AAEAABzA+ALMyRGfOAQMAJgAAAAAAAgFHAAEAAAAuAAAAYz1VUzthPSA7cD1RTG9n aWM7bD1BVk1CMS0xMzA2MTIwODA5NDRaLTMzNzkxAAAAHwAVEAEAAABYAAAARABBADIANgBDAEQA MwBDADcAOQA3ADMAMQBCADQANABBADIARAA2AEYAMAA0ADAANABFADQAQwA4ADQAQQAxAEAAcQBs AG8AZwBpAGMALgBjAG8AbQAAAAIBFDABAAAADAAAAH8AAABowbWhQQAAAB8A+j8BAAAAHgAAAFMA YQB1AHIAYQB2ACAASwBhAHMAaAB5AGEAcAAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAFgAA AHUAcwBlAHIALQBhAGcAZQBuAHQAAAAAAAEAAABIAAAATQBpAGMAcgBvAHMAbwBmAHQALQBNAGEA YwBPAHUAdABsAG8AbwBrAC8AMQA0AC4AMQAwAC4AMAAuADEAMQAwADMAMQAwAAAAHwAAgB+k6zOo ei5Cvnt54amOVLMBAAAAOAAAAEMAbwBuAHYAZQByAHMAYQB0AGkAbwBuAEkAbgBkAGUAeABUAHIA YQBjAGsAaQBuAGcARQB4AAAAAQAAAAYBAABJAEkAPQAwADEAMAAxAEMARQA2ADcANAA0ADMAMgBG AEUAOQA3AEMAQwA2ADgAMQA3ADMAQwBCADgANAA1AEIARABBAEUANQBEADUARgAzAEYARQBCADUA RgA5AEYAOwBTAEIATQBJAEQAPQAyADsAUwAxAD0APAA1ADEAQQBGADMANwBFAEYALgA4ADAAMgAw ADYAMAA2AEAAYQBjAG0ALgBvAHIAZwA+ADsAVgBlAHIAcwBpAG8AbgA9AFYAZQByAHMAaQBvAG4A IAAxADQALgAyACAAKABCAHUAaQBsAGQAIAAzADEAOAAuADAAKQAsACAAUwB0AGEAZwBlAD0ASAAy AAAAAAADAA00/T8AAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACAAAAB4AC0AbQBzAC0AaABhAHMA LQBhAHQAdABhAGMAaAAAAAEAAAACAAAAAAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACIAAAB4 AC0AbwByAGkAZwBpAG4AYQB0AGkAbgBnAC0AaQBwAAAAAAABAAAAGgAAAFsAMQAwAC4AMwA1AC4A NwAuADQANQBdAAAAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAWAAAAZABpAHMAYwBsAGEAaQBt AGUAcgAAAAAAAQAAAA4AAABiAHkAcABhAHMAcwAAAAAANhE= --_000_F5D084D6342F9B479C34599BB0A03E4D35391030AVMB1qlogicorg_--