From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saurav Kashyap Subject: Re: [PATCH 08/10] qla2xxx: Fix qla2xxx_check_risc_status() Date: Wed, 12 Jun 2013 08:10:01 +0000 Message-ID: References: <51AF384D.2060209@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_F5D084D6342F9B479C34599BB0A03E4D35391045AVMB1qlogicorg_" Return-path: Received: from mail-db8lp0188.outbound.messaging.microsoft.com ([213.199.154.188]:39544 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755308Ab3FLIKJ (ORCPT ); Wed, 12 Jun 2013 04:10:09 -0400 Received: from mail97-db8 (localhost [127.0.0.1]) by mail97-db8-R.bigfish.com (Postfix) with ESMTP id 797B198006E for ; Wed, 12 Jun 2013 08:10:07 +0000 (UTC) Received: from DB8EHSMHS009.bigfish.com (unknown [10.174.8.241]) by mail97-db8.bigfish.com (Postfix) with ESMTP id 3190C740046 for ; Wed, 12 Jun 2013 08:10:05 +0000 (UTC) In-Reply-To: <51AF384D.2060209@acm.org> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche , linux-scsi Cc: Chad Dupuis --_000_F5D084D6342F9B479C34599BB0A03E4D35391045AVMB1qlogicorg_ Content-Type: text/plain; charset="us-ascii" Content-ID: <5093BFD2D2A24540B91494A075F3E12F@qlogic.com> Content-Transfer-Encoding: quoted-printable Acked-by: Saurav Kashyap >Change the 'rval' variable from QLA_FUNCTION_TIMEOUT into QLA_SUCCESS >before starting a loop that is only executed if rval is initialized >to QLA_SUCCESS. Coverity reported that loop as "dead code". > >Signed-off-by: Bart Van Assche >Cc: Chad Dupuis >Cc: Saurav Kashyap >--- > drivers/scsi/qla2xxx/qla_isr.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/scsi/qla2xxx/qla_isr.c >b/drivers/scsi/qla2xxx/qla_isr.c >index 259d920..bd0e2fa 100644 >--- a/drivers/scsi/qla2xxx/qla_isr.c >+++ b/drivers/scsi/qla2xxx/qla_isr.c >@@ -2495,6 +2495,7 @@ qla2xxx_check_risc_status(scsi_qla_host_t *vha) > if (rval =3D=3D QLA_SUCCESS) > goto next_test; >=20 >+ rval =3D QLA_SUCCESS; > WRT_REG_DWORD(®->iobase_window, 0x0003); > for (cnt =3D 100; (RD_REG_DWORD(®->iobase_window) & BIT_0) =3D=3D 0 &= & > rval =3D=3D QLA_SUCCESS; cnt--) { >--=20 >1.7.10.4 > > --_000_F5D084D6342F9B479C34599BB0A03E4D35391045AVMB1qlogicorg_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IqQeAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAEZDQjFDQzQw NzUzMDE3NDhBMjlDMzUxQTQ1QUY1MTMwAAsHAQ2ABAACAAAAAgACAAEFgAMADgAAAN0HBgAMAAgA CgABAAMADAEBIIADAA4AAADdBwYADAAIAAoAAQADAAwBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABADsAAABSZTogW1BBVENIIDA4LzEwXSBxbGEyeHh4OiBGaXggcWxhMnh4 eF9jaGVja19yaXNjX3N0YXR1cygpAIMTAQOQBgAgDwAAMwAAAAIBfwABAAAAPAAAADxGNUQwODRE NjM0MkY5QjQ3OUMzNDU5OUJCMEEwM0U0RDM1MzkxMDQ1QEFWTUIxLnFsb2dpYy5vcmc+AAsAHw4B AAAAAgEJEAEAAAClAwAAoQMAAA8GAABMWkZ19h+hK2EACmZiaWQEAABjY8BwZzEyNTIA/gND8HRl eHQB9wKkA+MCAARjaArAc2V0MCDvB20CgwBQEU0yCoAGtAKAln0KgAjIOwliMTkOwL8JwxZyCjIW cQKAFWIqCbBzCfAEkGF0BbIOUANgc6JvAYAgRXgRwW4YMF0GUnYEkBe2AhByAMB0fQhQbhoxECAF wAWgG2RkmiADUiAQIheyXHYIkOR3awuAZDUdUwTwB0ANF3AwCnEX8mJrbWsGcwGQACAgQk1fQuBF R0lOfQr8AfEL8RAgQWNrCYAtYnkGOgYBCHBhdiBLYQBzaHlhcCA8c0kiUy5rIsRAcQkAZ4UOUC4F oG0+XGwLgE5lCoEk/yWRPkMZpHSaaBngJxogB0AnICeADwchAmAZ4ByDUUxBXwBGVU5DVElPTgJf KTBNRU9VVCAHC4AYkCijU1VDQ0X0U1MmNmIBEAWwGeAfY6ELgGcgYSAJAG8jEB8nIBiAKfAEIAIg bHkg2xAwBZB1HEIGkCAnci0yzQuAaSwwB0BpegmAJjb5KiwuIAhQGjEvIC2gCXA+cAkRHFEs8yyj IsAgIp0BAGEcYAWgAQAiLiY2cSY2U2lnGFAh4BkwZtUh80IfglYDkUEEEBHAaRngPGIngG4iwDaC QCkA0G0uBbBnNFdDY4ciICaxHGBEdXB1LUHiPBHBZC5kOTMkLzhlNyJPI186ni0+8CY2IGSzBRAa MXMvBPAAkC89wFhhMnhAwEByXwQAchEkkCB8IEGxMSArOz8nQfBmAxAZ4BmUZCwfQeELgBIALCEC ICgrKXcz7g3gASAgPvAkYAVAYf4vP79AyysHRl9HbyZjHbElEDAgDqA5ZBaAMC7ELmIJkGUyZiyA HpF4NjQ0PnlGP0nPJkUrnVBQIEjPTu8mVEBARdDAMjQ5NSw2QgBTU2w3IFMRUYVfNpEhsF8LBRAE 8F8fYXR1cyiVUTJfQQJoGRB0XwVAfCp2EdBEhwMwAZEuQig5LoM9PSpKV1xX82dv/yohGFAQQFbg B5AdAFdoT+YfV/NYhCpKW8lYAldSVARfUiAAX0RXT1JIRCgmCXBnLUswbzJiPFBlXwPwHcBvd4lD kDB4HqAwMylebbsa4VhgYwIwXYEekTtYYEdgAF+PYJspICYfsEmdX3AwZfBY0RIwJiZXbH9BsliP XkEb0AIwPvBl8FyHAAA+h1xXMS43Lh6QPi5NBzPtJVUVQm3gAAAAHwBCAAEAAAAeAAAAUwBhAHUA cgBhAHYAIABLAGEAcwBoAHkAYQBwAAAAAAAfAGUAAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBz AGgAeQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwBkAAEAAAAKAAAAUwBNAFQAUAAAAAAA AgFBAAEAAAB0AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACAUwBhAHUAcgBhAHYAIABLAGEAcwBo AHkAYQBwAAAAUwBNAFQAUAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcA aQBjAC4AYwBvAG0AAAAfAAJdAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABx AGwAbwBnAGkAYwAuAGMAbwBtAAAAHwDlXwEAAAA8AAAAcwBpAHAAOgBzAGEAdQByAGEAdgAuAGsA YQBzAGgAeQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAaDAEAAAAeAAAAUwBhAHUAcgBh AHYAIABLAGEAcwBoAHkAYQBwAAAAAAAfAB8MAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgA eQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAeDAEAAAAKAAAAUwBNAFQAUAAAAAAAAgEZ DAEAAAB0AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkA YQBwAAAAUwBNAFQAUAAAAHMAYQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBj AC4AYwBvAG0AAAAfAAFdAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwA bwBnAGkAYwAuAGMAbwBtAAAAHwD4PwEAAAAeAAAAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkAYQBw AAAAAAAfACNAAQAAADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwAbwBnAGkA YwAuAGMAbwBtAAAAHwAiQAEAAAAKAAAAUwBNAFQAUAAAAAAAAgH5PwEAAAB0AAAAAAAAAIErH6S+ oxAZnW4A3QEPVAIAAACAUwBhAHUAcgBhAHYAIABLAGEAcwBoAHkAYQBwAAAAUwBNAFQAUAAAAHMA YQB1AHIAYQB2AC4AawBhAHMAaAB5AGEAcABAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfAAldAQAA ADQAAABzAGEAdQByAGEAdgAuAGsAYQBzAGgAeQBhAHAAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAA CwBAOgEAAAAfABoAAQAAABIAAABJAFAATQAuAE4AbwB0AGUAAAAAAAMA8T8JBAAACwBAOgEAAAAD AP0/5AQAAAIBCzABAAAAEAAAAPyxzEB1MBdIopw1GkWvUTADABcAAQAAAEAAOQCAEnQ8RGfOAUAA CDC+MY48RGfOAQsAAIAIIAYAAAAAAMAAAAAAAABGAAAAABSFAAABAAAAHwAAgIYDAgAAAAAAwAAA AAAAAEYBAAAAHgAAAGEAYwBjAGUAcAB0AGwAYQBuAGcAdQBhAGcAZQAAAAAAAQAAAAwAAABlAG4A LQBVAFMAAAALAACACCAGAAAAAADAAAAAAAAARgAAAAAGhQAAAAAAAB8ANwABAAAAdgAAAFIAZQA6 ACAAWwBQAEEAVABDAEgAIAAwADgALwAxADAAXQAgAHEAbABhADIAeAB4AHgAOgAgAEYAaQB4ACAA cQBsAGEAMgB4AHgAeABfAGMAaABlAGMAawBfAHIAaQBzAGMAXwBzAHQAYQB0AHUAcwAoACkAAAAA AB8APQABAAAACgAAAFIAZQA6ACAAAAAAAAMANgAAAAAAHwBCEAEAAAA2AAAAPAA1ADEAQQBGADMA OAA0AEQALgAyADAANgAwADIAMAA5AEAAYQBjAG0ALgBvAHIAZwA+AAAAAAACAXEAAQAAABsAAAAB Ac5h7cifum/5L9JpSIJpaZYK4LzdmTKWJIAAHwBwAAEAAABuAAAAWwBQAEEAVABDAEgAIAAwADgA LwAxADAAXQAgAHEAbABhADIAeAB4AHgAOgAgAEYAaQB4ACAAcQBsAGEAMgB4AHgAeABfAGMAaABl AGMAawBfAHIAaQBzAGMAXwBzAHQAYQB0AHUAcwAoACkAAAAAAB8ANRABAAAAeAAAADwARgA1AEQA MAA4ADQARAA2ADMANAAyAEYAOQBCADQANwA5AEMAMwA0ADUAOQA5AEIAQgAwAEEAMAAzAEUANABE ADMANQAzADkAMQAwADQANQBAAEEAVgBNAEIAMQAuAHEAbABvAGcAaQBjAC4AbwByAGcAPgAAAAMA 3j+fTgAAQAAHMP5uiTxEZ84BAwAmAAAAAAACAUcAAQAAAC4AAABjPVVTO2E9IDtwPVFMb2dpYzts PUFWTUIxLTEzMDYxMjA4MTAwMVotMzM3OTMAAAAfABUQAQAAAFgAAAA1ADAAOQAzAEIARgBEADIA RAAyAEEAMgA0ADUANAAwAEIAOQAxADQAOQA0AEEAMAA3ADUARgAzAEUAMQAyAEYAQABxAGwAbwBn AGkAYwAuAGMAbwBtAAAAAgEUMAEAAAAMAAAATgAAAAfLhCtBAAAAHwD6PwEAAAAeAAAAUwBhAHUA cgBhAHYAIABLAGEAcwBoAHkAYQBwAAAAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAWAAAAdQBz AGUAcgAtAGEAZwBlAG4AdAAAAAAAAQAAAEgAAABNAGkAYwByAG8AcwBvAGYAdAAtAE0AYQBjAE8A dQB0AGwAbwBvAGsALwAxADQALgAxADAALgAwAC4AMQAxADAAMwAxADAAAAAfAACAH6TrM6h6LkK+ e3nhqY5UswEAAAA4AAAAQwBvAG4AdgBlAHIAcwBhAHQAaQBvAG4ASQBuAGQAZQB4AFQAcgBhAGMA awBpAG4AZwBFAHgAAAABAAAABgEAAEkASQA9ADAAMQAwADEAQwBFADYANwA0ADQAMwBDAEMANwAx ADYAOQAyAEMAMQBGAEIAQgA4ADkARAA0ADYAOQBEADkARAA5AEMARQBBADUANwBCADYARAAyAEEA QgA7AFMAQgBNAEkARAA9ADIAOwBTADEAPQA8ADUAMQBBAEYAMwA4ADQARAAuADIAMAA2ADAAMgAw ADkAQABhAGMAbQAuAG8AcgBnAD4AOwBWAGUAcgBzAGkAbwBuAD0AVgBlAHIAcwBpAG8AbgAgADEA NAAuADIAIAAoAEIAdQBpAGwAZAAgADMAMQA4AC4AMAApACwAIABTAHQAYQBnAGUAPQBIADIAAAAA AAMADTT9PwAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAIAAAAHgALQBtAHMALQBoAGEAcwAtAGEA dAB0AGEAYwBoAAAAAQAAAAIAAAAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAIgAAAHgALQBv AHIAaQBnAGkAbgBhAHQAaQBuAGcALQBpAHAAAAAAAAEAAAAaAAAAWwAxADAALgAzADUALgA3AC4A NAA1AF0AAAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAABYAAABkAGkAcwBjAGwAYQBpAG0AZQBy AAAAAAABAAAADgAAAGIAeQBwAGEAcwBzAAAAAADV2w== --_000_F5D084D6342F9B479C34599BB0A03E4D35391045AVMB1qlogicorg_--