From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [PATCH v4 2/5] net/e1000: add firmware version get
Date: Thu, 5 Jan 2017 01:50:44 +0000
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC9E2A@SHSMSX101.ccr.corp.intel.com>
References: <1482841816-54143-1-git-send-email-qiming.yang@intel.com>
 <1483531428-14481-1-git-send-email-qiming.yang@intel.com>
 <1483531428-14481-3-git-send-email-qiming.yang@intel.com>
 <cc171fa6-7a8b-6580-b258-92854af6eedf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Zhang, Helin" <helin.zhang@intel.com>, "Horton, Remy"
 <remy.horton@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 8D7FE2BB9
 for <dev@dpdk.org>; Thu,  5 Jan 2017 02:50:56 +0100 (CET)
In-Reply-To: <cc171fa6-7a8b-6580-b258-92854af6eedf@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



-----Original Message-----
From: Yigit, Ferruh=20
Sent: Wednesday, January 4, 2017 10:00 PM
To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
Cc: Zhang, Helin <helin.zhang@intel.com>; Horton, Remy <remy.horton@intel.c=
om>
Subject: Re: [PATCH v4 2/5] net/e1000: add firmware version get

On 1/4/2017 12:03 PM, Qiming Yang wrote:
> This patch adds a new function eth_igb_fw_version_get.
>=20
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
<...>
> =20
>  static void
> +eth_igb_fw_version_get(struct rte_eth_dev *dev, u32 *fw_major, u32 *fw_m=
inor,
> +			u32 *fw_patch, u32 *etrack_id)
> +{
<...>
> +	default:
> +		/* if option rom is valid, display its version too*/
> +		if (fw.or_valid) {
> +			*fw_major =3D fw.eep_major;
> +			*fw_minor =3D fw.eep_minor;
> +			*etrack_id =3D fw.etrack_id;
> +			*fw_patch =3D fw.or_patch;
> +		/* no option rom */
> +		} else {
> +			if (fw.etrack_id !=3D 0X0000) {
> +			*fw_major =3D fw.eep_major;
> +			*fw_minor =3D fw.eep_minor;
> +			*etrack_id =3D fw.etrack_id;

indentation is wrong here. Also it looks like major, minor assignment is co=
mmon and can be moved from if statement.
Qiming: will correct them
> +			} else {
> +			*fw_major =3D fw.eep_major;
> +			*fw_minor =3D fw.eep_minor;
> +			}
> +		}
> +		break;
> +	}
> +}
<...>