From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Qiming" <qiming.yang@intel.com>
Subject: FW:  [PATCH] net/i40e: fix vlan insert code redundance
Date: Mon, 13 Feb 2017 10:09:14 +0000
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDD27C8@SHSMSX101.ccr.corp.intel.com>
References: <1486689994-37746-1-git-send-email-qiming.yang@intel.com>
 <0425f979-8198-4cc8-f70b-f1c9a037fd7f@intel.com>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDD22E0@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id A281E11D4
 for <dev@dpdk.org>; Mon, 13 Feb 2017 11:09:18 +0100 (CET)
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDD22E0@SHSMSX101.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming
> Sent: Friday, February 10, 2017 7:21 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance
>=20
> > On 2/10/2017 1:26 AM, Qiming Yang wrote:
> > > This patch removed useless tx_flags in vlan insertion.
> >
> > Overall this looks good, I wonder what was the initial intention of
> > this code, understanding it helps to figure out if there is a hidden de=
fect.
>=20
> Thank you for your remind. I'll investigate it.

I have aligned with Helin (he contribute these code), and make sure these c=
ode is useless, these code is left by history.

>=20
> >
> > This code not fixes a defect, but improves the code, is there any
> > performance gain with this?
>=20
> I'll do more test and give you a feedback.

According to my test, this code will not bring any obvious performance gain=
, and no lose also.
And as you said this is not a bug fix, should I remove the fix line and mod=
ify the commit log?

>=20
> > If not, I am for deferring this to next release.
> >
> > >
> > > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > >
> > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > ---