Re: [PATCH 01/14] drm/i915: Check for platform specific GPIO config

["Srinivas, Vidya" <vidya.srinivas@intel.com>]

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Monday, January 9, 2017 3:48 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 01/14] drm/i915: Check for platform specific
> GPIO config
> 
> On Mon, 09 Jan 2017, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
> > From: Uma Shankar <uma.shankar@intel.com>
> >
> > Panel GPIO control should be done based on platform. Add a check to
> > restrict VLV and CHT specific GPIO confirguration, so that they dont
> > apply to other platforms.
> 
> There are no code paths that would have
> dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC on platforms other
> than VLV/CVH.
This particular field is by default 0 which triggers a redundant gpio get operation
for BXT. Hence limiting this to BYT/CHT platforms.

Regards
Vidya
> 
> BR,
> Jani.
> 
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dsi.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> > b/drivers/gpu/drm/i915/intel_dsi.c
> > index 16732e7..27d8f95 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > @@ -1560,7 +1560,8 @@ void intel_dsi_init(struct drm_i915_private
> *dev_priv)
> >  	 * In case of BYT with CRC PMIC, we need to use GPIO for
> >  	 * Panel control.
> >  	 */
> > -	if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
> > +	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
> > +		(dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC)) {
> >  		intel_dsi->gpio_panel =
> >  			gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx