From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Srinivas, Vidya" Subject: Re: [PATCH 2/2] drm/i915: Configure SKL+ scaler initial phase correctly Date: Thu, 31 May 2018 04:20:24 +0000 Message-ID: References: <20180521185613.5097-1-ville.syrjala@linux.intel.com> <20180521185613.5097-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23CD16E134 for ; Thu, 31 May 2018 04:20:29 +0000 (UTC) In-Reply-To: <20180521185613.5097-2-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org VGhhbmsgeW91Lg0KUmV2aWV3ZWQtQnk6IFZpZHlhIFNyaW5pdmFzIDx2aWR5YS5zcmluaXZhc0Bp bnRlbC5jb20+DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogVmlsbGUg U3lyamFsYSBbbWFpbHRvOnZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tXQ0KPiBTZW50OiBU dWVzZGF5LCBNYXkgMjIsIDIwMTggMTI6MjYgQU0NCj4gVG86IGludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcNCj4gQ2M6IFNyaW5pdmFzLCBWaWR5YSA8dmlkeWEuc3Jpbml2YXNAaW50ZWwu Y29tPjsgTWFhcnRlbiBMYW5raG9yc3QNCj4gPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIDIvMl0gZHJtL2k5MTU6IENvbmZpZ3VyZSBTS0wrIHNj YWxlciBpbml0aWFsIHBoYXNlIGNvcnJlY3RseQ0KPiANCj4gRnJvbTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4NCj4gDQo+IFNldCB1cCB0aGUgU0tMKyBz Y2FsZXIgaW5pdGlhbCBwaGFzZSByZWdpc3RlcnMgY29ycmVjdGx5LiBPdGhlcndpc2Ugd2Ugc3Rh cnQNCj4gZmV0Y2hpbmcgdGhlIGRhdGEgZnJvbSB0aGUgY2VudGVyIG9mIHRoZSBmaXJzdCBwaXhl bCBpbnN0ZWFkIG9mIHRoZSB0b3AtbGVmdA0KPiBjb3JuZXIsIHdoaWNoIG9idmlvdXNseSB0aGVu IGxlYWRzIHRvIHJpZ2h0L2JvdHRvbSBlZGdlcyByZXBsaWNhdGluZyBkYXRhDQo+IGV4Y2Vzc2l2 ZWx5IGFzIHRoZSBkYXRhIHJ1bnMgb3V0IGhhbGYgYSBwaXhlbCB0b28gc29vbi4NCj4gDQo+IENj OiBWaWR5YSBTcmluaXZhcyA8dmlkeWEuc3Jpbml2YXNAaW50ZWwuY29tPg0KPiBDYzogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4N Cj4gLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgfCAgNCArKysr DQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0MQ0KPiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5oICAgICB8ICAxICsNCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0 ZS5jICB8IDI2ICsrKysrKysrKysrKysrKysrKysrKy0tDQo+ICA0IGZpbGVzIGNoYW5nZWQsIDcw IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmggaW5kZXggMTk2YTBlYjc5MjcyLi4wOTQ1Mjc0MDNlZGUNCj4gMTAwNjQ0DQo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZWcuaA0KPiBAQCAtNjc3NCw2ICs2Nzc0LDEwIEBAIGVudW0gew0KPiAgI2Rl ZmluZSBfUFNfVlBIQVNFXzFCICAgICAgIDB4Njg5ODgNCj4gICNkZWZpbmUgX1BTX1ZQSEFTRV8y QiAgICAgICAweDY4QTg4DQo+ICAjZGVmaW5lIF9QU19WUEhBU0VfMUMgICAgICAgMHg2OTE4OA0K PiArI2RlZmluZSAgUFNfWV9QSEFTRSh4KQkJKCh4KSA8PCAxNikNCj4gKyNkZWZpbmUgIFBTX1VW X1JHQl9QSEFTRSh4KQkoKHgpIDw8IDApDQo+ICsjZGVmaW5lICAgUFNfUEhBU0VfTUFTSwkoMHg3 ZmZmIDw8IDEpIC8qIHUyLjEzICovDQo+ICsjZGVmaW5lICAgUFNfUEhBU0VfVFJJUAkoMSA8PCAw KQ0KPiANCj4gICNkZWZpbmUgX1BTX0hQSEFTRV8xQSAgICAgICAweDY4MTk0DQo+ICAjZGVmaW5l IF9QU19IUEhBU0VfMkEgICAgICAgMHg2ODI5NA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jDQo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jDQo+IGluZGV4IDQyYzFmNGE1NjU1Ni4uMDcxODU2NDRhODhhIDEwMDY0NA0KPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMNCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jDQo+IEBAIC00NzI5LDYgKzQ3MjksMzkgQEAg c3RhdGljIHZvaWQgY3B0X3ZlcmlmeV9tb2Rlc2V0KHN0cnVjdA0KPiBkcm1fZGV2aWNlICpkZXYs IGludCBwaXBlKQ0KPiAgCX0NCj4gIH0NCj4gDQo+ICsvKg0KPiArICogVGhlIGhhcmR3YXJlIHBo YXNlIDAuMCByZWZlcnMgdG8gdGhlIGNlbnRlciBvZiB0aGUgcGl4ZWwuDQo+ICsgKiBXZSB3YW50 IHRvIHN0YXJ0IGZyb20gdGhlIHRvcC9sZWZ0IGVkZ2Ugd2hpY2ggaXMgcGhhc2UNCj4gKyAqIC0w LjUuIFRoYXQgbWF0Y2hlcyBob3cgdGhlIGhhcmR3YXJlIGNhbGN1bGF0ZXMgdGhlIHNjYWxpbmcN Cj4gKyAqIGZhY3RvcnMgKGZyb20gdG9wLWxlZnQgb2YgdGhlIGZpcnN0IHBpeGVsIHRvIGJvdHRv bS1yaWdodA0KPiArICogb2YgdGhlIGxhc3QgcGl4ZWwsIGFzIG9wcG9zZWQgdG8gdGhlIHBpeGVs IGNlbnRlcnMpLg0KPiArICoNCj4gKyAqIEZvciA0OjI6MCBzdWJzYW1wbGVkIGNocm9tYSBwbGFu ZXMgd2Ugb2J2aW91c2x5IGhhdmUgdG8NCj4gKyAqIGFkanVzdCB0aGF0IHNvIHRoYXQgdGhlIGNo cm9tYSBzYW1wbGUgcG9zaXRpb24gbGFuZHMgaW4NCj4gKyAqIHRoZSByaWdodCBzcG90Lg0KPiAr ICoNCj4gKyAqIE5vdGUgdGhhdCBmb3IgcGFja2VkIFlDYkNyIDQ6MjoyIGZvcm1hdHMgdGhlcmUg aXMgbm8gd2F5IHRvDQo+ICsgKiBjb250cm9sIGNocm9tYSBzaXRpbmcuIFRoZSBoYXJkd2FyZSBz aW1wbHkgcmVwbGljYXRlcyB0aGUNCj4gKyAqIGNocm9tYSBzYW1wbGVzIGZvciBib3RoIG9mIHRo ZSBsdW1hIHNhbXBsZXMsIGFuZCB0aHVzIHdlIGRvbid0DQo+ICsgKiBhY3R1YWxseSBnZXQgdGhl IGV4cGVjdGVkIE1QRUcyIGNocm9tYSBzaXRpbmcgY29udmVudGlvbiA6KA0KPiArICogVGhlIHNh bWUgYmVoYXZpb3VyIGlzIG9ic2VydmVkIG9uIHByZS1TS0wgcGxhdGZvcm1zIGFzIHdlbGwuDQo+ ICsgKi8NCj4gK3UxNiBza2xfc2NhbGVyX2NhbGNfcGhhc2UoaW50IHN1YiwgYm9vbCBjaHJvbWFf Y29zaXRlZCkgew0KPiArCWludCBwaGFzZSA9IC0weDgwMDA7DQo+ICsJdTE2IHRyaXAgPSAwOw0K PiArDQo+ICsJaWYgKGNocm9tYV9jb3NpdGVkKQ0KPiArCQlwaGFzZSArPSAoc3ViIC0gMSkgKiAw eDgwMDAgLyBzdWI7DQo+ICsNCj4gKwlpZiAocGhhc2UgPCAwKQ0KPiArCQlwaGFzZSA9IDB4MTAw MDAgKyBwaGFzZTsNCj4gKwllbHNlDQo+ICsJCXRyaXAgPSBQU19QSEFTRV9UUklQOw0KPiArDQo+ ICsJcmV0dXJuICgocGhhc2UgPj4gMikgJiBQU19QSEFTRV9NQVNLKSB8IHRyaXA7IH0NCj4gKw0K PiAgc3RhdGljIGludA0KPiAgc2tsX3VwZGF0ZV9zY2FsZXIoc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUsIGJvb2wgZm9yY2VfZGV0YWNoLA0KPiAgCQkgIHVuc2lnbmVkIGludCBz Y2FsZXJfdXNlciwgaW50ICpzY2FsZXJfaWQsIEBAIC00OTI4LDE0DQo+ICs0OTYxLDIyIEBAIHN0 YXRpYyB2b2lkIHNreWxha2VfcGZpdF9lbmFibGUoc3RydWN0IGludGVsX2NydGMgKmNydGMpDQo+ ICAJCSZjcnRjLT5jb25maWctPnNjYWxlcl9zdGF0ZTsNCj4gDQo+ICAJaWYgKGNydGMtPmNvbmZp Zy0+cGNoX3BmaXQuZW5hYmxlZCkgew0KPiArCQl1MTYgdXZfcmdiX2hwaGFzZSwgdXZfcmdiX3Zw aGFzZTsNCj4gIAkJaW50IGlkOw0KPiANCj4gIAkJaWYgKFdBUk5fT04oY3J0Yy0+Y29uZmlnLT5z Y2FsZXJfc3RhdGUuc2NhbGVyX2lkIDwgMCkpDQo+ICAJCQlyZXR1cm47DQo+IA0KPiArCQl1dl9y Z2JfaHBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEsIGZhbHNlKTsNCj4gKwkJdXZfcmdi X3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7DQo+ICsNCj4gIAkJaWQg PSBzY2FsZXJfc3RhdGUtPnNjYWxlcl9pZDsNCj4gIAkJSTkxNV9XUklURShTS0xfUFNfQ1RSTChw aXBlLCBpZCksIFBTX1NDQUxFUl9FTiB8DQo+ICAJCQlQU19GSUxURVJfTUVESVVNIHwgc2NhbGVy X3N0YXRlLQ0KPiA+c2NhbGVyc1tpZF0ubW9kZSk7DQo+ICsJCUk5MTVfV1JJVEVfRlcoU0tMX1BT X1ZQSEFTRShwaXBlLCBpZCksDQo+ICsJCQkgICAgICBQU19ZX1BIQVNFKDApIHwNCj4gUFNfVVZf UkdCX1BIQVNFKHV2X3JnYl92cGhhc2UpKTsNCj4gKwkJSTkxNV9XUklURV9GVyhTS0xfUFNfSFBI QVNFKHBpcGUsIGlkKSwNCj4gKwkJCSAgICAgIFBTX1lfUEhBU0UoMCkgfA0KPiBQU19VVl9SR0Jf UEhBU0UodXZfcmdiX2hwaGFzZSkpOw0KPiAgCQlJOTE1X1dSSVRFKFNLTF9QU19XSU5fUE9TKHBp cGUsIGlkKSwgY3J0Yy0+Y29uZmlnLQ0KPiA+cGNoX3BmaXQucG9zKTsNCj4gIAkJSTkxNV9XUklU RShTS0xfUFNfV0lOX1NaKHBpcGUsIGlkKSwgY3J0Yy0+Y29uZmlnLQ0KPiA+cGNoX3BmaXQuc2l6 ZSk7DQo+ICAJfQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmgNCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaA0KPiBpbmRleCA0MmE1OWI3 ZmQ3MzYuLjBmMWRiZmNmODUzOCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmgNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgNCj4g QEAgLTE2MjEsNiArMTYyMSw3IEBAIHZvaWQgaW50ZWxfbW9kZV9mcm9tX3BpcGVfY29uZmlnKHN0 cnVjdA0KPiBkcm1fZGlzcGxheV9tb2RlICptb2RlLCAgdm9pZCBpbnRlbF9jcnRjX2FybV9maWZv X3VuZGVycnVuKHN0cnVjdA0KPiBpbnRlbF9jcnRjICpjcnRjLA0KPiAgCQkJCSAgc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOw0KPiANCj4gK3UxNiBza2xfc2NhbGVyX2NhbGNf cGhhc2UoaW50IHN1YiwgYm9vbCBjaHJvbWFfY2VudGVyKTsNCj4gIGludCBza2xfdXBkYXRlX3Nj YWxlcl9jcnRjKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKTsgIGludA0KPiBz a2xfbWF4X3NjYWxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSwNCj4gIAkJICB1aW50MzJfdCBwaXhlbF9mb3JtYXQpOw0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMNCj4gYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYw0KPiBpbmRleCAyMTRjYzczMDY0MmMuLjU4NTIy NDQxMjUzZCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRl LmMNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMNCj4gQEAgLTI4 NCwxMyArMjg0LDM1IEBAIHNrbF91cGRhdGVfcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpwbGFu ZSwNCj4gIAkvKiBwcm9ncmFtIHBsYW5lIHNjYWxlciAqLw0KPiAgCWlmIChwbGFuZV9zdGF0ZS0+ c2NhbGVyX2lkID49IDApIHsNCj4gIAkJaW50IHNjYWxlcl9pZCA9IHBsYW5lX3N0YXRlLT5zY2Fs ZXJfaWQ7DQo+IC0JCWNvbnN0IHN0cnVjdCBpbnRlbF9zY2FsZXIgKnNjYWxlcjsNCj4gKwkJY29u c3Qgc3RydWN0IGludGVsX3NjYWxlciAqc2NhbGVyID0NCj4gKwkJCSZjcnRjX3N0YXRlLT5zY2Fs ZXJfc3RhdGUuc2NhbGVyc1tzY2FsZXJfaWRdOw0KPiArCQl1MTYgeV9ocGhhc2UsIHV2X3JnYl9o cGhhc2U7DQo+ICsJCXUxNiB5X3ZwaGFzZSwgdXZfcmdiX3ZwaGFzZTsNCj4gKw0KPiArCQkvKiBU T0RPOiBoYW5kbGUgc3ViLXBpeGVsIGNvb3JkaW5hdGVzICovDQo+ICsJCWlmIChmYi0+Zm9ybWF0 LT5mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyKSB7DQo+ICsJCQl5X2hwaGFzZSA9IHNrbF9zY2Fs ZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7DQo+ICsJCQl5X3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2Fs Y19waGFzZSgxLCBmYWxzZSk7DQo+ICsNCj4gKwkJCS8qIE1QRUcyIGNocm9tYSBzaXRpbmcgY29u dmVudGlvbiAqLw0KPiArCQkJdXZfcmdiX2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgy LCB0cnVlKTsNCj4gKwkJCXV2X3JnYl92cGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMiwg ZmFsc2UpOw0KPiArCQl9IGVsc2Ugew0KPiArCQkJLyogbm90IHVzZWQgKi8NCj4gKwkJCXlfaHBo YXNlID0gMDsNCj4gKwkJCXlfdnBoYXNlID0gMDsNCj4gDQo+IC0JCXNjYWxlciA9ICZjcnRjX3N0 YXRlLT5zY2FsZXJfc3RhdGUuc2NhbGVyc1tzY2FsZXJfaWRdOw0KPiArCQkJdXZfcmdiX2hwaGFz ZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7DQo+ICsJCQl1dl9yZ2JfdnBoYXNl ID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEsIGZhbHNlKTsNCj4gKwkJfQ0KPiANCj4gIAkJSTkx NV9XUklURV9GVyhTS0xfUFNfQ1RSTChwaXBlLCBzY2FsZXJfaWQpLA0KPiAgCQkJICAgICAgUFNf U0NBTEVSX0VOIHwgUFNfUExBTkVfU0VMKHBsYW5lX2lkKSB8DQo+IHNjYWxlci0+bW9kZSk7DQo+ ICAJCUk5MTVfV1JJVEVfRlcoU0tMX1BTX1BXUl9HQVRFKHBpcGUsIHNjYWxlcl9pZCksIDApOw0K PiArCQlJOTE1X1dSSVRFX0ZXKFNLTF9QU19WUEhBU0UocGlwZSwgc2NhbGVyX2lkKSwNCj4gKwkJ CSAgICAgIFBTX1lfUEhBU0UoeV92cGhhc2UpIHwNCj4gUFNfVVZfUkdCX1BIQVNFKHV2X3JnYl92 cGhhc2UpKTsNCj4gKwkJSTkxNV9XUklURV9GVyhTS0xfUFNfSFBIQVNFKHBpcGUsIHNjYWxlcl9p ZCksDQo+ICsJCQkgICAgICBQU19ZX1BIQVNFKHlfaHBoYXNlKSB8DQo+IFBTX1VWX1JHQl9QSEFT RSh1dl9yZ2JfaHBoYXNlKSk7DQo+ICAJCUk5MTVfV1JJVEVfRlcoU0tMX1BTX1dJTl9QT1MocGlw ZSwgc2NhbGVyX2lkKSwgKGNydGNfeA0KPiA8PCAxNikgfCBjcnRjX3kpOw0KPiAgCQlJOTE1X1dS SVRFX0ZXKFNLTF9QU19XSU5fU1oocGlwZSwgc2NhbGVyX2lkKSwNCj4gIAkJCSAgICAgICgoY3J0 Y193ICsgMSkgPDwgMTYpfChjcnRjX2ggKyAxKSk7DQo+IC0tDQo+IDIuMTYuMQ0KDQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK