Re: [stffrdhrn:starfive-bad-dcache-flush 4/39] drivers/char/hw_random/starfive-vic-rng.c:238:34: warning: unused variable 'vic_rng_dt_ids'

[Huan Feng <huan.feng@starfivetech.com>]

[-- Attachment #1: Type: text/plain, Size: 2763 bytes --]

Hi:
	I can not get the source code from github. 
	Starfive vic gpio and rng hardware is on Starfive vic7100 Soc, which is RISCV ARCH. So maybe they are not used on other Soc or ARCH.
	
	May be the attach patch file is usefull.

-- 

Best Regards,
 
Huan Feng
E-mail: huan.feng(a)starfivetch.com
Mobile.: 18111603721
Address: ChengDu China

On 2021/5/24, 9:00 AM, "kernel test robot" <rong.a.chen@intel.com> wrote:

    tree:   https://github.com/stffrdhrn/linux.git starfive-bad-dcache-flush
    head:   a5c948a9cc2b8944f00056c067fb7bde19b34843
    commit: c9f02856ce72f3de501b56484ecdc71e261fdaa5 [4/39] drivers/hw_random: Add Starfive VIC Random Number Generator driver
    config: x86_64-randconfig-b001-20210522 (attached as .config)
    compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e84a9b9bb3051c35dea993cdad7b3d2575638f85)
    reproduce (this is a W=1 build):
            wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
            chmod +x ~/bin/make.cross
            # install x86_64 cross compiling tool for clang build
            # apt-get install binutils-x86-64-linux-gnu
            # https://github.com/stffrdhrn/linux/commit/c9f02856ce72f3de501b56484ecdc71e261fdaa5
            git remote add stffrdhrn https://github.com/stffrdhrn/linux.git
            git fetch --no-tags stffrdhrn starfive-bad-dcache-flush
            git checkout c9f02856ce72f3de501b56484ecdc71e261fdaa5
            # save the attached .config to linux build tree
            COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    >> drivers/char/hw_random/starfive-vic-rng.c:238:34: warning: unused variable 'vic_rng_dt_ids' [-Wunused-const-variable]
       static const struct of_device_id vic_rng_dt_ids[] = {
                                        ^
       1 warning generated.


    vim +/vic_rng_dt_ids +238 drivers/char/hw_random/starfive-vic-rng.c

    c9f02856ce72f3 Huan Feng 2021-01-08  237  
    c9f02856ce72f3 Huan Feng 2021-01-08 @238  static const struct of_device_id vic_rng_dt_ids[] = {
    c9f02856ce72f3 Huan Feng 2021-01-08  239  	{ .compatible = "starfive,vic-rng" },
    c9f02856ce72f3 Huan Feng 2021-01-08  240  	{ }
    c9f02856ce72f3 Huan Feng 2021-01-08  241  };
    c9f02856ce72f3 Huan Feng 2021-01-08  242  MODULE_DEVICE_TABLE(of, vic_rng_dt_ids);
    c9f02856ce72f3 Huan Feng 2021-01-08  243  

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org


[-- Attachment #2: github_starfive.patch --]
[-- Type: application/octet-stream, Size: 965 bytes --]

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index e517a2f..03036f6 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -337,8 +337,8 @@ config HW_RANDOM_POWERNV

 config HW_RANDOM_STARFIVE_VIC
 	tristate "Starfive VIC Random Number Generator support"
+	depends on SOC_STARFIVE_VIC7100
 	depends on HW_RANDOM
-	default y if SOC_STARFIVE_VIC7100
 	help
 	  This driver provides kernel-side support for the Random Number
 	  Generator hardware found on Starfive VIC SoC.
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 21c611a..ddaf154 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -517,9 +517,9 @@ config GPIO_SIFIVE

 config GPIO_STARFIVE_VIC
 	bool "Starfive VIC GPIO support"
+	depends on SOC_STARFIVE_VIC7100
 	depends on OF_GPIO
 	select GPIOLIB_IRQCHIP
-	default y if SOC_STARFIVE_VIC7100
 	help
 	  Say yes here to support the GPIO device on Starfive VIC SoCs.