From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wodkowski, PawelX" Subject: Re: [PATCH] ixgbe: Fix an unnecessary check in vf rss Date: Thu, 29 Jan 2015 16:13:49 +0000 Message-ID: References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> <1561845.4QtzaTeLCI@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Ouyang, Changchun" , Thomas Monjalon , "Richardson, Bruce" Return-path: In-Reply-To: Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Ouyang, Changchun > Sent: Wednesday, January 28, 2015 2:35 AM > To: Thomas Monjalon > Cc: dev-VfR2kkLFssw@public.gmane.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > Sent: Tuesday, January 27, 2015 8:13 PM > > To: Ouyang, Changchun > > Cc: dev-VfR2kkLFssw@public.gmane.org > > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf r= ss > > > > > To follow up the comments from Wodkowski, PawelX, remove this > > > unnecessary check, as check_mq_mode has already check the queue > > number > > > in device configure stage, if the queue number of vf is not correct, > > > it will return error code and exit, so it doesn't need check again > > > here in device start stage(note: pf_host_configure is called in devic= e start > > stage). > > > > > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > > > > > Signed-off-by: Changchun Ouyang > > > > Suggested-by: Pawel Wodkowski > > Fixes: 42d2f78abcb77 ("configure VF RSS") > > > > Applied > > >=20 > Thanks very much for the applying! >=20 > > Changchun, as you are working on ixgbe, maybe you would like to review > > some ixgbe patches from others? > > >=20 > No problem, I will try to do it when my bandwidth allows me to do it, :-) > Thanks > Changchun Actually I was suggesting exactly opposite direction. Main issue is that th= e sriov field in rte_eth_dev_data is only used by igb and ixgbe drivers. In a= ddition rte_eth_dev_check_mq_mode() is specialized for ixgbe driver. I am thinking about moving sriov from rte_eth_dev_data to driver's private structure or at least move rte_eth_dev_check_mq_mode() to struct eth_dev_op= s as optional driver configuration step. What do you think about both steps? Pawel