From: "Wodkowski, PawelX" <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] Added missing extern 'C' decls in mode4 header files
Date: Fri, 30 Jan 2015 10:56:46 +0000 [thread overview]
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <3047657.sxLCa6eQXg@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Friday, January 30, 2015 11:21 AM
> To: Wodkowski, PawelX
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header
> files
>
> Hi Pawel,
>
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> > lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 8 ++++++++
> > lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h | 8 ++++++++
>
> Why adding extern C in a private header file?
>
> --
> Thomas
To be consistent with rte_eth_bond_private.h where it is included.
--
Pawel
next prev parent reply other threads:[~2015-01-30 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 12:45 [PATCH] Added missing extern 'C' decls in mode4 header files Pawel Wodkowski
[not found] ` <1422362703-18868-1-git-send-email-pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-30 10:20 ` Thomas Monjalon
2015-01-30 10:56 ` Wodkowski, PawelX [this message]
[not found] ` <F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-30 11:42 ` Declan Doherty
[not found] ` <54CB6E1F.6040907-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-30 12:11 ` Wodkowski, PawelX
[not found] ` <F6F2A6264E145F47A18AB6DF8E87425D12B903DC-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-30 12:15 ` Declan Doherty
2015-01-30 13:21 ` [PATCH v2] bond: fix 'extern "C"' " Pawel Wodkowski
[not found] ` <1422624071-12437-1-git-send-email-pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-30 13:35 ` Declan Doherty
[not found] ` <54CB88B8.90602-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-02 11:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com \
--to=pawelx.wodkowski-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.