From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbbBWOaA (ORCPT ); Mon, 23 Feb 2015 09:30:00 -0500 Received: from mga02.intel.com ([134.134.136.20]:54377 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbbBWO37 (ORCPT ); Mon, 23 Feb 2015 09:29:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,631,1418112000"; d="scan'208";a="531454634" From: "Skidmore, Donald C" To: Edward Cree CC: Hiroshi Shimamoto , "vyasevic@redhat.com" , "Kirsher, Jeffrey T" , Alexander Duyck , =?utf-8?B?QmrDuHJuIE1vcms=?= , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma Subject: RE: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Thread-Topic: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Thread-Index: AdBMqJo0/LLpsu2NTFaRZnHct8YppwArslAAAAJM5JAAlJwDgAAPlXhQ Date: Mon, 23 Feb 2015 14:29:43 +0000 Message-ID: References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E38840@BPXM14GP.gisp.nec.co.jp> <54E73BE4.2040505@solarflare.com> <54EB30A1.9080309@solarflare.com> In-Reply-To: <54EB30A1.9080309@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1NEU64d012849 > -----Original Message----- > From: Edward Cree [mailto:ecree@solarflare.com] > Sent: Monday, February 23, 2015 5:53 AM > To: Skidmore, Donald C > Cc: Hiroshi Shimamoto; vyasevic@redhat.com; Kirsher, Jeffrey T; Alexander > Duyck; Bjørn Mork; e1000-devel@lists.sourceforge.net; > netdev@vger.kernel.org; Choi, Sy Jong; linux-kernel@vger.kernel.org; David > Laight; Hayato Momma > Subject: Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control > > On 20/02/15 21:05, Skidmore, Donald C wrote: > > If a vender specific interface is objectionable maybe a simpler and more > generic interface would be for the PF to be able to set a given VF into > "trusted" mode... I admit exactly what 'trusted' meant would vary from > vender to vender, but it would be a way for the driver to know it could allow > configurations such as this. Just an idea, since we seem to be getting more > requests for things such as this. > That's an even worse idea; now you have a generic interface with completely > undefined semantics. > The right way to do this, imho, is to use one of the standard interfaces for > driver-specific gubbins - e.g. sysfs, genetlink or even (whisper it) ioctls - and > put your 'VF promisc mode' setting there. That way you have a vendor- > specific interface with vendor-specified semantics. > Of those options, I'd recommend sysfs as the best fit. > The information contained in this message is confidential and is intended for > the addressee(s) only. If you have received this message in error, please > notify the sender immediately and delete the message. Unless you are an > addressee (or authorized to receive for an addressee), you may not use, > copy or disclose to anyone this message or any information contained in this > message. The unauthorized use, disclosure, copying or alteration of this > message is strictly prohibited. I do see your point, but I thought custom sysfs interfaces (not to even mention new ioctl's :) were frowned upon? Which is why I didn't even consider sysfs as an option. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Skidmore, Donald C" Subject: Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Date: Mon, 23 Feb 2015 14:29:43 +0000 Message-ID: References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E38840@BPXM14GP.gisp.nec.co.jp> <54E73BE4.2040505@solarflare.com> <54EB30A1.9080309@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "vyasevic@redhat.com" , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma , Hiroshi Shimamoto , =?utf-8?B?QmrDuHJuIE1vcms=?= To: Edward Cree Return-path: In-Reply-To: <54EB30A1.9080309@solarflare.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBFZHdhcmQgQ3JlZSBbbWFpbHRv OmVjcmVlQHNvbGFyZmxhcmUuY29tXQ0KPiBTZW50OiBNb25kYXksIEZlYnJ1YXJ5IDIzLCAyMDE1 IDU6NTMgQU0NCj4gVG86IFNraWRtb3JlLCBEb25hbGQgQw0KPiBDYzogSGlyb3NoaSBTaGltYW1v dG87IHZ5YXNldmljQHJlZGhhdC5jb207IEtpcnNoZXIsIEplZmZyZXkgVDsgQWxleGFuZGVyDQo+ IER1eWNrOyBCasO4cm4gTW9yazsgZTEwMDAtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Ow0K PiBuZXRkZXZAdmdlci5rZXJuZWwub3JnOyBDaG9pLCBTeSBKb25nOyBsaW51eC1rZXJuZWxAdmdl ci5rZXJuZWwub3JnOyBEYXZpZA0KPiBMYWlnaHQ7IEhheWF0byBNb21tYQ0KPiBTdWJqZWN0OiBS ZTogW1BBVENIIHYyIDIvM10gaWZfbGluazogQWRkIFZGIG11bHRpY2FzdCBwcm9taXNjdW91cyBj b250cm9sDQo+IA0KPiBPbiAyMC8wMi8xNSAyMTowNSwgU2tpZG1vcmUsIERvbmFsZCBDIHdyb3Rl Og0KPiA+IElmIGEgdmVuZGVyIHNwZWNpZmljIGludGVyZmFjZSBpcyBvYmplY3Rpb25hYmxlIG1h eWJlIGEgc2ltcGxlciBhbmQgbW9yZQ0KPiBnZW5lcmljIGludGVyZmFjZSB3b3VsZCBiZSBmb3Ig dGhlIFBGIHRvIGJlIGFibGUgdG8gc2V0IGEgZ2l2ZW4gVkYgaW50bw0KPiAidHJ1c3RlZCIgbW9k ZS4uLiBJIGFkbWl0IGV4YWN0bHkgd2hhdCAndHJ1c3RlZCcgbWVhbnQgd291bGQgdmFyeSBmcm9t DQo+IHZlbmRlciB0byB2ZW5kZXIsIGJ1dCBpdCB3b3VsZCBiZSBhIHdheSBmb3IgdGhlIGRyaXZl ciB0byBrbm93IGl0IGNvdWxkIGFsbG93DQo+IGNvbmZpZ3VyYXRpb25zIHN1Y2ggYXMgdGhpcy4g IEp1c3QgYW4gaWRlYSwgc2luY2Ugd2Ugc2VlbSB0byBiZSBnZXR0aW5nIG1vcmUNCj4gcmVxdWVz dHMgZm9yIHRoaW5ncyBzdWNoIGFzIHRoaXMuDQo+IFRoYXQncyBhbiBldmVuIHdvcnNlIGlkZWE7 IG5vdyB5b3UgaGF2ZSBhIGdlbmVyaWMgaW50ZXJmYWNlIHdpdGggY29tcGxldGVseQ0KPiB1bmRl ZmluZWQgc2VtYW50aWNzLg0KPiBUaGUgcmlnaHQgd2F5IHRvIGRvIHRoaXMsIGltaG8sIGlzIHRv IHVzZSBvbmUgb2YgdGhlIHN0YW5kYXJkIGludGVyZmFjZXMgZm9yDQo+IGRyaXZlci1zcGVjaWZp YyBndWJiaW5zIC0gZS5nLiBzeXNmcywgZ2VuZXRsaW5rIG9yIGV2ZW4gKHdoaXNwZXIgaXQpIGlv Y3RscyAtIGFuZA0KPiBwdXQgeW91ciAnVkYgcHJvbWlzYyBtb2RlJyBzZXR0aW5nIHRoZXJlLiAg VGhhdCB3YXkgeW91IGhhdmUgYSB2ZW5kb3ItDQo+IHNwZWNpZmljIGludGVyZmFjZSB3aXRoIHZl bmRvci1zcGVjaWZpZWQgc2VtYW50aWNzLg0KPiBPZiB0aG9zZSBvcHRpb25zLCBJJ2QgcmVjb21t ZW5kIHN5c2ZzIGFzIHRoZSBiZXN0IGZpdC4NCj4gVGhlIGluZm9ybWF0aW9uIGNvbnRhaW5lZCBp biB0aGlzIG1lc3NhZ2UgaXMgY29uZmlkZW50aWFsIGFuZCBpcyBpbnRlbmRlZCBmb3INCj4gdGhl IGFkZHJlc3NlZShzKSBvbmx5LiBJZiB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIG1lc3NhZ2UgaW4g ZXJyb3IsIHBsZWFzZQ0KPiBub3RpZnkgdGhlIHNlbmRlciBpbW1lZGlhdGVseSBhbmQgZGVsZXRl IHRoZSBtZXNzYWdlLiBVbmxlc3MgeW91IGFyZSBhbg0KPiBhZGRyZXNzZWUgKG9yIGF1dGhvcml6 ZWQgdG8gcmVjZWl2ZSBmb3IgYW4gYWRkcmVzc2VlKSwgeW91IG1heSBub3QgdXNlLA0KPiBjb3B5 IG9yIGRpc2Nsb3NlIHRvIGFueW9uZSB0aGlzIG1lc3NhZ2Ugb3IgYW55IGluZm9ybWF0aW9uIGNv bnRhaW5lZCBpbiB0aGlzDQo+IG1lc3NhZ2UuIFRoZSB1bmF1dGhvcml6ZWQgdXNlLCBkaXNjbG9z dXJlLCBjb3B5aW5nIG9yIGFsdGVyYXRpb24gb2YgdGhpcw0KPiBtZXNzYWdlIGlzIHN0cmljdGx5 IHByb2hpYml0ZWQuDQoNCkkgZG8gc2VlIHlvdXIgcG9pbnQsIGJ1dCBJIHRob3VnaHQgY3VzdG9t IHN5c2ZzIGludGVyZmFjZXMgKG5vdCB0byBldmVuIG1lbnRpb24gbmV3IGlvY3RsJ3MgOikgd2Vy ZSBmcm93bmVkIHVwb24/ICBXaGljaCBpcyB3aHkgSSBkaWRuJ3QgZXZlbiBjb25zaWRlciBzeXNm cyBhcyBhbiBvcHRpb24uDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KRG93bmxvYWQgQklSVCBpSHVi IEYtVHlwZSAtIFRoZSBGcmVlIEVudGVycHJpc2UtR3JhZGUgQklSVCBTZXJ2ZXIKZnJvbSBBY3R1 YXRlISBJbnN0YW50bHkgU3VwZXJjaGFyZ2UgWW91ciBCdXNpbmVzcyBSZXBvcnRzIGFuZCBEYXNo Ym9hcmRzCndpdGggSW50ZXJhY3Rpdml0eSwgU2hhcmluZywgTmF0aXZlIEV4Y2VsIEV4cG9ydHMs IEFwcCBJbnRlZ3JhdGlvbiAmIG1vcmUKR2V0IHRlY2hub2xvZ3kgcHJldmlvdXNseSByZXNlcnZl ZCBmb3IgYmlsbGlvbi1kb2xsYXIgY29ycG9yYXRpb25zLCBGUkVFCmh0dHA6Ly9wdWJhZHMuZy5k b3VibGVjbGljay5uZXQvZ2FtcGFkL2Nsaz9pZD0xOTA2NDE2MzEmaXU9LzQxNDAvb3N0Zy5jbGt0 cmsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRTEwMDAt ZGV2ZWwgbWFpbGluZyBsaXN0CkUxMDAwLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRw czovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9lMTAwMC1kZXZlbApUbyBs ZWFybiBtb3JlIGFib3V0IEludGVsJiMxNzQ7IEV0aGVybmV0LCB2aXNpdCBodHRwOi8vY29tbXVu aXRpZXMuaW50ZWwuY29tL2NvbW11bml0eS93aXJlZAo=