From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prafulla Wadaskar <prafulla@marvell.com>
Date: Fri, 9 Apr 2010 02:37:40 -0700
Subject: [U-Boot] [PATCH V6 3/3] Add support for the LaCie ED Mini V2
 board
In-Reply-To: <1270801745-18852-3-git-send-email-albert.aribaud@free.fr>
Message-ID: <F766E4F80769BD478052FB6533FA745D187868ACB0@SC-VEXCH4.marvell.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> Sent: Friday, April 09, 2010 1:59 PM
> To: U-Boot at lists.denx.de
> Subject: [U-Boot] [PATCH V6 3/3] Add support for the LaCie ED 
> Mini V2 board
> 
> This patch adds support for the LaCie ED Mini V2 product
> which is based on the Marvell Orion5x SoC.
> ---
>  MAINTAINERS                                |    4 +
>  MAKEALL                                    |    1 +
>  Makefile                                   |    3 +
>  board/LaCie/edminiv2/Makefile              |   58 +++++++++++
>  board/LaCie/edminiv2/board_lowlevel_init.S |   59 +++++++++++
>  board/LaCie/edminiv2/config.mk             |   27 +++++
>  board/LaCie/edminiv2/edminiv2.c            |   93 ++++++++++++++++++
>  board/LaCie/edminiv2/edminiv2.h            |   54 ++++++++++
>  include/configs/edminiv2.h                 |  147 
> ++++++++++++++++++++++++++++
>  9 files changed, 446 insertions(+), 0 deletions(-)
>  create mode 100644 board/LaCie/edminiv2/Makefile
>  create mode 100644 board/LaCie/edminiv2/board_lowlevel_init.S
>  create mode 100644 board/LaCie/edminiv2/config.mk
>  create mode 100644 board/LaCie/edminiv2/edminiv2.c
>  create mode 100644 board/LaCie/edminiv2/edminiv2.h
>  create mode 100644 include/configs/edminiv2.h
> 
..snip..
> diff --git a/board/LaCie/edminiv2/board_lowlevel_init.S 
> b/board/LaCie/edminiv2/board_lowlevel_init.S
> new file mode 100644
> index 0000000..00e68e9
> --- /dev/null
> +++ b/board/LaCie/edminiv2/board_lowlevel_init.S
> @@ -0,0 +1,59 @@
> +/*
> + * Copyright (C) 2010 Albert ARIBAUD <albert.aribaud@free.fr>
> + *
> + * (C) Copyright 2009
> + * Marvell Semiconductor <www.marvell.com>
> + * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#include "edminiv2.h"
> +
> +/*
> + * Low-level init happens right after start.S has switched to SVC32,
> + * flushed and disabled caches and disabled MMU. We're still running
> + * from the boot chip select, so the first thing we should do is set
> + * up RAM for us to relocate into.
> + *
> + * board_low_level_init is called by the Orion5x lowlevel_init code,
> + * and sets up board-specifics such as MPPs and GPIOs.
> + */
> +
> +.globl board_lowlevel_init
> +
> +board_lowlevel_init:
> +
> +	/* Use R3 as the base for Device Bus registers */
> +	add     r3, r4, #0x10000
> +
> +	/* init MPPs */
> +	ldr	r6, =EDMINIV2_MPP0_7
> +	str	r6, [r3, #0x000]
> +	ldr	r6, =EDMINIV2_MPP8_15
> +	str	r6, [r3, #0x004]
> +	ldr	r6, =EDMINIV2_MPP16_23
> +	str	r6, [r3, #0x050]
> +
> +	/* init GPIOs */
> +	ldr	r6, =EDMINIV2_GPIO_OUT_ENABLE
> +	str	r6, [r3, #0x104]
> +
> +	/* Return to lowlevel_init via saved link register */
> +	mov pc, lr

Dear Albert

You are just doing mpp and gpio settings here, those are IO specific only
you can have mpp and gpio configs as in case of Kirkwood (c functions) and call them from your bard_init.
Please remove this file.
and dependency of this code with lowlevel_init.S in patch 1/2

That's it.

Regards..
Prafulla . .