From: Prafulla Wadaskar <prafulla@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/3] orion5x: add ide support for Marvell SATA
Date: Wed, 7 Jul 2010 04:37:01 -0700 [thread overview]
Message-ID: <F766E4F80769BD478052FB6533FA745D19A4A5CFBE@SC-VEXCH4.marvell.com> (raw)
In-Reply-To: <4C3463C7.4050205@free.fr>
> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.aribaud at free.fr]
> Sent: Wednesday, July 07, 2010 4:54 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de
> Subject: Re: [PATCH V2 2/3] orion5x: add ide support for Marvell SATA
>
> Le 07/07/2010 10:25, Prafulla Wadaskar a ?crit :
>
> >> +/* SControl register address */
> >> +#define ORION5X_SATA_PORT1_SCONTROL_REG \
> >> + (ORION5X_SATA_BASE+ORION5X_SATA_PORT1_OFFSET+0x308)
> >
> > Please use c structure for register defination.
>
> Hmm... There is a single register definition here -- I don't
> need more
> than this one. If I do a struct, it will only contain a single field.
> Still want this?
As per strategy and guidelines from Wolfgang- YES.
we need it, I need to correct it for Kirkwood too
Regards..
Prafulla . .
>
> Amicalement,
> --
> Albert.
>
prev parent reply other threads:[~2010-07-07 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 15:59 [U-Boot] [PATCH V2 1/3] ide: add configuration CONFIG_IDE_SWAP_IO Albert Aribaud
2010-07-06 15:59 ` [U-Boot] [PATCH V2 2/3] orion5x: add ide support for Marvell SATA Albert Aribaud
2010-07-06 15:59 ` [U-Boot] [PATCH V2 3/3] edmini: add IDE support Albert Aribaud
2010-07-07 8:38 ` Prafulla Wadaskar
2010-07-07 10:50 ` Albert ARIBAUD
2010-07-07 11:46 ` Prafulla Wadaskar
2010-07-07 14:08 ` Albert ARIBAUD
2010-07-08 6:01 ` Prafulla Wadaskar
2010-07-08 6:11 ` Albert ARIBAUD
2010-07-07 8:25 ` [U-Boot] [PATCH V2 2/3] orion5x: add ide support for Marvell SATA Prafulla Wadaskar
2010-07-07 11:23 ` Albert ARIBAUD
2010-07-07 11:37 ` Prafulla Wadaskar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F766E4F80769BD478052FB6533FA745D19A4A5CFBE@SC-VEXCH4.marvell.com \
--to=prafulla@marvell.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.