From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prafulla Wadaskar Date: Fri, 29 Jul 2011 11:57:46 -0700 Subject: [U-Boot] RFC [PATCH 4/5 v5] dreamplug: initial board support. In-Reply-To: <20110729151831.GP11758@titan.lakedaemon.net> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > -----Original Message----- > From: Jason [mailto:u-boot at lakedaemon.net] > Sent: Friday, July 29, 2011 8:49 PM > To: Prafulla Wadaskar > Cc: clint at debian.org; wd at denx.de; u-boot at lists.denx.de; Prabhanjan > Sarnaik; Ashish Karkare; Siddarth Gore; bdale at gag.com > Subject: Re: RFC [PATCH 4/5 v5] dreamplug: initial board support. > ...snip... > > > > > + > > > > > +/* PHY related */ > > > > > +#define MV88E1121_MAC_CTRL2_REG 21 > > > > > +#define MV88E1121_PGADR_REG 22 > > > > > +#define MV88E1121_RGMII_TXTM_CTRL (1 << 4) > > > > > +#define MV88E1121_RGMII_RXTM_CTRL (1 << 5) > > > > > + > > > > > +#endif /* __DREAMPLUG_H */ > > > > > diff --git a/board/Marvell/dreamplug/kwbimage.cfg > > > > > b/board/Marvell/dreamplug/kwbimage.cfg > > > > > > > > I hope this is not same as guruplug (since you are using same > machine- > > > id)? > > > > > > Very similar, see above. > > > > We can overrule this at this and can go ahead having dreamplug as new > > board support since we have valid machin_id for this board. > > Okay, I'll go dig up the patch for changing mach-types.h and include it > in the next revision. As you said in other email, dreaplug used guruplug machine ID, this is wrong in principle. Changing machin-types.h is strictly not recommended, it will be NACked. So you have two options. 1. go and register new machin-id for dreamplug (if h/w delta is considerably high) 2. don't add dreamplug as separate board support, add it as new version for guruplug. Regards.. Prafulla . .