[U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

From: Prafulla Wadaskar <prafulla@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC Armada100
Date: Wed, 10 Aug 2011 01:22:21 -0700	[thread overview]
Message-ID: <F766E4F80769BD478052FB6533FA745D19FE39F3EE@SC-VEXCH4.marvell.com> (raw)
In-Reply-To: <539775507.72547.1312963608728.JavaMail.root@ahm.einfochips.com>

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Wednesday, August 10, 2011 1:37 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC
> Armada100
> 
> 
> ----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:
> 
> >
> > I suggest below code for this function.
> > {
> >   Const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio register
> > bank offsets */
> >   return (struct gpio_reg *)(ARMD1_GPIO_BASE + offset[bank]);
> > }
> >
> > Again content in this file are SoC core specific and will duplicate
> > for other SoC supports like pantheon.
> >
> > Can you please move them to mvgpio.h within #ifdef
> > CONFIG_SHEEVA_88SV331xV5?
> > I think this should be the final modification for this driver
> > support.
> >
> > Sorry for the rework.
> >
> > Regards..
> > Prafulla . .
> >
> 
> Hi Prafulla,
> 
> Can you please tell me what part of code should be moved to mvgpio.h?

You should move entire contents of gpio.h in mvgpio.h within #ifdef CONFIG_SHEEVA_88SV331xV5, so just mvgpio.c,mvgpio.h,Makefile will add armada100 gpio driver support in more generic way.

> I have no idea about number of banks in other SOCs with same core.

No need to worry, at this moment this driver will be supporting 88SV331xv5 core only.

Regards..
Prafulla . .