From: Prafulla Wadaskar <prafulla@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/20] arm/km: add kmnusa board support
Date: Tue, 12 Jun 2012 02:45:28 -0700 [thread overview]
Message-ID: <F766E4F80769BD478052FB6533FA745D1A2FCAF19B@SC-VEXCH4.marvell.com> (raw)
In-Reply-To: <4FD6FF12.7080902@keymile.com>
> -----Original Message-----
> From: Holger Brunck [mailto:holger.brunck at keymile.com]
> Sent: 12 June 2012 14:04
> To: Prafulla Wadaskar
> Cc: Valentin Longchamp; prafulla at mavell.com; u-boot at lists.denx.de;
> Gerlando Falauto
> Subject: Re: [PATCH 04/20] arm/km: add kmnusa board support
>
> On 06/12/2012 06:39 AM, Prafulla Wadaskar wrote:
...snip...
> >> +
> >> +# End of Header extension
> >
> > Is this configuration similar to any other board already mainlined?
> if there is small delta like RAM/flash sizes then you can manage it
> through board_init()
> >
> > Just think of it.
> >
>
> I would like to keep it as it is.
>
Okay
> >> +DATA 0x0 0x0
> >> diff --git a/board/keymile/km_arm/km_arm.c
> >> b/board/keymile/km_arm/km_arm.c
> >> index e4ae1fb..ffe13cd 100644
> >> --- a/board/keymile/km_arm/km_arm.c
> >> +++ b/board/keymile/km_arm/km_arm.c
> >> @@ -133,10 +133,11 @@ int startup_allowed(void)
> >> }
> >> #endif
> >>
> >> -#if (defined(CONFIG_MGCOGE3UN)|defined(CONFIG_PORTL2))
> >> +#if (defined(CONFIG_MGCOGE3UN)|defined(CONFIG_PORTL2)| \
> >> + defined(CONFIG_KM_PIGGY4_88E6352))
> >> /*
> >> - * These two boards have always ethernet present. Its connected to
> >> the mv
> >> - * switch.
> >> + * All boards with PIGGY4 connected via a simple switch have
> ethernet
> >> always
> >> + * present.
> >> */
> >> int ethernet_present(void)
> >> {
> >> @@ -384,7 +385,7 @@ void reset_phy(void)
> >> /* reset the phy */
> >> miiphy_reset(name, CONFIG_PHY_BASE_ADR);
> >> }
> >> -#else
> >> +#elif !defined(CONFIG_KM_PIGGY4_88E6352)
> >> /* Configure and enable MV88E1118 PHY on the piggy*/
> >> void reset_phy(void)
> >> {
> >> diff --git a/boards.cfg b/boards.cfg
> >> index b711e0d..1a4c2ad 100644
> >> --- a/boards.cfg
> >> +++ b/boards.cfg
> >> @@ -140,6 +140,7 @@ pogo_e02 arm
> arm926ejs
> >> - clouden
> >> dns325 arm arm926ejs -
> >> d-link kirkwood
> >> km_kirkwood arm arm926ejs km_arm
> >> keymile kirkwood km_kirkwood:KM_KIRKWOOD,KM_DISABLE_PCI
> >> km_kirkwood_pci arm arm926ejs km_arm
> >> keymile kirkwood
> km_kirkwood:KM_KIRKWOOD_PCI,KM_RECONFIG_XLX
> >> +kmnusa arm arm926ejs km_arm
> >
> > Why name is not km_nusa?
> >
>
> Could be also km_nusa. But isn't it up to us how we name our boards?
So why your some boards named as kw_xxx and some kmxxx? to me it doesn't sound good.
Anyways the call is yours here.
>
> >> keymile kirkwood km_kirkwood:KM_NUSA
> >> mgcoge3un arm arm926ejs km_arm
> >> keymile kirkwood
> >> portl2 arm arm926ejs km_arm
> >> keymile kirkwood
> >> inetspace_v2 arm arm926ejs netspace_v2
> >> LaCie kirkwood lacie_kw:INETSPACE_V2
> >> diff --git a/include/configs/km/km_arm.h
> b/include/configs/km/km_arm.h
> >> index 28b5021..a35ef61 100644
> >> --- a/include/configs/km/km_arm.h
> >> +++ b/include/configs/km/km_arm.h
> >> @@ -57,6 +57,13 @@
> >> #define CONFIG_CMD_SF
> >> #define CONFIG_SOFT_I2C /* I2C bit-banged */
> >>
> >> +#if defined CONFIG_KM_ENV_IS_IN_SPI_NOR
> >> +#define CONFIG_ENV_SPI_BUS 0
> >> +#define CONFIG_ENV_SPI_CS 0
> >> +#define CONFIG_ENV_SPI_MAX_HZ 5000000
> >> +#define CONFIG_ENV_SPI_MODE SPI_MODE_3
> >> +#endif
> >> +
> >
> > Do you still need this? Your patch 03/20 takes care of this.
> >
>
> Yes we need it. Patch 03/20 makes it possible to overwrite these
> default values.
> And in this patch we use 5MHz as max frequency rather than 50MHz which
> is the
> default setting.
So we can only address delta.
Regards..
Prafulla . . .
next prev parent reply other threads:[~2012-06-12 9:45 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 10:06 [U-Boot] [PATCH 00/20] updates for Keymile Marvell boards Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 01/20] arm/km: enable spi claim bus Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 02/20] arm/km: use correct kw_gpio function for NAND/SPI switching Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-12 8:38 ` Holger Brunck
2012-06-12 9:32 ` Prafulla Wadaskar
2012-06-12 10:29 ` Holger Brunck
2012-06-13 12:16 ` Holger Brunck
2012-06-07 10:06 ` [U-Boot] [PATCH 03/20] arm/kirkwood: protect the ENV_SPI #defines Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 04/20] arm/km: add kmnusa board support Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-12 8:34 ` Holger Brunck
2012-06-12 9:40 ` Prafulla Wadaskar
2012-06-12 10:30 ` Holger Brunck
2012-06-12 9:45 ` Prafulla Wadaskar [this message]
2012-06-12 9:57 ` Prafulla Wadaskar
2012-06-12 10:37 ` Holger Brunck
2012-06-12 11:09 ` Prafulla Wadaskar
2012-06-12 11:43 ` Holger Brunck
2012-06-12 11:50 ` Prafulla Wadaskar
2012-06-12 15:20 ` Holger Brunck
2012-06-07 10:06 ` [U-Boot] [PATCH 05/20] arm/km: add kmcoge5un " Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-07 10:06 ` [U-Boot] [PATCH 06/20] arm/km: convert mgcoge3un target to km_kirkwood Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 07/20] arm/km: remove portl2.h and use km_kirkwood instead Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 08/20] arm/km: correct init of 88e6352 switch in the reset_phy function Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 09/20] arm/km: enable BOCO2 FPGA download support Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 10/20] arm/km: cleanup km_kirkwood boards Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-12 8:15 ` Holger Brunck
2012-06-07 10:06 ` [U-Boot] [PATCH 11/20] arm/km: redefine piggy 4 reg names to avoid conflicts Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 12/20] arm/km: add support for external switch configuration Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-21 13:09 ` [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration Valentin Longchamp
2012-07-03 8:17 ` Prafulla Wadaskar
2012-07-03 9:51 ` Valentin Longchamp
2012-07-04 8:07 ` Detlev Zundel
2012-07-04 9:20 ` Prafulla Wadaskar
2012-07-09 12:04 ` Holger Brunck
2012-07-09 12:31 ` Wolfgang Denk
2012-07-09 12:50 ` Detlev Zundel
2012-07-09 19:29 ` Wolfgang Denk
2012-07-09 13:06 ` Detlev Zundel
2012-07-09 14:44 ` Holger Brunck
2012-07-09 19:44 ` Wolfgang Denk
2012-07-09 19:32 ` Wolfgang Denk
2012-07-16 16:55 ` Detlev Zundel
2012-07-09 20:42 ` Prafulla Wadaskar
2012-07-10 19:33 ` Joe Hershberger
2012-07-09 14:31 ` Detlev Zundel
2012-07-09 14:40 ` Valentin Longchamp
2012-07-10 10:18 ` Prafulla Wadaskar
2012-06-07 10:06 ` [U-Boot] [PATCH 13/20] arm/km: enable external switch configuration for kmnusa Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 14/20] arm/km: skip FPGA config when already configured Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 15/20] arm/km: support the 2 PCIe fpga resets Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 16/20] arm/km: add implementation for read_dip_switch Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 17/20] arm/km: fix testpin detection for kmcoge5un Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 18/20] arm/km: implement weak function board_spi_clam_bus/release Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 19/20] arm/km: remove spi toggle command Valentin Longchamp
2012-06-07 10:07 ` [U-Boot] [PATCH 20/20] arm/km: remove calls to kw_gpio_* in board_early_init_f Valentin Longchamp
2012-06-12 7:58 ` Prafulla Wadaskar
2012-06-12 8:43 ` Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F766E4F80769BD478052FB6533FA745D1A2FCAF19B@SC-VEXCH4.marvell.com \
--to=prafulla@marvell.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.