From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prafulla Wadaskar <prafulla@marvell.com>
Date: Thu, 6 Sep 2012 16:19:16 -0700
Subject: [U-Boot] [PATCH v4 2/3] ARM: add support for Network Space v2
 Lite and Mini
In-Reply-To: <1346964703-4388-3-git-send-email-simon.guinot@sequanux.org>
References: <F766E4F80769BD478052FB6533FA745D235CD64855@SC-VEXCH4.marvell.com>
	<1346964703-4388-1-git-send-email-simon.guinot@sequanux.org>
	<1346964703-4388-3-git-send-email-simon.guinot@sequanux.org>
Message-ID: <F766E4F80769BD478052FB6533FA745D235CD648D3@SC-VEXCH4.marvell.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: Simon Guinot [mailto:simon.guinot at sequanux.org]
> Sent: 06 September 2012 13:52
> To: Prafulla Wadaskar; Albert ARIBAUD
> Cc: u-boot at lists.denx.de; Simon Guinot
> Subject: [PATCH v4 2/3] ARM: add support for Network Space v2 Lite and
> Mini
> 
> This patch adds support for the LaCie boards Network Space v2 (Lite
> and
> Mini). This two boards are derived from the Network Space v2 and a lot
> of hardware caracteristics are shared.
> 
> - CPU: Marvell 88F6192 800Mhz
> - SDRAM memory: 128MB DDR2 200Mhz
> - 1 SATA port: internal
> - Gigabit ethernet: PHY Marvell 88E1318
> - Flash memory: SPI NOR 512KB (Macronix MX25L4005A)
> - i2c EEPROM: 512 bytes (24C04 type)
> - 2 USB2 ports (Lite only): host and host/device
> - 1 push button
> - 1 SATA LED (bi-color, blue and red)
> 
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> ---
> Changes for v4:
>  - Include missing MACH_TYPE_ in configs/lacie_kw.h.
> 
> No changes for v3.
> 
> Changes for v2:
>  - Move mach-types update into a separate patch.
> 
>  board/LaCie/common/common.c               |   36 ++++++-
>  board/LaCie/common/common.h               |    1 +
>  board/LaCie/netspace_v2/kwbimage-ns2l.cfg |  162
> +++++++++++++++++++++++++++++

Hi Simon,

You have added one more cfg file in this patch
Now you have three cfg files in this folder that just diff from each other for DRAM configuration.

Whereas you can delete two of them, use maximum dram setting in cfg file, and then in board specific file you can tune the configuration for required size.

You may look for this optimization.
FYI: pls see the captured log of diff

[prafulla at pe-dt061 u-boot-marvell.git (master)]$ diff board/LaCie/netspace_v2/kwbimage-ns2l.cfg board/LaCie/netspace_v2/kwbimage.cfg
44c44
< DATA 0xFFD01404 0x34143000    # DDR Controller Control Low
---
> DATA 0xFFD01404 0x35143000    # DDR Controller Control Low
72c72
< DATA 0xFFD01410 0x0000DDDD    #  DDR Address Control
---
> DATA 0xFFD01410 0x0000000C    #  DDR Address Control
74c74
< # bit3-2:   10, Cs0size=512Mb
---
> # bit3-2:   11, Cs0size=1Gb
133c133
< DATA 0xFFD01504 0x07FFFFF1    # CS[0]n Size
---
> DATA 0xFFD01504 0x0FFFFFF1    # CS[0]n Size
[prafulla at pe-dt061 u-boot-marvell.git (master)]$ diff board/LaCie/netspace_v2/kwbimage-ns2l.cfg board/LaCie/netspace_v2/kwbimage
kwbimage.cfg       kwbimage-is2.cfg   kwbimage-ns2l.cfg
[prafulla at pe-dt061 u-boot-marvell.git (master)]$ diff board/LaCie/netspace_v2/kwbimage-ns2l.cfg board/LaCie/netspace_v2/kwbimage-is2.cfg
44c44
< DATA 0xFFD01404 0x34143000    # DDR Controller Control Low
---
> DATA 0xFFD01404 0x35143000    # DDR Controller Control Low
72c72
< DATA 0xFFD01410 0x0000DDDD    #  DDR Address Control
---
> DATA 0xFFD01410 0x00000008    #  DDR Address Control
[prafulla at pe-dt061 u-boot-marvell.git (master)]$ diff board/LaCie/netspace_v2/kwbimage-is2.cfg board/LaCie/netspace_v2/kwbimage.cfg
72c72
< DATA 0xFFD01410 0x00000008    #  DDR Address Control
---
> DATA 0xFFD01410 0x0000000C    #  DDR Address Control
74c74
< # bit3-2:   10, Cs0size=512Mb
---
> # bit3-2:   11, Cs0size=1Gb
133c133
< DATA 0xFFD01504 0x07FFFFF1    # CS[0]n Size
---
> DATA 0xFFD01504 0x0FFFFFF1    # CS[0]n Size

Regards...
Prafulla . . .