From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DFBC433E0 for ; Sun, 27 Dec 2020 20:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B86702222B for ; Sun, 27 Dec 2020 20:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726209AbgL0Ug7 convert rfc822-to-8bit (ORCPT ); Sun, 27 Dec 2020 15:36:59 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:34742 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgL0Ug7 (ORCPT ); Sun, 27 Dec 2020 15:36:59 -0500 Received: from marcel-macbook.holtmann.net (p4ff9f924.dip0.t-ipconnect.de [79.249.249.36]) by mail.holtmann.org (Postfix) with ESMTPSA id DB1C8CECDB; Sun, 27 Dec 2020 21:43:36 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH] Fix initializing response id after clearing struct From: Marcel Holtmann In-Reply-To: Date: Sun, 27 Dec 2020 21:36:17 +0100 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: To: Christopher William Snowhill X-Mailer: Apple Mail (2.3654.40.0.2.32) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Christopher, > Looks like this was missed when patching the source to clear the structures throughout, causing this one instance to clear the struct after the response id is assigned. > > This is in regard to Message ID <20200806181714.3216076-1-luiz.dentz@gmail.com>, > subject: [PATCH 1/4] Bluetooth: A2MP: Fix not initializing all members > > I must apologize for not noticing this sooner, as I remember reading the articles linking to this patch several months ago. Either it slipped my mind, or I failed to notice it then. Apparently, nobody else noticed it, either, so I guess it's just not that obvious. > > --- > net/bluetooth/a2mp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel