From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Bluetooth: Remove unnecessary call to hci_update_background_scan
Date: Tue, 10 Nov 2015 18:16:09 +0900 [thread overview]
Message-ID: <F79DFF1E-81FF-4CF2-BCDF-527E9C62FF62@holtmann.org> (raw)
In-Reply-To: <1447141495-31126-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
> The hci_conn_params_clear_all() function is only called from
> hci_unregister_dev() at which point it's completely futile to try to
> do any LE scanning updates. Simply remove this unnecessary function
> call. At the same time we can make the function static since it's only
> accessed from within the same c-file.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> include/net/bluetooth/hci_core.h | 1 -
> net/bluetooth/hci_core.c | 4 +---
> 2 files changed, 1 insertion(+), 4 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2015-11-10 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 7:44 [PATCH v2 1/3] Bluetooth: Remove unnecessary call to hci_update_background_scan Johan Hedberg
2015-11-10 7:44 ` [PATCH v2 2/3] Bluetooth: Move synchronous request handling into hci_request.c Johan Hedberg
2015-11-10 9:16 ` Marcel Holtmann
2015-11-10 7:44 ` [PATCH v2 3/3] Bluetooth: Add 'sync' specifier to synchronous request APIs Johan Hedberg
2015-11-10 9:16 ` Marcel Holtmann
2015-11-10 9:16 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F79DFF1E-81FF-4CF2-BCDF-527E9C62FF62@holtmann.org \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.