From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752696AbdBGIvd convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Feb 2017 03:51:33 -0500
Received: from mail4.hitachi.co.jp ([133.145.228.5]:45590 "EHLO
        mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751094AbdBGIvc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Feb 2017 03:51:32 -0500
From: =?iso-2022-jp?B?GyRCNGQ+Pj8uTU4bKEIgLyBJV0FNQVRTVRskQiEkGyhCTk9CVUhJUk8=?= 
        <nobuhiro.iwamatsu.kw@hitachi.com>
To: Mark Salyzyn <salyzyn@android.com>, Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>, Kees Cook <keescook@chromium.org>,
        "Tony Luck" <tony.luck@intel.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?iso-2022-jp?B?GyRCMCQ4fUA/O0obKEIgLyBBR1VDSEkbJEIhJBsoQlNFSUpJ?= 
        <seiji.aguchi.tr@hitachi.com>,
        Shuah Khan <shuahkh@osg.samsung.com>
Subject: RE: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic
 function
Thread-Topic: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as
 generic function
Thread-Index: AQHSe2Wbosi6SBb1lEqMVAlKZHIFEaFVtWeAgAeRM3A=
Date: Tue, 7 Feb 2017 08:51:28 +0000
Deferred-Delivery: Tue, 7 Feb 2017 08:51:00 +0000
Message-ID: <F89ECF87BC754A49BB74E794F6A0EC2F01089009@GSjpTKYDCembx31.service.hitachi.net>
References: <1485827915-9620-1-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com>
 <1485827915-9620-2-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com>
 <8035b840-8f84-35c4-60e7-5d1c4c8e9b5f@android.com>
In-Reply-To: <8035b840-8f84-35c4-60e7-5d1c4c8e9b5f@android.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.232.28.229]
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-TM-AS-GCONF: 00
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Thanks for your review.

> -----Original Message-----
> From: Mark Salyzyn [mailto:salyzyn@android.com]
> Sent: Friday, February 03, 2017 7:13 AM
> To: 岩松信洋 / IWAMATSU，NOBUHIRO; Anton Vorontsov; Colin Cross; Kees Cook;
> Tony Luck
> Cc: linux-kernel@vger.kernel.org; Hiraku Toyooka; 阿口誠司 / AGUCHI，
> SEIJI; Shuah Khan
> Subject: Re: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic
> function
> 
> On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote:
> > +
> > +	if (zap && *paddr + sz - cxt->phys_addr > cxt->size) {
> > +		dev_err(dev, "no room for %s mem region (0x%zx@0x%llx) in
> (0x%lx@0x%llx)\n",
> > +			name, sz, (unsigned long long)*paddr,
> > +			cxt->size, (unsigned long long)cxt->phys_addr);
> > +		return -ENOMEM;
> > +	}
> > +
> Why not allow this limit check for ramoops_init_prsz call?
> 

This code is controlled by flag of zap.
If zap is false, __ramoops_init_prz() is worked same as original ramoops_init_przs().

Best regards,
  Nobuhiro