From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 6925068
	for <regressions@lists.linux.dev>; Wed, 17 Nov 2021 19:01:19 +0000 (UTC)
Received: from smtpclient.apple (p4fefc15c.dip0.t-ipconnect.de [79.239.193.92])
	by mail.holtmann.org (Postfix) with ESMTPSA id AE6D9CECF6;
	Wed, 17 Nov 2021 20:01:17 +0100 (CET)
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
X-Mailing-List: regressions@lists.linux.dev
List-Id: <regressions.lists.linux.dev>
List-Subscribe: <mailto:regressions+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:regressions+unsubscribe@lists.linux.dev>
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\))
Subject: Re: [PATCHv2] Bluetooth: quirk disabling LE Read Transmit Power
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20211117124717.12352-1-redecorating@protonmail.com>
Date: Wed, 17 Nov 2021 20:01:17 +0100
Cc: regressions@leemhuis.info,
 danielwinkler@google.com,
 gargaditya08@live.com,
 gregkh@linuxfoundation.org,
 Johan Hedberg <johan.hedberg@intel.com>,
 linux-bluetooth@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
 regressions@lists.linux.dev,
 sonnysasaka@chromium.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F8D12EA8-4B37-4887-998E-DC0EBE60E730@holtmann.org>
References: <20211001083412.3078-1-redecorating@protonmail.com>
 <YYePw07y2DzEPSBR@kroah.com>
 <70a875d0-7162-d149-dbc1-c2f5e1a8e701@leemhuis.info>
 <20211116090128.17546-1-redecorating@protonmail.com>
 <e75bf933-9b93-89d2-d73f-f85af65093c8@leemhuis.info>
 <3B8E16FA-97BF-40E5-9149-BBC3E2A245FE@live.com> <YZSuWHB6YCtGclLs@kroah.com>
 <52DEDC31-EEB2-4F39-905F-D5E3F2BBD6C0@live.com>
 <8919a36b-e485-500a-2722-529ffa0d2598@leemhuis.info>
 <20211117124717.12352-1-redecorating@protonmail.com>
To: Orlando Chamberlain <redecorating@protonmail.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)

Hi Orlando,

>> So if this just affects two macs, why can't the fix be realized as a
>> quirk that is only enabled on those two systems? Or are they =
impossible
>> to detect clearly via DMI data or something like that?
>=20
> I think we should be able to quirk based off the acpi _CID =
"apple-uart-blth"
> or _HID "BCM2E7C". Marcel suggested quirking based of the acpi table =
here
> =
https://lore.kernel.org/linux-bluetooth/1D2217A9-EA73-4D93-8D0B-5BC2718D47=
88@holtmann.org/
>=20
> This would catch some unaffected Macs, but they don't support the LE =
Read
> Transmit Power command anyway (the affected macs were released after =
it
> was added to the Bluetooth spec, while the unaffected Macs were =
released
> before it was added to the spec, and thus don't support it).
>=20
> I'm not sure how to go about applying a quirk based off this, there =
are
> quirks in drivers/bluetooth/hci_bcm.c (no_early_set_baudrate and
> drive_rts_on_open), but they don't seem to be based off acpi ids.
>=20
> It might be simpler to make it ignore the Unknown Command error, like
> in this patch =
https://lore.kernel.org/linux-bluetooth/CABBYNZLjSfcG_KqTEbL6NOSvHhA5-b1t_=
S=3D3FQP4=3DGwW21kuzg@mail.gmail.com/
> however that only applies on bluetooth-next and needed the status it
> checks for to be -56, not 0x01.

so we abstain from try-and-error sending of commands. The Bluetooth spec
has a list of supported commands that a host can query for a reason. =
This
is really broken behavior of the controller and needs to be pointed out =
as
such.

The question is just how we quirk it.

Regards

Marcel