From: Marcel Holtmann <marcel@holtmann.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: btrsi: rework dependencies
Date: Thu, 15 Mar 2018 17:03:52 +0100 [thread overview]
Message-ID: <F9369C84-62C6-4881-8089-40F3F912F871@holtmann.org> (raw)
In-Reply-To: <CAK8P3a3y00nUVuYopxXWaJjo_OxXhVsATyiSOfXz5b09JFq2dA@mail.gmail.com>
Hi Arnd,
>>> diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
>>> index 03cfc1b20c4a..9e8d22712ff3 100644
>>> --- a/drivers/bluetooth/Makefile
>>> +++ b/drivers/bluetooth/Makefile
>>> @@ -28,7 +28,7 @@ obj-$(CONFIG_BT_QCA) += btqca.o
>>>
>>> obj-$(CONFIG_BT_HCIUART_NOKIA) += hci_nokia.o
>>>
>>> -obj-$(CONFIG_BT_HCIRSI) += btrsi.o
>>> +obj-$(CONFIG_BT_HCIRSI_MODULE) += btrsi.o
>>
>> do we need this new option? I have avoided these kind of complex things multi config entries. Can we not just select the RSI_91X?
>>
>
> I couldn't come up with a simpler way to do this.
> Selecting RSI_91X is not possible unless we make the BT
> driver 'depend on WLAN_VENDOR_RSI && MAC80211',
> which is even more backwards.
>
> The problem here is that it's actually a reverse dependency:
> the wlan driver calls into the bt driver.
>
> What we could do is to make BT_HCIRSI a silent symbol
> and have that selected by RSI_COEX, which can then
> be user-visible. With that, the Kconfig structure would follow
> what the code does.
that sounds a bit better to me. If the RSI driver maintainers don’t like that, then they should re-architect the code to make this more dynamic and flexible.
Regards
Marcel
prev parent reply other threads:[~2018-03-15 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 15:42 [PATCH] Bluetooth: btrsi: rework dependencies Arnd Bergmann
2018-03-15 15:50 ` Marcel Holtmann
2018-03-15 15:57 ` Arnd Bergmann
2018-03-15 16:03 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9369C84-62C6-4881-8089-40F3F912F871@holtmann.org \
--to=marcel@holtmann.org \
--cc=arnd@arndb.de \
--cc=johan.hedberg@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.