From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wenyou.Yang at microchip.com <Wenyou.Yang@microchip.com>
Date: Fri, 23 Sep 2016 06:01:15 +0000
Subject: [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to
 compile dts
In-Reply-To: <CAPnjgZ2wn1RzihXeUkmhpMyitz69yQs5vvk-7M+YtfpuMyK-8Q@mail.gmail.com>
References: <1474184422-13547-1-git-send-email-wenyou.yang@atmel.com>
 <CAPnjgZ2wn1RzihXeUkmhpMyitz69yQs5vvk-7M+YtfpuMyK-8Q@mail.gmail.com>
Message-ID: <F9F4555C4E01D7469D37975B62D0EFBB3E04AB@CHN-SV-EXMX07.mchp-main.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2016?9?23? 12:17
> To: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Stephen Warren
> <swarren@nvidia.com>; Andreas Bie?mann <andreas@biessmann.org>; Wenyou
> Yang - A41535 <Wenyou.Yang@microchip.com>
> Subject: Re: [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
> 
> Hi,
> 
> On 18 September 2016 at 01:40, Wenyou Yang <wenyou.yang@atmel.com> wrote:
> > To avoid to compile all AT91 SoCs' board dts files, use the board to
> > decide to build its corresponding dts, instead of CONFIG_AT91FAMILY.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> >  arch/arm/dts/Makefile | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> What is the purpose of this? It seems unnecessary to me. Compiling a few
> more .dts files will be quick.

Why we need to compile all AT91FAMILY dts files, not be used for a specific AT91 board?

It is enough to compile the dts file used for the target board. Others is unnecessary.

> 
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> > 223124e..2ac1f20 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -2,10 +2,10 @@
> >  # SPDX-License-Identifier:     GPL-2.0+
> >  #
> >
> > -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> > -       at91sam9g20-taurus.dtb \
> > -       at91sam9g45-corvus.dtb \
> > -       at91sam9g45-gurnard.dtb
> > +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> > +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> > +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> > +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
> >
> >  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
> >  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
> > --
> > 2.7.4
> >
> 
> Regards,
> Simon


Best Regards,
Wenyou Yang