From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbcL1OxW (ORCPT ); Wed, 28 Dec 2016 09:53:22 -0500 Received: from mo4-p04-ob.smtp.rzone.de ([81.169.146.223]:30035 "EHLO mo4-p04-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbcL1OxT (ORCPT ); Wed, 28 Dec 2016 09:53:19 -0500 X-RZG-CLASS-ID: mo04 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKID8wPFGfVQ== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature From: "H. Nikolaus Schaller" In-Reply-To: <20161227215416.GB28140@dtor-ws> Date: Wed, 28 Dec 2016 15:52:48 +0100 Cc: Jonathan Cameron , Jonathan Cameron , Sebastian Reichel , Mark Rutland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Michael Welling , =?utf-8?Q?Mika_Penttil=C3=A4?= , Javier Martinez Canillas , Igor Grinberg , "Andrew F. Davis" , Mark Brown , Rob Herring , Alexander Stein , Eric Engestrom , Hans de Goede , Benjamin Tissoires , Petr Cvek , linux-input@vger.kernel.org, devicetree , LKML , linux-omap , Discussions about the Letux Kernel , linux-iio@vger.kernel.org, kernel@pyra-handheld.com, "Yann E. MORIN" , Linux Kbuild mailing list Message-Id: References: <99f236df48b03b3188e12f94a20097f8440db7a5.1479823354.git.hns@goldelico.com> <811B6F6A-2E3D-45B4-A984-74ABE0E37192@goldelico.com> <8d3fc752-e69c-f568-4f71-4f1768a3fffe@kernel.org> <20161227215416.GB28140@dtor-ws> To: Dmitry Torokhov X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBSErQqN027811 Hi Dmitry, > Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov : > > On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote: >> Hi, >> >> >>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller : >>> >>> Hi Jonathan, >>> >>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron : >>>> >>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote: >>>>> >>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron : >>>>>> >>>>>> >>>>>> >>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" wrote: >> >>> >>>> - hence cc'd Yann and the Kbuild list >>>> to see if they can offer some advices. >> >> no response / advice so far. > > Since you are saying that IIO stuff is optional, add it to Kconfig > explicitly: > > config "TOUCHSCREEN_TSC2007_IIO" > bool "IIO interface for external ADC input and temperature" > depends on TOUCHSCREEN_TSC2007 > depends on IIO=y || IIO=TOUCHSCREEN_TSC2007 > help > ... > > and use this symbols in makefile: > > and in Makefile: > > obj-$(CONFIG_TOUCHSCREEN_TSC2007) += tsc2007.o > tsc2007-y := tsc2007-core.o ... > tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) += tsc2007_iio.o Ah, ok. Well, we tried to make it without an explicit config option but it does not hurt to have one. Your proposal works fine for 3 out of the 4 possible combinations. I think it is unlikely that the combination TOUCHSCREEN_TSC2007=y IIO=m is needed at all (we configure as much as possible as =m in our kernel). Patch v9 will come next (where I have also moved this iio driver patch to be 8/8). BR and thanks, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Nikolaus Schaller" Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature Date: Wed, 28 Dec 2016 15:52:48 +0100 Message-ID: References: <99f236df48b03b3188e12f94a20097f8440db7a5.1479823354.git.hns@goldelico.com> <811B6F6A-2E3D-45B4-A984-74ABE0E37192@goldelico.com> <8d3fc752-e69c-f568-4f71-4f1768a3fffe@kernel.org> <20161227215416.GB28140@dtor-ws> Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20161227215416.GB28140@dtor-ws> Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: Jonathan Cameron , Jonathan Cameron , Sebastian Reichel , Mark Rutland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Michael Welling , =?utf-8?Q?Mika_Penttil=C3=A4?= , Javier Martinez Canillas , Igor Grinberg , "Andrew F. Davis" , Mark Brown , Rob Herring , Alexander Stein , Eric Engestrom , Hans de Goede , Benjamin Tissoires List-Id: devicetree@vger.kernel.org Hi Dmitry, > Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov = : >=20 > On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote: >> Hi, >>=20 >>=20 >>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller = : >>>=20 >>> Hi Jonathan, >>>=20 >>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron : >>>>=20 >>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote: >>>>>=20 >>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron = : >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" = wrote: >>=20 >>>=20 >>>> - hence cc'd Yann and the Kbuild list >>>> to see if they can offer some advices. >>=20 >> no response / advice so far. >=20 > Since you are saying that IIO stuff is optional, add it to Kconfig > explicitly: >=20 > config "TOUCHSCREEN_TSC2007_IIO" > bool "IIO interface for external ADC input and temperature" > depends on TOUCHSCREEN_TSC2007 > depends on IIO=3Dy || IIO=3DTOUCHSCREEN_TSC2007 > help > ... >=20 > and use this symbols in makefile: >=20 > and in Makefile: >=20 > obj-$(CONFIG_TOUCHSCREEN_TSC2007) +=3D tsc2007.o > tsc2007-y :=3D tsc2007-core.o ... > tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) +=3D tsc2007_iio.o Ah, ok. Well, we tried to make it without an explicit config option but it does not hurt to have one. Your proposal works fine for 3 out of the 4 possible combinations. I think it is unlikely that the combination TOUCHSCREEN_TSC2007=3Dy = IIO=3Dm is needed at all (we configure as much as possible as =3Dm in our = kernel). Patch v9 will come next (where I have also moved this iio driver patch to be 8/8). BR and thanks, Nikolaus= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature From: "H. Nikolaus Schaller" In-Reply-To: <20161227215416.GB28140@dtor-ws> Date: Wed, 28 Dec 2016 15:52:48 +0100 Cc: Jonathan Cameron , Jonathan Cameron , Sebastian Reichel , Mark Rutland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Michael Welling , =?utf-8?Q?Mika_Penttil=C3=A4?= , Javier Martinez Canillas , Igor Grinberg , "Andrew F. Davis" , Mark Brown , Rob Herring , Alexander Stein , Eric Engestrom , Hans de Goede , Benjamin Tissoires , Petr Cvek , linux-input@vger.kernel.org, devicetree , LKML , linux-omap , Discussions about the Letux Kernel , linux-iio@vger.kernel.org, kernel@pyra-handheld.com, "Yann E. MORIN" , Linux Kbuild mailing list Message-Id: References: <99f236df48b03b3188e12f94a20097f8440db7a5.1479823354.git.hns@goldelico.com> <811B6F6A-2E3D-45B4-A984-74ABE0E37192@goldelico.com> <8d3fc752-e69c-f568-4f71-4f1768a3fffe@kernel.org> <20161227215416.GB28140@dtor-ws> To: Dmitry Torokhov List-ID: Hi Dmitry, > Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov = : >=20 > On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote: >> Hi, >>=20 >>=20 >>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller = : >>>=20 >>> Hi Jonathan, >>>=20 >>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron : >>>>=20 >>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote: >>>>>=20 >>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron = : >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" = wrote: >>=20 >>>=20 >>>> - hence cc'd Yann and the Kbuild list >>>> to see if they can offer some advices. >>=20 >> no response / advice so far. >=20 > Since you are saying that IIO stuff is optional, add it to Kconfig > explicitly: >=20 > config "TOUCHSCREEN_TSC2007_IIO" > bool "IIO interface for external ADC input and temperature" > depends on TOUCHSCREEN_TSC2007 > depends on IIO=3Dy || IIO=3DTOUCHSCREEN_TSC2007 > help > ... >=20 > and use this symbols in makefile: >=20 > and in Makefile: >=20 > obj-$(CONFIG_TOUCHSCREEN_TSC2007) +=3D tsc2007.o > tsc2007-y :=3D tsc2007-core.o ... > tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) +=3D tsc2007_iio.o Ah, ok. Well, we tried to make it without an explicit config option but it does not hurt to have one. Your proposal works fine for 3 out of the 4 possible combinations. I think it is unlikely that the combination TOUCHSCREEN_TSC2007=3Dy = IIO=3Dm is needed at all (we configure as much as possible as =3Dm in our = kernel). Patch v9 will come next (where I have also moved this iio driver patch to be 8/8). BR and thanks, Nikolaus=