From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Date: Mon, 9 Sep 2013 14:48:08 -0500 Message-ID: References: <1378495943-2572-1-git-send-email-rvaswani@codeaurora.org> <20130906215051.GA29253@quad.lixom.net> <522E09E6.8040300@codeaurora.org> <522E21A8.4060408@wwwdotorg.org> Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: <522E21A8.4060408@wwwdotorg.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Warren Cc: Rohit Vaswani , Olof Johansson , David Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , Daniel Walker , Bryan Huntsman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Sep 9, 2013, at 2:29 PM, Stephen Warren wrote: > On 09/09/2013 01:17 PM, Kumar Gala wrote: >> >> On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote: >> >>> On 9/6/2013 2:50 PM, Olof Johansson wrote: >>>> Hi, >>>> >>>> Some comments below. >>>> >>>> On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: >>>>> This patch adds basic board support for APQ8074 Dragonboard >>>>> >>>>> dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ >>>>> - msm8960-cdp.dtb >>>>> + msm8960-cdp.dtb \ >>>>> + apq8074-dragonboard.dtb >>>> Please add boards alphabetically. >>> Will do. >>>> >>>>> dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ >>>>> armada-370-mirabox.dtb \ >>>>> armada-370-rd.dtb \ >>>>> diff --git a/arch/arm/boot/dts/apq8074-dragonboard.dts b/arch/arm/boot/dts/apq8074-dragonboard.dts >>>>> new file mode 100644 >>>>> index 0000000..5b7b6a0 >>>>> --- /dev/null >>>>> +++ b/arch/arm/boot/dts/apq8074-dragonboard.dts >>>> arch/arm/boot/dts/ is getting really crowded. It's been working best if the SoC >>>> family or vendor is used as a prefix to keep things a bit more organized. In >>>> that spirit, prefixing these with msm- makes sense. Can you please do so? >>> >>> Sure. But the board is called an APQ8074 and we wanted to keep the naming consistent with that. >> >> If we do this we should use qcom, not msm as the prefix. Match the device tree vendor prefix. > > Hmm. It'd be nice for the filenames to be ${soc}-${board} so that e.g. > U-Boot can easily calculate the DTB filename based on its soc/board > environment variables... Luckily in my case for Tegra, all the Tegra > chip names start with "Tegra", so we already sort all our DTB filenames > together in the directory listing:-) u-boot's not supported on MSM platforms, so not sure what purpose this serves. we might want to just introduce vendor dirs so its arch/arm/boot/dts/{vendor}/{soc}-{board} Not sure if we want to argue about {vendor} vs {sub-arch}. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 From: galak@codeaurora.org (Kumar Gala) Date: Mon, 9 Sep 2013 14:48:08 -0500 Subject: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard In-Reply-To: <522E21A8.4060408@wwwdotorg.org> References: <1378495943-2572-1-git-send-email-rvaswani@codeaurora.org> <20130906215051.GA29253@quad.lixom.net> <522E09E6.8040300@codeaurora.org> <522E21A8.4060408@wwwdotorg.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sep 9, 2013, at 2:29 PM, Stephen Warren wrote: > On 09/09/2013 01:17 PM, Kumar Gala wrote: >> >> On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote: >> >>> On 9/6/2013 2:50 PM, Olof Johansson wrote: >>>> Hi, >>>> >>>> Some comments below. >>>> >>>> On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: >>>>> This patch adds basic board support for APQ8074 Dragonboard >>>>> >>>>> dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ >>>>> - msm8960-cdp.dtb >>>>> + msm8960-cdp.dtb \ >>>>> + apq8074-dragonboard.dtb >>>> Please add boards alphabetically. >>> Will do. >>>> >>>>> dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ >>>>> armada-370-mirabox.dtb \ >>>>> armada-370-rd.dtb \ >>>>> diff --git a/arch/arm/boot/dts/apq8074-dragonboard.dts b/arch/arm/boot/dts/apq8074-dragonboard.dts >>>>> new file mode 100644 >>>>> index 0000000..5b7b6a0 >>>>> --- /dev/null >>>>> +++ b/arch/arm/boot/dts/apq8074-dragonboard.dts >>>> arch/arm/boot/dts/ is getting really crowded. It's been working best if the SoC >>>> family or vendor is used as a prefix to keep things a bit more organized. In >>>> that spirit, prefixing these with msm- makes sense. Can you please do so? >>> >>> Sure. But the board is called an APQ8074 and we wanted to keep the naming consistent with that. >> >> If we do this we should use qcom, not msm as the prefix. Match the device tree vendor prefix. > > Hmm. It'd be nice for the filenames to be ${soc}-${board} so that e.g. > U-Boot can easily calculate the DTB filename based on its soc/board > environment variables... Luckily in my case for Tegra, all the Tegra > chip names start with "Tegra", so we already sort all our DTB filenames > together in the directory listing:-) u-boot's not supported on MSM platforms, so not sure what purpose this serves. we might want to just introduce vendor dirs so its arch/arm/boot/dts/{vendor}/{soc}-{board} Not sure if we want to argue about {vendor} vs {sub-arch}. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation