From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by mail.openembedded.org (Postfix) with ESMTP id 3C166731C0 for ; Thu, 7 Jan 2016 16:48:35 +0000 (UTC) Received: by mail-pa0-f44.google.com with SMTP id yy13so170189664pab.3 for ; Thu, 07 Jan 2016 08:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=ZlMmhAc2gl2OonPKa1KL2NcxyFgg0/Zo6vDQ6FOw1eE=; b=V0f7Gw9/HEtAoZj1qfxTDEekvaNI+4NB+AY4oem24FJC2YqaymzpaDDO0O+JaKxmCi 01H7n1BbKqhhH4/UzsrdnhfVepjW/QcZkRWjmYCyTe+DZ6hL7qfh0Ng3r+R0ExQoakXj VP9UR5/jrzLQUgXI4fel8DzKH/EQ9IN1Cmj1Xv3b1c8Xr3kQvYRjTTHXbwkZRKz2P7eA +iRWEvYaJAf0FqMW0HI+sPU+R6I7cMc/iQR6Ec0J8CZ4/8pPeLUDdJvRynyms4EKkReG GyH6UmBScEubwn+8R8Ibck+fOjzvIl7nwxlpdPeDmMNFZ3S3jgcbbxK0eR9EP2D4jgam x4Qg== X-Received: by 10.66.141.41 with SMTP id rl9mr151685178pab.139.1452185316723; Thu, 07 Jan 2016 08:48:36 -0800 (PST) Received: from ?IPv6:2601:646:8802:5d5c:982a:b8a1:a8a1:aeba? ([2601:646:8802:5d5c:982a:b8a1:a8a1:aeba]) by smtp.gmail.com with ESMTPSA id tv6sm105139830pab.4.2016.01.07.08.48.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 07 Jan 2016 08:48:35 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) X-Pgp-Agent: GPGMail 2.6b2 From: Khem Raj In-Reply-To: Date: Thu, 7 Jan 2016 08:48:30 -0800 Message-Id: References: To: "Burton, Ross" X-Mailer: Apple Mail (2.3112) Cc: OE-core Subject: Re: [PATCH 00/17] musl fixes phase 2 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2016 16:48:36 -0000 X-Groupsio-MsgNum: 75581 Content-Type: multipart/signed; boundary="Apple-Mail=_51A45180-E83B-4B1F-93B7-CA3748E29D9A"; protocol="application/pgp-signature"; micalg=pgp-sha1 --Apple-Mail=_51A45180-E83B-4B1F-93B7-CA3748E29D9A Content-Type: multipart/alternative; boundary="Apple-Mail=_8856A6E1-4F98-4FE7-B60E-672782ED2797" --Apple-Mail=_8856A6E1-4F98-4FE7-B60E-672782ED2797 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Ross No worries, I will prepare phase3 today at earliest. Where these will be = addressed along with new fixes. Thanks -Khem > On Jan 7, 2016, at 7:32 AM, Burton, Ross = wrote: >=20 > Hi Khem, >=20 > I just reviewed this series again and there's still some patches that = need tweaking: >=20 > On 19 December 2015 at 23:52, Khem Raj > wrote: > Khem Raj (17): > powertop: Include right headers for timval struct >=20 > Missing Upstream-Status. >=20 > dhcp: Include sys/types.h for u_int* defs >=20 > Missing Upstream-Status. >=20 > blktrace: Include =20 > Missing Upstream-Status (Status doesn't count, there's machinery about = this tag now) >=20 > fts: Add recipe >=20 > Every patch is missing patch explanation / signed-off-by / = upstream-status. >=20 > libcgroup: Add dependency on fts when building on musl >=20 > The U-S is Pending but the commit isn't from you - was this actually a = backport or just a patch that eg buildroot is carrying? >=20 > linux-libc-headers: Port patches for linux-headers for musl >=20 > Patches are missing signed-off-by. >=20 > gdk-pixbuf: Fix latent build issue exposed by musl >=20 > This is a test that uses glibc features, so simply changing it to use = malloc isn't right. This is already fixed upstream properly: = https://git.gnome.org/browse/gdk-pixbuf/commit/tests/pixbuf-lowmem.c?id=3D= 205a3b04e1216c1df199aec95185f7f48b8e0491 = >=20 > The rest are merged into ross/mut so can you please rebase onto that. >=20 > Ross >=20 >=20 --Apple-Mail=_8856A6E1-4F98-4FE7-B60E-672782ED2797 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi Ross

No = worries, I will prepare phase3 today at earliest. Where these will be = addressed along with new fixes.

Thanks
-Khem

On Jan 7, 2016, at 7:32 AM, = Burton, Ross <ross.burton@intel.com> wrote:

Hi Khem,

I = just reviewed this series again and there's still some patches that need = tweaking:

On 19 December 2015 at 23:52, Khem Raj <raj.khem@gmail.com> wrote:
Khem Raj (17):
  powertop: Include right headers for timval struct

Missing Upstream-Status.
 
  dhcp: Include sys/types.h for u_int* defs

Missing Upstream-Status.
 
  blktrace: Include <sys/types.h for dev_t

Missing Upstream-Status (Status doesn't count, there's = machinery about this tag now)
 
  fts: Add recipe

Every patch is missing patch explanation / signed-off-by / = upstream-status.

  libcgroup: Add dependency on fts = when building on musl

The U-S is Pending but the commit isn't = from you - was this actually a backport or just a patch that eg = buildroot is carrying?

  linux-libc-headers: Port patches for linux-headers for musl

Patches are missing signed-off-by.
 
  gdk-pixbuf: Fix latent build  = issue exposed by musl

This is a test that uses glibc = features, so simply changing it to use malloc isn't right.  This is = already fixed upstream properly: https://git.gnome.org/browse/gdk-pixbuf/commit/tests/pixbuf-low= mem.c?id=3D205a3b04e1216c1df199aec95185f7f48b8e0491
 
The rest are merged into ross/mut = so can you please rebase onto that.

Ross



= --Apple-Mail=_8856A6E1-4F98-4FE7-B60E-672782ED2797-- --Apple-Mail=_51A45180-E83B-4B1F-93B7-CA3748E29D9A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iEYEARECAAYFAlaOluIACgkQuwUzVZGdMxS3FgCeM/U2XKgksk13B1y8cdpNWzyg T5IAoJMOQXRB4V7YtGyEcFOPSJx+Wcfp =2u1O -----END PGP SIGNATURE----- --Apple-Mail=_51A45180-E83B-4B1F-93B7-CA3748E29D9A--