All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Alexandre Courbot <gnurou@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	kernel@pyra-handheld.com
Subject: Re: [PATCH v5 4/7] gpio: pca953x: define masks for addressing common and extended registers
Date: Wed, 2 May 2018 14:36:54 +0200	[thread overview]
Message-ID: <FA9DBCAF-2EA5-4317-BBA3-E2D6A9EAC5D4@goldelico.com> (raw)
In-Reply-To: <CAHp75Ve37aARbNZ8qu5W9C-fFG5Kf9GRE_VR4aRLFpX61zviyg@mail.gmail.com>


> Am 02.05.2018 um 14:29 schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:
> 
> On Sat, Apr 28, 2018 at 7:31 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote:
>> These mask bits are to be used to map the extended register
>> addreseses (which are defined for an unsupported 8-bit pcal chip)
>> to 16 and 24 bit chips (pcal6524).
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> drivers/gpio/gpio-pca953x.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
>> index 2b667166e855..fc863faa3ce4 100644
>> --- a/drivers/gpio/gpio-pca953x.c
>> +++ b/drivers/gpio/gpio-pca953x.c
>> @@ -56,6 +56,9 @@
>> #define PCAL6524_DEBOUNCE      0x2d
>> 
>> #define PCA_GPIO_MASK          0x00FF
> 
> + empty line (the above is about contents, not addresses)

ok.

> 
>> +#define PCAL_GPIO_MASK         GENMASK(4, 0)
>> +#define PCAL_PINCTRL_MASK      (~PCAL_GPIO_MASK)
> 
> I'm not sure which would be better here
> 
> 1) to follow existing style
> 0x1F
> 0xE0

I have also thought about this.

> 
> 2) to use GENMASK() in both definitions
> 
> 3) as it in this patch.
> 
> 
> Whatever Linus prefers.

Ok, waiting for his suggestion.

> 
>> +
>> #define PCA_INT                        0x0100
>> #define PCA_PCAL               0x0200
>> #define PCA_LATCH_INT (PCA_PCAL | PCA_INT)
>> --
>> 2.12.2
>> 

BR and thanks,
Nikolaus

  reply	other threads:[~2018-05-02 12:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28 16:31 [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver H. Nikolaus Schaller
2018-04-28 16:31 ` [PATCH v5 1/7] gpio: pca953x: convert register constants to hex H. Nikolaus Schaller
2018-05-16 11:49   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 2/7] gpio: pca953x: add more register definitions for pcal953x H. Nikolaus Schaller
2018-05-16 11:51   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 3/7] gpio: pca953x: add more register definitions for pcal6524 H. Nikolaus Schaller
2018-05-16 11:52   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 4/7] gpio: pca953x: define masks for addressing common and extended registers H. Nikolaus Schaller
2018-05-02 12:29   ` Andy Shevchenko
2018-05-02 12:36     ` H. Nikolaus Schaller [this message]
2018-05-04  7:33       ` H. Nikolaus Schaller
2018-04-28 16:31 ` [PATCH v5 5/7] gpio: pca953x: fix address calculation for pcal6524 H. Nikolaus Schaller
2018-05-02 12:28   ` Andy Shevchenko
2018-05-02 12:35     ` H. Nikolaus Schaller
2018-05-04  7:30       ` H. Nikolaus Schaller
2018-05-05 10:29         ` Andy Shevchenko
2018-04-28 16:31 ` [PATCH v5 6/7] DTS: Bindings: pca953x add an optional vcc-supply property H. Nikolaus Schaller
2018-05-16 11:55   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 7/7] DTS: Bindings: pca953x: add example how to use interrupt-controller and gpio-controller H. Nikolaus Schaller
2018-05-16 11:56   ` Linus Walleij
2018-05-02 11:53 ` [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver Linus Walleij
2018-05-02 12:32 ` Andy Shevchenko
2018-05-16 11:53 ` Linus Walleij
2018-05-16 11:56   ` Linus Walleij
2018-05-16 13:32   ` H. Nikolaus Schaller
2018-05-16 14:31     ` Linus Walleij
2018-05-16 14:37       ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FA9DBCAF-2EA5-4317-BBA3-E2D6A9EAC5D4@goldelico.com \
    --to=hns@goldelico.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.