Re: [PATCH 2/3] fm10k: add MAC filter

["He, Shaopeng" <shaopeng.he@intel.com>]

> -----Original Message-----
> From: Qiu, Michael
> Sent: Wednesday, June 10, 2015 12:00 AM
> To: He, Shaopeng; dev@dpdk.org
> Cc: Chen, Jing D
> Subject: Re: [PATCH 2/3] fm10k: add MAC filter
> 
> On 2015/6/2 10:59, He, Shaopeng wrote:
> > MAC filter function was newly added, each PF and VF can have up to 64
> > MAC addresses. VF filter needs support from PF host, which is not available
> now.
> >
> > Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
> > ---
> >  drivers/net/fm10k/fm10k.h        |  3 +-
> >  drivers/net/fm10k/fm10k_ethdev.c | 90
> > ++++++++++++++++++++++++++++++++++++----
> >  2 files changed, 85 insertions(+), 8 deletions(-)
> 
> ...
> 
> > ;
> > +
> > +	fm10k_mbx_lock(hw);
> > +	i = 0;
> > +	for (j = 0; j < FM10K_VFTA_SIZE; j++) {
> > +		if (macvlan->vfta[j]) {
> > +			for (k = 0; k < FM10K_UINT32_BIT_SIZE; k++) {
> > +				if (macvlan->vfta[j] & (1 << k)) {
> > +					if (i + 1 > macvlan->vlan_num) {
> > +						PMD_INIT_LOG(ERR, "vlan
> number "
> > +								"not match");
> > +						fm10k_mbx_unlock(hw);
> > +						return;
> > +					}
> > +					fm10k_update_uc_addr(hw,
> > +						hw->mac.dglort_map,	mac,
> 
> Here before 'mac', does it has a incident? if no, please ignore, maybe my mail
> client's issue.
> 
> Thanks,
> Michael
Thanks for pointing out, will be fixed in next version