From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Tomsich Subject: Re: [PATCH 00/92] ram: rk3399: Add LPDDR4 support Date: Tue, 11 Jun 2019 17:06:08 +0200 Message-ID: References: <20190611145135.21399-1-jagan@amarulasolutions.com> <349AB0AF-4DEE-4BC8-8FEF-B3DBD34564E4@theobroma-systems.com> Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jagan Teki Cc: YouMin Chen , U-Boot-Denx , Simon Glass , Akash Gajjar , Kever Yang , "open list:ARM/Rockchip SoC..." , linux-amarula List-Id: linux-rockchip.vger.kernel.org Cgo+IE9uIDExLjA2LjIwMTksIGF0IDE3OjAzLCBKYWdhbiBUZWtpIDxqYWdhbkBhbWFydWxhc29s dXRpb25zLmNvbT4gd3JvdGU6Cj4gCj4gT24gVHVlLCBKdW4gMTEsIDIwMTkgYXQgODoyMyBQTSBQ aGlsaXBwIFRvbXNpY2gKPiA8cGhpbGlwcC50b21zaWNoQHRoZW9icm9tYS1zeXN0ZW1zLmNvbT4g d3JvdGU6Cj4+IAo+PiAKPj4gCj4+PiBPbiAxMS4wNi4yMDE5LCBhdCAxNjo1MCwgSmFnYW4gVGVr aSA8amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+IHdyb3RlOgo+Pj4gCj4+PiBZZXMsIGl0IGNh biBiZSBwb3NzaWJsZSB0byBicmVhayB0aGlzIHNlcmllcyBpbnRvIG11bHRpcGxlIHN1YiBzZXJp ZXMKPj4+IGJ1dCBpZGVhIGhlcmUgaXMgdG8gbWFyayBhbGwgdGhlIHJlcXVpcmVkIGNoYW5nZXMg dG8gc3VwcG9ydCBMUEREUjQKPj4+IGluIHJrMzM5OSBpbiBvbmUgc2V0LiBpZiByZXF1aXJlZCB3 ZSBjYW4gYnJlYWsgaXQgZnJvbSBuZXh0IHZlcnNpb25zLgo+Pj4gCj4+PiBUaGlzIGlzIHRoZSBp bml0aWFsIHNldCBmb3Igc3VwcG9ydGluZyBMUEREUjQgd2l0aCBhc3NvY2lhdGVkCj4+PiBmZWF0 dXJlcy4KPj4+IAo+Pj4gVGhhbmtzIHRvCj4+PiAtIFlvdU1pbiBDaGVuCj4+PiAtIEFrYXNoIEdh amphcgo+Pj4gLSBLZXZlciBZYW5nCj4+PiBmb3Igc3VwcG9ydGluZyBhbGwgdGhlIGhlbHAgb24g dGhpcyB3b3JrLgo+Pj4gCj4+PiBPbiBzdW1tYXJ5IHRoaXMgc2VyaWVzIHN1cHBvcnQKPj4+IC0g Q29kZSB3YXJuaW5nIGFuZCBmaXhlcwo+Pj4gLSByYW5rIGRldGVjdGlvbiwgdGhpcyB3b3VsZCBy ZXF1aXJlZCB0byBwcm9iZSBzaW5nbGUgY2hhbm5lbAo+Pj4gc2RyYW0gY29uZmlndXJlZCBpbiBO YW5vUEktTkVPNAo+Pj4gLSBMUEREUjQgc3VwcG9ydCwgdGVzdGVkIGluIFJvY2twcm82NCBhbmQg Um9jay1QSS00Cj4+PiAKPj4+IHBhdGNoIDAwMDEgLSAwMDMzOiBmaXggY29kZSB3YXJuaW5ncywg cHJpbnRzLCBuZXcgbWFjcm9zCj4+PiAKPj4+IHBhdGNoIDAwMzQgLSAwMDUxOiByYW5rIGRldGVj dGlvbiwgc2RyYW0gZGVidWcgY29kZQo+Pj4gCj4+PiBwYXRjaCAwMDUyOiBVc2UgRERSMy0xODAw IG9uIE5hbm9QSS1ORU80Cj4+PiAKPj4+IHBhdGNoIDAwNTMgLSAwMDg5OiBscGRkcjQgc3VwcG9y dAo+Pj4gCj4+PiBwYXRjaCAwMDkwOiBMUEREUjQtMTAwIHRpbWluZ3MKPj4+IAo+Pj4gcGF0Y2gg MDA5MTogVXNlIExQRERSNC0xMDAgb24gUm9ja3BybzY0Cj4+PiAKPj4+IHBhdGNoIDAwOTI6IFVz ZSBMUEREUjQtMTAwIG9uIFJvY2stUEkgNAo+Pj4gCj4+PiBOb3RlOiBQdW1hIHJrMzM5OSBoYXMg U1BMIHNpemUgb3ZlcmZsb3csIGJldHRlciB0byBlbmFibGUgVFBMCj4+PiBmb3IgdGhpcyBib2Fy ZC4KPj4gCj4+IFdlIG5lZWQgdG8ga2VlcCBQdW1hIG9uIGEgU1BMLW9ubHkgY29uZmlndXJhdGlv biBmb3IgdGhlIHRpbWUgYmVpbmcuCj4+IFBsZWFzZSBtYWtlIHN1cmUgdGhhdCB0aGUgTFBERFI0 IGNvZGUgaXMgYW4gb3B0aW9uYWwgZmVhdHVyZSB0aGF0IGRvZXMgbm90Cj4+IGluY3JlYXNlIHRo ZSBEUkFNLWRyaXZlciBzaXplIGZvciBib2FyZHMgdGhhdCBkb27igJl0IG5lZWQvd2FudCBpdC4K PiAKPiBXZSBoYXZlIGZldyBib2FyZHMgZG8gaGF2ZSBUUEwtcnVubmFibGUsIHdvdWxkIGJlIGFu eSB0ZWNobmljYWwgaXNzdWUKPiB0byBzd2l0Y2ggcHVtYSB0byBUUEw/IGJlY2F1c2Ugd2UgaGF2 ZSBscGRkcjQgY29kZSBwYXJ0IG9mIGV4aXN0aW5nCj4gZHJpdmVyIGl0c2VsZiBhbmQgaXQgcmVx dWlyZSBleHRyYSBpZmRlZiB0byBjb25zaWRlciB3aGljaCBpbmRlZWQgbG9vawo+IGF3ZnVsIGZy b20gY29kZSBwb2ludC1vZi12aWV3LgoKT3VyIHNlY3VyZSBib290IHByb2Nlc3MgKGkuZS4gc2ln bmluZyB0b29scykgY3VycmVudGx5IGRlcGVuZHMgb24gdGhpcyBhbmQKdGhlIGNoYW5nZW92ZXIg d29u4oCZdCBiZSBxdWlja+KApgoKVGhhbmtzLApQaGlsaXBwLgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Tomsich Date: Tue, 11 Jun 2019 17:06:08 +0200 Subject: [U-Boot] [PATCH 00/92] ram: rk3399: Add LPDDR4 support In-Reply-To: References: <20190611145135.21399-1-jagan@amarulasolutions.com> <349AB0AF-4DEE-4BC8-8FEF-B3DBD34564E4@theobroma-systems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de > On 11.06.2019, at 17:03, Jagan Teki wrote: > > On Tue, Jun 11, 2019 at 8:23 PM Philipp Tomsich > wrote: >> >> >> >>> On 11.06.2019, at 16:50, Jagan Teki wrote: >>> >>> Yes, it can be possible to break this series into multiple sub series >>> but idea here is to mark all the required changes to support LPDDR4 >>> in rk3399 in one set. if required we can break it from next versions. >>> >>> This is the initial set for supporting LPDDR4 with associated >>> features. >>> >>> Thanks to >>> - YouMin Chen >>> - Akash Gajjar >>> - Kever Yang >>> for supporting all the help on this work. >>> >>> On summary this series support >>> - Code warning and fixes >>> - rank detection, this would required to probe single channel >>> sdram configured in NanoPI-NEO4 >>> - LPDDR4 support, tested in Rockpro64 and Rock-PI-4 >>> >>> patch 0001 - 0033: fix code warnings, prints, new macros >>> >>> patch 0034 - 0051: rank detection, sdram debug code >>> >>> patch 0052: Use DDR3-1800 on NanoPI-NEO4 >>> >>> patch 0053 - 0089: lpddr4 support >>> >>> patch 0090: LPDDR4-100 timings >>> >>> patch 0091: Use LPDDR4-100 on Rockpro64 >>> >>> patch 0092: Use LPDDR4-100 on Rock-PI 4 >>> >>> Note: Puma rk3399 has SPL size overflow, better to enable TPL >>> for this board. >> >> We need to keep Puma on a SPL-only configuration for the time being. >> Please make sure that the LPDDR4 code is an optional feature that does not >> increase the DRAM-driver size for boards that don’t need/want it. > > We have few boards do have TPL-runnable, would be any technical issue > to switch puma to TPL? because we have lpddr4 code part of existing > driver itself and it require extra ifdef to consider which indeed look > awful from code point-of-view. Our secure boot process (i.e. signing tools) currently depends on this and the changeover won’t be quick… Thanks, Philipp.