All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"i.maximets@samsung.com" <i.maximets@samsung.com>,
	"Liu, Changpeng" <changpeng.liu@intel.com>,
	"Bie, Tiwei" <tiwei.bie@intel.com>
Subject: Re: [PATCH v3 0/2] vhost: Support external backend only vhost-user requests
Date: Wed, 20 Mar 2019 14:32:29 +0000	[thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8462ED7D6@HASMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <2c534558-7e69-fcd6-f477-1da6b021bcb2@redhat.com>


> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Wednesday, March 20, 2019 8:35 AM
> To: dev@dpdk.org; i.maximets@samsung.com; Liu, Changpeng
> <changpeng.liu@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>; Stojaczyk,
> Dariusz <dariusz.stojaczyk@intel.com>
> Subject: Re: [PATCH v3 0/2] vhost: Support external backend only vhost-user
> requests
> 
> 
> 
> On 3/19/19 11:54 AM, Maxime Coquelin wrote:
> > The goals of this series is to provide more flexibility to external
> > backends to implement their specific vhost-user request handling
> > without having to patch vhost-user library.
> >
> > First patch implements a new API for external backend to advertize
> > its specific protocol features to vhost-user master.
> >
> > Second patch ensures a request not handled by the vhost-user library
> > but by the external backend only will not be treated as an error or
> > make the vhost lib to crash.
> >
> > Changes in v3:
> > ==============
> >   - Fix and improve comments (Ilya)
> >
> > Changes in v2:
> > ==============
> >   - Remove 'skip_master' param from documentation (Ilya)
> >   - Merge pre and post callback in a single one (Ilya)
> >
> > Changes in v1:
> > ==============
> >   - Convert vhost-crypto to the API change (Ilya)
> >   - Fix build with recent GCC (fall-through)
> >   - Check request > VHOST_USER_NONE (Ilya)
> >   - Remove 'Requested invalid message type' check (Ilya)
> >
> > Changes in RFC v2:
> > ==================
> >   - Fix build & git message
> >   - Add new enum for not handled messages & remove skip_master (Ilya)
> >
> > Maxime Coquelin (2):
> >    vhost: add API to set protocol features flags
> >    vhost: support requests only handled by external backend
> >
> >   lib/librte_vhost/rte_vhost.h           | 53 +++++++++--------
> >   lib/librte_vhost/rte_vhost_version.map |  1 +
> >   lib/librte_vhost/socket.c              | 14 +++++
> >   lib/librte_vhost/vhost_crypto.c        | 10 +++-
> >   lib/librte_vhost/vhost_user.c          | 82 ++++++++++++++++----------
> >   5 files changed, 102 insertions(+), 58 deletions(-)
> >
> 
> Applied to dpdk-next-virtio/master branch.
> 
> Thanks,
> Maxime

Thanks Maxime,

FYI - SPDK vhost in the upstream SPDK master is already capable of running against rte_vhost with those changes.
I have just run the full SPDK test suite against today's dpdk-next-virtio and everything's working. 

Thanks again!
D.

  reply	other threads:[~2019-03-20 14:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 10:54 [PATCH v3 0/2] vhost: Support external backend only vhost-user requests Maxime Coquelin
2019-03-19 10:54 ` [PATCH v3 1/2] vhost: add API to set protocol features flags Maxime Coquelin
2019-03-19 10:54 ` [PATCH v3 2/2] vhost: support requests only handled by external backend Maxime Coquelin
2019-03-20  4:54   ` Tiwei Bie
2019-03-20  7:34 ` [PATCH v3 0/2] vhost: Support external backend only vhost-user requests Maxime Coquelin
2019-03-20 14:32   ` Stojaczyk, Dariusz [this message]
2019-03-21  9:21     ` Maxime Coquelin
2019-03-22 10:29       ` Zhang, Roy Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8462ED7D6@HASMSX105.ger.corp.intel.com \
    --to=dariusz.stojaczyk@intel.com \
    --cc=changpeng.liu@intel.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.