From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED53EC10F03 for ; Thu, 25 Apr 2019 06:06:53 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AC55420811 for ; Thu, 25 Apr 2019 06:06:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC55420811 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57CDC1B554; Thu, 25 Apr 2019 08:06:52 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CDAFA2BC1; Thu, 25 Apr 2019 08:06:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP; 24 Apr 2019 23:06:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,392,1549958400"; d="scan'208";a="145669991" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 24 Apr 2019 23:06:49 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 23:06:49 -0700 Received: from hasmsx113.ger.corp.intel.com (10.184.198.64) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 23:06:49 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.47]) by HASMSX113.ger.corp.intel.com ([169.254.13.247]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 09:06:46 +0300 From: "Stojaczyk, Dariusz" To: "Lipiec, Herakliusz" , "Burakov, Anatoly" CC: "dev@dpdk.org" , "Lipiec, Herakliusz" , "jianfeng.tan@intel.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak Thread-Index: AQHU+fwytPkrDTNvG0WaaYm1vuwBL6ZMZflg Date: Thu, 25 Apr 2019 06:06:45 +0000 Message-ID: References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> <20190423174334.19612-1-herakliusz.lipiec@intel.com> <20190423174334.19612-5-herakliusz.lipiec@intel.com> In-Reply-To: <20190423174334.19612-5-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.102.11.37] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:44 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng.tan@intel.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak >=20 > When sending synchronous IPC requests, the caller must free the response > buffer even if the request returned failure. Fix the code to correctly > use the IPC API. >=20 > Bugzilla ID: 228 > Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel") > Cc: jianfeng.tan@intel.com > Cc: stable@dpdk.org > Signed-off-by: Herakliusz Lipiec > Acked-by: Anatoly Burakov > --- For the patch itself: Reviewed-by: Darek Stojaczyk