From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Stojaczyk, DariuszX" Subject: Re: [PATCH v3 3/3] vhost: access VhostUsrMsg via packed struct Date: Wed, 24 May 2017 13:12:07 +0000 Message-ID: References: <1494500208-78788-1-git-send-email-dariuszx.stojaczyk@intel.com> <1494513192-85863-1-git-send-email-dariuszx.stojaczyk@intel.com> <1494513192-85863-4-git-send-email-dariuszx.stojaczyk@intel.com> <20170522070130.GP2276@yliu-dev> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Verkamp, Daniel" To: Yuanhan Liu Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9C2927CC8 for ; Wed, 24 May 2017 15:12:13 +0200 (CEST) In-Reply-To: <20170522070130.GP2276@yliu-dev> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > This is for fixing compile warnings with new clang 4.0? >=20 > http://dpdk.org/ml/archives/dev/2017-April/064089.html >=20 > If so, please show the exact warning in the commit log. >=20 Everything compiles, but is undefined behavior. Accessing packed struct's = fields through pointers would have to be done as following: e.g vhost_user_set_vring_addr(struct virtio_net *dev, struct vhost_vring_ad= dr *addr __attribute__((aligned(1))) Since the code above is unacceptable, this patch makes all functions take p= ointer to the parent struct (VhostUserMsg) > > > > Signed-off-by: Daniel Verkamp > > Signed-off-by: Dariusz Stojaczyk > > --- > > Fixed checkpatch warnings >=20 > It's likely it will be easily missed while review. We normally do that: >=20 > --- >=20 > v3: fix checkpatch warnings >=20 > v2: remove gerrit id >=20 > --yliu Thanks, I'll stick with it from now on