From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Pravin Shelar" <pravin.ovn@gmail.com>
Cc: "Linux Kernel Network Developers" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"ovs dev" <dev@openvswitch.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Bindiya Kurle" <bindiyakurle@gmail.com>,
"Ilya Maximets" <i.maximets@ovn.org>,
mcroce@linux.microsoft.com
Subject: Re: [PATCH net] net: openvswitch: fix TTL decrement action netlink message format
Date: Tue, 24 Nov 2020 11:51:40 +0100 [thread overview]
Message-ID: <FBF56C40-90B7-4BAF-9AE3-B8304283E2D8@redhat.com> (raw)
In-Reply-To: <CAOrHB_Be-B8oLwx-zYXpwhjpQAWdkw1NrYh36S8e6bRH8X0cqg@mail.gmail.com>
On 20 Nov 2020, at 23:16, Pravin Shelar wrote:
> On Thu, Nov 19, 2020 at 1:04 AM Eelco Chaudron <echaudro@redhat.com>
> wrote:
>>
>> Currently, the openvswitch module is not accepting the correctly
>> formated
>> netlink message for the TTL decrement action. For both setting and
>> getting
>> the dec_ttl action, the actions should be nested in the
>> OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h
>> uapi.
>>
>> Fixes: 744676e77720 ("openvswitch: add TTL decrement action")
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> Thanks for working on this. can you share OVS kmod unit test for this
> action?
Hi Pravin,
I did add a self-test, however, my previous plan was to send out the
updated OVS patch after this change got accepted. But due to all the
comments, I sent it out anyway, so here it is with a datapath test:
https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377795.html
//Eelco
prev parent reply other threads:[~2020-11-24 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 9:04 [PATCH net] net: openvswitch: fix TTL decrement action netlink message format Eelco Chaudron
2020-11-20 21:12 ` Jakub Kicinski
2020-11-23 19:36 ` Matteo Croce
2020-11-24 1:57 ` Jakub Kicinski
2020-11-24 11:20 ` Eelco Chaudron
2020-11-24 11:19 ` Eelco Chaudron
2020-11-24 11:18 ` Eelco Chaudron
2020-11-20 22:16 ` Pravin Shelar
2020-11-24 10:51 ` Eelco Chaudron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBF56C40-90B7-4BAF-9AE3-B8304283E2D8@redhat.com \
--to=echaudro@redhat.com \
--cc=bindiyakurle@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pravin.ovn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.