From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nelson, Shannon" Subject: RE: [PATCH V2 5/5] i40e/ethtool: support coalesce setting by queue Date: Wed, 13 Jan 2016 18:19:30 +0000 Message-ID: References: <1451912041-8860-1-git-send-email-kan.liang@intel.com> <1451912041-8860-5-git-send-email-kan.liang@intel.com> <37D7C6CF3E00A74B8858931C1DB2F0770586E7D8@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "Brandeburg, Jesse" , "andi@firstfloor.org" , "f.fainelli@gmail.com" , "alexander.duyck@gmail.com" , "Kirsher, Jeffrey T" , "Wyborny, Carolyn" , "Skidmore, Donald C" , "Williams, Mitch A" , "ogerlitz@mellanox.com" , "edumazet@google.com" , "jiri@mellanox.com" , "sfeldma@gmail.com" , "gospo@cumulusnetworks.com" , "sasha.levin@oracle.com" , "dsahern@gmail.com" , "tj@kernel.org" , "cascardo@redhat.com" , "corbet@lwn.net" , "ben@decadent.org.uk" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "bwh@kernel.org" Return-path: Received: from mga04.intel.com ([192.55.52.120]:51598 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755846AbcAMSTc convert rfc822-to-8bit (ORCPT ); Wed, 13 Jan 2016 13:19:32 -0500 In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0770586E7D8@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > From: Liang, Kan > > > > This looks reasonable, but be aware that since there's no concept of > > queue-specific settings in the driver proper, these settings will get > lost on > > the next reset - see i40e_vsi_configure_msix(). A reset can be driven > by a > > number of things such as MTU changes, LLDP events, tx timeout recovery, > > promiscuous on/off, and various other configuration changes. This might > > not be acceptable for your needs. > > > > Yes, the reset could be an issue. > I guess we may make the concept of queue-specific settings for i40e by > moving > rx_itr_setting and tx_itr_setting to i40e_ring. > > How about the patch as below? > The patch only move itr_setting from i40e_vsi to i40e_ring. > There should be no behavior change. > Thanks, I finally had a chance to look through this. On an initial read-through, yes, this would probably take care of it. sln