From: Andy Lutomirski <luto@amacapital.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: paulmck@kernel.org, LKML <linux-kernel@vger.kernel.org>,
rcu@vger.kernel.org, Andrew Lutomirski <luto@kernel.org>,
X86 ML <x86@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joel@joelfernandes.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH x86/entry: Force rcu_irq_enter() when in idle task
Date: Fri, 12 Jun 2020 12:28:11 -0700 [thread overview]
Message-ID: <FE145E46-D160-4826-9D81-553EB2A660C1@amacapital.net> (raw)
In-Reply-To: <87r1ukxf1b.fsf@nanos.tec.linutronix.de>
> On Jun 12, 2020, at 12:25 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> "Paul E. McKenney" <paulmck@kernel.org> writes:
>>> On Fri, Jun 12, 2020 at 10:49:53AM -0700, Paul E. McKenney wrote:
>>> I will therefore address this issue in a follow-on patch.
>>
>> I should add that -your- patch from yesterday did -not- cause this
>> problem, in case that is of interest.
>
> So I still can add it back and amend the changelog and comment:
>
> Change the condition from !rcu_is_watching() to is_idle_task(current) ||
> rcu_is_watching() which enforces that interrupts in the idle task
> unconditionally invoke rcu_irq_enter() independent of the RCU state. For
> most scenarios is_idle_task() would be sufficient but Task RCU needs it
> according to Paul.
>
>
Can you easily get a call trace for a case where the system is fully booted, is_idle_task returns false, and rcu_is_watching() also returns false?
next prev parent reply other threads:[~2020-06-12 19:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 23:53 [PATCH RFC] x86/entry: Ask RCU if it needs rcu_irq_{enter,exit}() Paul E. McKenney
2020-06-11 23:54 ` Paul E. McKenney
2020-06-12 5:30 ` Andy Lutomirski
2020-06-12 12:40 ` Thomas Gleixner
2020-06-12 13:55 ` [PATCH x86/entry: Force rcu_irq_enter() when in idle task Thomas Gleixner
2020-06-12 14:26 ` Frederic Weisbecker
2020-06-12 14:47 ` Thomas Gleixner
2020-06-12 15:32 ` Andy Lutomirski
2020-06-12 17:49 ` Paul E. McKenney
2020-06-12 19:19 ` Paul E. McKenney
2020-06-12 19:25 ` Thomas Gleixner
2020-06-12 19:28 ` Andy Lutomirski [this message]
2020-06-12 19:34 ` Thomas Gleixner
2020-06-12 21:56 ` Paul E. McKenney
2020-06-12 19:50 ` [tip: x86/entry] " tip-bot2 for Thomas Gleixner
2020-06-15 20:16 ` [PATCH " Joel Fernandes
2020-06-16 8:40 ` Thomas Gleixner
2020-06-16 14:30 ` Joel Fernandes
2020-06-16 16:52 ` Andy Lutomirski
2020-06-12 9:27 ` [PATCH RFC] x86/entry: Ask RCU if it needs rcu_irq_{enter,exit}() Thomas Gleixner
2020-06-12 13:57 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FE145E46-D160-4826-9D81-553EB2A660C1@amacapital.net \
--to=luto@amacapital.net \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.