From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGSlZ-0000F6-Al for qemu-devel@nongnu.org; Thu, 01 Jun 2017 12:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGSlV-0006LE-8Z for qemu-devel@nongnu.org; Thu, 01 Jun 2017 12:16:05 -0400 Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:35223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dGSlU-0006Ks-Rk for qemu-devel@nongnu.org; Thu, 01 Jun 2017 12:16:01 -0400 Received: by mail-pf0-x233.google.com with SMTP id n23so31347354pfb.2 for ; Thu, 01 Jun 2017 09:16:00 -0700 (PDT) From: Ben Warren Message-Id: Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Date: Thu, 1 Jun 2017 09:15:58 -0700 In-Reply-To: <20170601175107-mutt-send-email-mst@kernel.org> References: <20170529151047.85390-1-ben@skyportsystems.com> <20170601172020-mutt-send-email-mst@kernel.org> <20170601175107-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: =?utf-8?Q?Marc-Andr=C3=A9_Lureau?= , qemu devel list , Igor Mammedov , Laszlo Ersek > On Jun 1, 2017, at 7:52 AM, Michael S. Tsirkin wrote: >=20 > On Thu, Jun 01, 2017 at 07:46:24AM -0700, Ben Warren wrote: >>=20 >>> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin = wrote: >>>=20 >>> On Thu, Jun 01, 2017 at 08:10:27AM +0000, Marc-Andr=C3=A9 Lureau = wrote: >>>> Hi >>>>=20 >>>> On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel < >>>> qemu-devel@nongnu.org> wrote: >>>>=20 >>>> From: Ben Warren >>>>=20 >>>> The following tests are implemented: >>>> * test that a GUID passed in by command line is propagated to the = guest. >>>> Read the GUID from guest memory >>>> * test that the "auto" argument to the GUID generates a valid = GUID, as >>>> seen by the guest. >>>> * test that a GUID passed in can be queried from the monitor >>>>=20 >>>> This patch is loosely based on a previous patch from: >>>> Gal Hammer and Igor Mammedov = >>>>=20 >>>> Signed-off-by: Ben Warren >>>> Reviewed-by: Igor Mammedov >>>> --- >>>=20 >>> What happened to indentation here? >>>=20 >> I don=E2=80=99t know, this is unchanged from the patch that passed = through the gauntlet earlier this year, other than rebasing. If you can = please clarify exactly what you see that is wrong, that=E2=80=99ll be = helpful. >=20 > That question is directed to Marc-Andr=C3=A9 - when he replied to your = patch > he has corrupted the indentation. OK :) Thanks >=20 >>>> + * in order to implement the "OVMF SDT Header probe >>>> suppressor" >>>> + * see docs/specs/vmgenid.txt for more details >>>> + */ >>>> + return vgid_table.vgia_val + VMGENID_GUID_OFFSET; >>>> + } >>>>=20 >>>>=20 >>>> It leaks tables >>>>=20 >>>> Other than that: >>>> Reviewed-by: Marc-Andr=C3=A9 Lureau >>>=20 >>> Ben, are you going to post a version that doesn't leak? >> Yes, I=E2=80=99ll try to get to it today. >>=20 >> =E2=80=94Ben