All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/10] power: spl: add SPL_DM_REGULATOR_FIXED in Kconfig
Date: Wed, 13 Sep 2017 10:20:24 +0200	[thread overview]
Message-ID: <FF2A7128-0E8E-4401-9C80-AB3CBE6CFBA5@theobroma-systems.com> (raw)
In-Reply-To: <CAPnjgZ2yzp0tKa93SWb4+q1usX81czHo3g4_OZHdSUwzjcsGFA@mail.gmail.com>


> On 13 Sep 2017, at 06:26, Simon Glass <sjg@chromium.org> wrote:
> 
> On 11 September 2017 at 05:59, Philipp Tomsich
> <philipp.tomsich@theobroma-systems.com> wrote:
>> The Makefile already tests for SPL_DM_REGULATOR_FIXED, but Kconfig
>> does not provide it.  This adds SPL_DM_REGULATOR_FIXED to Kconfig.
>> 
>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>> 
>> drivers/power/regulator/Kconfig | 7 +++++++
>> 1 file changed, 7 insertions(+)
>> 
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Should that default to y?

I am undecided, as pretty much any default will be wrong for most people.
Fortunately it can be easily changed via defconfig or from implying it from
one of the other Kconfig sections.

My reasoning behind not making it the default was that a large number of
boards will have DM_REGULATOR_FIXED enabled (e.g. for enabling some
of the USB path), but many of the boards will not need it at the SPL stage.
If we’d make this the default, we might see increases in size (and some SPL
stages exceeding their size limit) from this change.

I’d more more than happy to make it the default, though.

  reply	other threads:[~2017-09-13  8:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 11:59 [U-Boot] [PATCH 00/10] For the RK3399-Q7, we have a few additional features in the SPL boot Philipp Tomsich
2017-09-11 11:59 ` [U-Boot] [PATCH 01/10] rockchip: rk3399: make spl_board_init board-specific Philipp Tomsich
2017-09-13  4:25   ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 02/10] rockchip: bootrom: add definitions to retrieve BROM boot-source Philipp Tomsich
2017-09-13  4:25   ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 03/10] rockchip: spl: add documentation for spl_node_to_boot_device() Philipp Tomsich
2017-09-13  4:25   ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 04/10] rockchip: spl: support a 'same-as-spl'-specifier in the spl-boot-order Philipp Tomsich
2017-09-13  4:25   ` Simon Glass
2017-09-13  8:13     ` Dr. Philipp Tomsich
2017-09-11 11:59 ` [U-Boot] [PATCH 05/10] rockchip: spl: rk3399: implement chip-specific board_spl_was_booted_from() Philipp Tomsich
2017-09-13  4:25   ` Simon Glass
2017-09-13  8:10     ` Dr. Philipp Tomsich
2017-09-11 11:59 ` [U-Boot] [PATCH 06/10] rockchip: dts: rk3399-puma: add 'same-as-spl' to the front of the boot-order Philipp Tomsich
2017-09-13  4:26   ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 07/10] rockchip: puma-rk3399: update board_init() Philipp Tomsich
2017-09-13  4:26   ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 08/10] rockchip: rk3399-puma: add boot-on regulator to override BIOS_DISABLE Philipp Tomsich
2017-09-13  4:26   ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 09/10] power: spl: add SPL_DM_REGULATOR_FIXED in Kconfig Philipp Tomsich
2017-09-13  4:26   ` Simon Glass
2017-09-13  8:20     ` Dr. Philipp Tomsich [this message]
2017-09-17 17:52       ` Simon Glass
2017-09-11 11:59 ` [U-Boot] [PATCH 10/10] rockchip: defconfig: puma-rk3399: update for DM_REGULATOR support in SPL Philipp Tomsich
2017-09-13  4:26   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FF2A7128-0E8E-4401-9C80-AB3CBE6CFBA5@theobroma-systems.com \
    --to=philipp.tomsich@theobroma-systems.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.