From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sharma, Shashank" Subject: Re: [PATCH 0/6] Intel Color Manager Framework Date: Fri, 21 Feb 2014 03:34:43 +0000 Message-ID: References: <1392899847-2641-1-git-send-email-shashank.sharma@intel.com> <20140220131129.GG3852@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20140220131129.GG3852@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: =?iso-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: "intel-gfx@lists.freedesktop.org" , "Shankar, Uma" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org Hi Ville/All, We gave a presentation on design on this framework, few months ago, in one = of our common forum with OTC folks. = We discussed, took review comments, and re-designed the framework, as per = the feedbacks. = We also discussed the benefits of providing the controls directly from /sys= fs over going for a UI manager based property settings. So I don't understand where are we going wrong, can you please elaborate a = bit ? = This is just a basic design, and once go ahead with this, we can always wor= k on making hardware agnostic, as you recommended. = IMHO, controls from /sysfs would be a very generic interface for all linux/= drm based platform, where any userspace can read/write and control properti= es. = We don't even need a UI manager or a minimum executable to play around, jus= t a small script can do. But we can always write something on top of this, to be included in any UI framework or property. = = Regards Shashank = -----Original Message----- From: Ville Syrj=E4l=E4 [mailto:ville.syrjala@linux.intel.com] = Sent: Thursday, February 20, 2014 6:41 PM To: Sharma, Shashank Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma; dri-devel@lists.freedesk= top.org Subject: Re: [Intel-gfx] [PATCH 0/6] Intel Color Manager Framework On Thu, Feb 20, 2014 at 06:07:21PM +0530, Shashank Sharma wrote: > Color manager is a new framework in i915 driver, which provides a = > unified interface for various color correction methods supported by = > intel hardwares. The high level overview of this change is: Would have been good to discuss this idea before implementing it. The plan = is to use kms properties for this kind of stuff which allows us to hook it = up with the upcoming atomic modeset API. Just yesterday there was some disc= ussion on #dri-devel about exposing user settable blob properties even befo= re the atomic modeset API lands (it was always the plan for the atomic mode= set API anyway). So based on a cursory glance, this looks like it's going i= n the wrong direction. Also ideally the properties should be hardware agnostic, so a generic users= pace could use them regardless of the hardware/driver. Obviously that might= not be possible in all cases, but we should at least spend a bit of effort= on trying to make that happen for most properties. -- Ville Syrj=E4l=E4 Intel OTC