From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yongseok Koh Subject: Re: Mellanox ConnectX-5 crashes and mbuf leak Date: Sat, 7 Oct 2017 22:19:14 +0000 Message-ID: References: <5d1f07c4-5933-806d-4d11-8fdfabc701d7@allegro-packets.com> <374F8C13-CFB0-42FD-8993-BF7F0401F891@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Ferruh Yigit To: Martin Weiser Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0074.outbound.protection.outlook.com [104.47.1.74]) by dpdk.org (Postfix) with ESMTP id 416762B9E for ; Sun, 8 Oct 2017 00:19:17 +0200 (CEST) In-Reply-To: <374F8C13-CFB0-42FD-8993-BF7F0401F891@mellanox.com> Content-Language: en-US Content-ID: <991FBEDDB0E21C4DB3653AE28C90E6A3@eurprd05.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Oct 6, 2017, at 3:30 PM, Yongseok Koh wrote: >=20 > Hi, Martin >=20 > Even though I had done quite serious tests before sending out the patch, > I figured out deadlock could happen if the Rx queue size is smaller. It i= s 128 > by default in testpmd while I usually use 256. >=20 > I've fixed the bug and submitted a new patch [1], which actually reverts = the > previous patch. So, you can apply the attached with disregarding the old = one. >=20 > And I have also done extensive tests for this new patch but please let me= know > your test results. >=20 > [1] > "net/mlx5: fix deadlock due to buffered slots in Rx SW ring" > at http://dpdk.org/dev/patchwork/patch/29847 Hi Martin I've submitted v2 of the patch [1]. I just replaced vector insns with regul= ar statements. This is just for ease of maintenance because I'm about to add vectorized PMD for ARM NEON. In terms of functionality and performance it = is identical. Please proceed your testing with this and let me know the result. [1] [dpdk-dev,v2] net/mlx5: fix deadlock due to buffered slots in Rx SW ring , which is at http://dpdk.org/dev/patchwork/patch/29879/ Thanks, Yongseok