All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	Bhupesh Sharma <bhsharma@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>
Subject: RE: [PATCH 1/2] x86/efi: Unmap efi boot services code/data regions from efi_pgd
Date: Mon, 22 Oct 2018 17:35:36 +0000	[thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F485D5D88@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <CALCETrW=M8u=F6USUk3t_sucGnU-8K6sLYOq6BGK1JhPdgjzdw@mail.gmail.com>

> > The one bit that is odd is the cpa->pfn field - for unmapped pages
> > that's totally uninteresting and I'm wondering whether setting it to 0
> > wouldn't be better.
> >
> > Does the CPU _ever_ look look at the PFN if the page is
> > !_PAGE_PRESENT, for example speculatively? If yes then what is the
> > recommended value for the pfn - zero perhaps?
> >
> 
> This is L1TF, right?  Isn't all ones the recommended value?
> 
> I would love to see EFI start treating its mm just like any other mm at some
> point, though.  That is, it should not modify any mappings in the kernel range,
> and it could use the regular mm modification APIs for the user range.  But maybe
> this is a pipe dream.

Sounds good to me. I have some more fixes for EFI code and as soon as they are done, 
I will start looking into this.

Regards,
Sai

  reply	other threads:[~2018-10-22 17:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22  1:35 [PATCH 0/2] Unmap efi boot services code/data regions after boot Sai Praneeth Prakhya
2018-10-22  1:35 ` [PATCH 1/2] x86/efi: Unmap efi boot services code/data regions from efi_pgd Sai Praneeth Prakhya
2018-10-22  1:57   ` Ingo Molnar
2018-10-22  3:00     ` Prakhya, Sai Praneeth
2018-10-22  4:58     ` Andy Lutomirski
2018-10-22 17:35       ` Prakhya, Sai Praneeth [this message]
2018-10-22 14:12     ` Dave Hansen
2018-10-22 17:36       ` Prakhya, Sai Praneeth
2018-10-22  1:35 ` [PATCH 2/2] x86/efi: Move efi_<reserve/free>_boot_services() to arch/x86 Sai Praneeth Prakhya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FFF73D592F13FD46B8700F0A279B802F485D5D88@ORSMSX114.amr.corp.intel.com \
    --to=sai.praneeth.prakhya@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhsharma@redhat.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.