From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71530C4320A for ; Sun, 22 Aug 2021 11:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D7416103C for ; Sun, 22 Aug 2021 11:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233371AbhHVLRX convert rfc822-to-8bit (ORCPT ); Sun, 22 Aug 2021 07:17:23 -0400 Received: from aposti.net ([89.234.176.197]:45274 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232822AbhHVLRX (ORCPT ); Sun, 22 Aug 2021 07:17:23 -0400 Date: Sun, 22 Aug 2021 12:16:29 +0100 From: Paul Cercueil Subject: Re: [PATCH 1/3] serial: 8250_ingenic: Use of_device_get_match_data To: Tang Bin Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, ldewangan@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux@prisktech.co.nz, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Zhang Shengju Message-Id: In-Reply-To: <20210822032806.3256-2-tangbin@cmss.chinamobile.com> References: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> <20210822032806.3256-2-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi, Le dim., août 22 2021 at 11:28:04 +0800, Tang Bin a écrit : > Retrieve OF match data, it's better and cleaner to use > 'of_device_get_match_data' over 'of_match_device'. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Acked-by: Paul Cercueil Cheers, -Paul > --- > drivers/tty/serial/8250/8250_ingenic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_ingenic.c > b/drivers/tty/serial/8250/8250_ingenic.c > index 988bf6bcc..65402d05e 100644 > --- a/drivers/tty/serial/8250/8250_ingenic.c > +++ b/drivers/tty/serial/8250/8250_ingenic.c > @@ -209,16 +209,14 @@ static int ingenic_uart_probe(struct > platform_device *pdev) > struct uart_8250_port uart = {}; > struct ingenic_uart_data *data; > const struct ingenic_uart_config *cdata; > - const struct of_device_id *match; > struct resource *regs; > int irq, err, line; > > - match = of_match_device(of_match, &pdev->dev); > - if (!match) { > + cdata = of_device_get_match_data(&pdev->dev); > + if (!cdata) { > dev_err(&pdev->dev, "Error: No device match found\n"); > return -ENODEV; > } > - cdata = match->data; > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > -- > 2.20.1.windows.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE32C4338F for ; Sun, 22 Aug 2021 11:19:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40F3961267 for ; Sun, 22 Aug 2021 11:19:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40F3961267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BQvcM2+w21rucR6T1cmc3nGX8tmdiwbRgaHHd7XEv5w=; b=epqfsoVSNII4GMXCoN98FrrD6w R0gxGNQOWNDmzDRIRFL7UVxjUyJltyk4WpOTr7PnSAs1sVBh7/hAPgik8eIlJY3WrbFCzONF48do6 fetaLcMC7ti+TgtX7lGzGnG7ha9yi+lanOGewRGATG27IrSr6oBPR11NXRXPsKPWtHVjh+pRm914P O0PfHV73uzvQxzj6/yKuzC+DGRmqsPgADuY4qZP+Uz6Bpj8SlBPUEZ3CVDQ4i2zQNci1JBv7xP/Da /XH9bY0HIFqW/ClbB2VPFF7uVFV3jDQI6oeIZwO292tjr7/73EJg+9ceBa2mXTtYDlGdQfeoj0zd1 sNJankBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHlTA-00DuDW-OU; Sun, 22 Aug 2021 11:16:52 +0000 Received: from aposti.net ([89.234.176.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHlT7-00DuBe-Ks for linux-arm-kernel@lists.infradead.org; Sun, 22 Aug 2021 11:16:51 +0000 Date: Sun, 22 Aug 2021 12:16:29 +0100 From: Paul Cercueil Subject: Re: [PATCH 1/3] serial: 8250_ingenic: Use of_device_get_match_data To: Tang Bin Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, ldewangan@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux@prisktech.co.nz, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Zhang Shengju Message-Id: In-Reply-To: <20210822032806.3256-2-tangbin@cmss.chinamobile.com> References: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> <20210822032806.3256-2-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210822_041649_886368_102E6DEF X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Le dim., ao=FBt 22 2021 at 11:28:04 +0800, Tang Bin = a =E9crit : > Retrieve OF match data, it's better and cleaner to use > 'of_device_get_match_data' over 'of_match_device'. > = > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Acked-by: Paul Cercueil Cheers, -Paul > --- > drivers/tty/serial/8250/8250_ingenic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/tty/serial/8250/8250_ingenic.c = > b/drivers/tty/serial/8250/8250_ingenic.c > index 988bf6bcc..65402d05e 100644 > --- a/drivers/tty/serial/8250/8250_ingenic.c > +++ b/drivers/tty/serial/8250/8250_ingenic.c > @@ -209,16 +209,14 @@ static int ingenic_uart_probe(struct = > platform_device *pdev) > struct uart_8250_port uart =3D {}; > struct ingenic_uart_data *data; > const struct ingenic_uart_config *cdata; > - const struct of_device_id *match; > struct resource *regs; > int irq, err, line; > = > - match =3D of_match_device(of_match, &pdev->dev); > - if (!match) { > + cdata =3D of_device_get_match_data(&pdev->dev); > + if (!cdata) { > dev_err(&pdev->dev, "Error: No device match found\n"); > return -ENODEV; > } > - cdata =3D match->data; > = > irq =3D platform_get_irq(pdev, 0); > if (irq < 0) > -- > 2.20.1.windows.1 > = > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel